From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261AbcIOOyr (ORCPT ); Thu, 15 Sep 2016 10:54:47 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:17785 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbcIOOyP (ORCPT ); Thu, 15 Sep 2016 10:54:15 -0400 X-AuditID: cbfec7f5-f79ce6d000004c54-cd-57dab612d635 Subject: Re: [PATCH v2] leds: Introduce userspace leds driver To: Pavel Machek Cc: David Lechner , Richard Purdie , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Marcel Holtmann From: Jacek Anaszewski Message-id: <69e2865f-8ba9-ea1a-594f-3de4131e3ea2@samsung.com> Date: Thu, 15 Sep 2016 16:54:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20160915130110.GI13132@amd> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42LZduzneV2hbbfCDTZuMrZY1CBmcXnXHDaL rW/WMVp8+/SL0eLuqaNsFrt3PWV1YPNYv3s5u8en/pOsHnvm/2D1WLH6O7vH501yAaxRXDYp qTmZZalF+nYJXBn7371mKZjMVbHl6h+2Bsa/7F2MnBwSAiYSu+duZ4awxSQu3FvP1sXIxSEk sJRRYv2iL1DOZ0aJt1P/McF0rG3YBZVYxiixau8LKOcZo8TeLRBVwgK2Ej/f/mYBsUUE5CW2 9q1gBiliFtjIKHHl9DKwhWwChhI/X7wGauDg4BWwk2j6LQQSZhFQlZjz4Q0LSFhUIEJi991U kDCvgKDEj8n3wEZyCmhKvFvSwQZiMws4SjxYtJMVwpaX2LzmLdQ7i9gl/pwrBhkjISArsekA VNhF4snzdawQtrDEq+NboCEhI9HZcZAJ5EoJgcmMEheP3WSFcFYzSmzs7GSBqLKWaPj/iwVi GZ/EpG3TmSEW8Ep0tAlBlHhIPPr1BarcUWLShm/MkPB5zSgxuXsH6wRG+VlI/pmF5IdZSH5Y wMi8ilEktbQ4Nz212FSvODG3uDQvXS85P3cTIzCJnP53/OsOxqXHrA4xCnAwKvHwrph7K1yI NbGsuDL3EKMEB7OSCO+2LUAh3pTEyqrUovz4otKc1OJDjNIcLErivHsWXAkXEkhPLEnNTk0t SC2CyTJxcEo1MKZ4xfLbLEjLmmMgo5i9oLWlMWDXvn9PSmINmBlDnI+tnmApe2RbvKLX1X9l 5eclbabX8hRZ3TF+UHVJVot9v/uJ4Mx3N758nZ+2nqH1ZE+QMFvWPu3XL1mCDqbulMldznoj n4X3X3B4rP8TNuvoELGPc/cq75v+qHvCFYdddxMutVz7z3jTTomlOCPRUIu5qDgRAE3sPU4e AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t/xq7rPtt4KN+j7wG6xqEHM4vKuOWwW W9+sY7T49ukXo8XdU0fZLHbvesrqwOaxfvdydo9P/SdZPfbM/8HqsWL1d3aPz5vkAlij3Gwy UhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X 4Jax/91rloLJXBVbrv5ha2D8y97FyMkhIWAisbZhFxuELSZx4d56IJuLQ0hgCaPE2ra77BDO M0aJgwsOM4FUCQvYSvx8+5sFxBYRkJfY2reCGaLoNaPEvPmbGEEcZoGNjBKf+9Yzg1SxCRhK /HzxGqibg4NXwE6i6bcQSJhFQFVizoc3YINEBSIkbq36yAhi8woISvyYfA8szimgKfFuSQfY ecxAixe8X8cCYctLbF7zlnkCo8AsJC2zkJTNQlK2gJF5FaNIamlxbnpusaFecWJucWleul5y fu4mRmBMbTv2c/MOxksbgw8xCnAwKvHwBsy+FS7EmlhWXJl7iFGCg1lJhHfbFqAQb0piZVVq UX58UWlOavEhRlOgJyYyS4km5wPjPa8k3tDE0NzS0MjYwsLcyEhJnLfkw5VwIYH0xJLU7NTU gtQimD4mDk6pBkavqxuOC8815EsSDQvuvHBXPP1fblTVlT+F/fP63J/9ePg4VOtnT5Lyp/kd BkkvtKJX3TFbrTPzQOWxjDtfmGoylzz8U7RQKbm74GHzRM6JKmFbnDPWxkm1i75/xHuo1n9y R8jSjxZqMfNzPFNyfZ/eSXt77+XH2QEb2fhffOPdIapgNmHz+UolluKMREMt5qLiRADyqVPs vwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160915145410eucas1p2049039c65214809221b2355dc58f46f6 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160915130121eucas1p2c9d50e28e391714182b63eb29709847b X-RootMTR: 20160915130121eucas1p2c9d50e28e391714182b63eb29709847b References: <1473361440-9668-1-git-send-email-david@lechnology.com> <84510542-4faa-9763-611a-be3890f3f1f7@samsung.com> <20160915130110.GI13132@amd> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On 09/15/2016 03:01 PM, Pavel Machek wrote: > Hi! > >>> @@ -0,0 +1,23 @@ >>> +/* >>> + * Userspace driver support for leds subsystem >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + */ >>> +#ifndef _UAPI__ULEDS_H_ >>> +#define _UAPI__ULEDS_H_ >>> + >>> +#define ULEDS_MAX_NAME_SIZE 80 >>> + >>> +struct uleds_user_dev { >>> + char name[ULEDS_MAX_NAME_SIZE]; >>> +}; > > We already have path component length limit somewhere, right? Just use > it? > > (And is struct with char array good idea at all? Perphaps it can just > use write() length up to something reasonable, and not bother with new > header file for userspace?) In fact in this case the addition of another public header can be avoided. -- Best regards, Jacek Anaszewski