mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: Alessandro Ghedini <al3xbio@gmail.com>
Cc: gregkh@suse.de, jmm@debian.org, mithlesh@linsyssoft.com,
	karllinuxtest.relton@ntlworld.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: wlan-ng: fix most of the style issues in  hfa384x.h
Date: Sun, 14 Feb 2010 23:01:25 +0100	[thread overview]
Message-ID: <69e28c911002141401q3ca8810djc5f1775dfd0d6f3@mail.gmail.com> (raw)
In-Reply-To: <1266178376-6763-1-git-send-email-al3xbio@gmail.com>

You posted the wrong patch - this is only an interdiff.

Also, it might be a good idea to reduce the spacing for all entries,
not just these "overdone" ones, to keep them lined-up nicely.

On Sun, Feb 14, 2010 at 9:12 PM, Alessandro Ghedini <al3xbio@gmail.com> wrote:
> This patch fixes all the errors and the majority of the warnings found with
> checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints
>
> Signed-off-by: Alessandro Ghedini <al3xbio@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 8e39f76..3d440f8 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -63,15 +63,9 @@
>  /*--- Mins & Maxs -----------------------------------*/
>  #define                HFA384x_PORTID_MAX              ((u16)7)
>  #define                HFA384x_NUMPORTS_MAX            ((u16)(HFA384x_PORTID_MAX+1))
> -#define                HFA384x_PDR_LEN_MAX             ((u16)512)      /*
> -                                                                * in bytes,
> -                                                                * from EK
> -                                                                */
> +#define                HFA384x_PDR_LEN_MAX     ((u16)512)      /* in bytes, from EK */
>  #define                HFA384x_PDA_RECS_MAX            ((u16)200)      /* a guess */
> -#define                HFA384x_PDA_LEN_MAX             ((u16)1024)     /*
> -                                                                * in bytes,
> -                                                                * from EK
> -                                                                */
> +#define                HFA384x_PDA_LEN_MAX     ((u16)1024)     /* in bytes, from EK*/
>  #define                HFA384x_SCANRESULT_MAX          ((u16)31)
>  #define                HFA384x_HSCANRESULT_MAX         ((u16)31)
>  #define                HFA384x_CHINFORESULT_MAX        ((u16)16)
> --
> 1.6.6.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

      reply	other threads:[~2010-02-14 22:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14 20:12 Alessandro Ghedini
2010-02-14 22:01 ` Gábor Stefanik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e28c911002141401q3ca8810djc5f1775dfd0d6f3@mail.gmail.com \
    --to=netrolller.3d@gmail.com \
    --cc=al3xbio@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=jmm@debian.org \
    --cc=karllinuxtest.relton@ntlworld.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mithlesh@linsyssoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®