From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: Daniel Ngu <daniel.dy.ngu@gmail.com>
Cc: Stefano Brivio <stefano.brivio@polimi.it>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style
Date: Mon, 22 Mar 2010 14:40:27 +0100 [thread overview]
Message-ID: <69e28c911003220640t77d01dccod8232ea007257a5f@mail.gmail.com> (raw)
In-Reply-To: <20100322115244.GA10368@zooey>
On Mon, Mar 22, 2010 at 12:52 PM, Daniel Ngu <daniel.dy.ngu@gmail.com> wrote:
> WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Daniel Ngu <daniel.dy.ngu@gmail.com>
> ---
> drivers/net/wireless/b43/main.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 1521b1e..14cf3bd 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -4348,11 +4348,10 @@ static int b43_wireless_core_init(struct b43_wldev *dev)
> b43_set_phytxctl_defaults(dev);
>
> /* Minimum Contention Window */
> - if (phy->type == B43_PHYTYPE_B) {
> + if (phy->type == B43_PHYTYPE_B)
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0x1F);
> - } else {
> + else
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0xF);
> - }
> /* Maximum Contention Window */
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MAXCONT, 0x3FF);
>
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Actually I believe the entire PHYTYPE_B brahcn could be removed, as we
no longer have B-PHY support in b43 anyway. But consult Michael about
this.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
prev parent reply other threads:[~2010-03-22 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 11:52 Daniel Ngu
2010-03-22 13:40 ` Gábor Stefanik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e28c911003220640t77d01dccod8232ea007257a5f@mail.gmail.com \
--to=netrolller.3d@gmail.com \
--cc=daniel.dy.ngu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome