From: Mike Christie <michael.christie@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the 6.4+ merge window
Date: Mon, 3 Jul 2023 12:09:12 -0500 [thread overview]
Message-ID: <69eeacda-d59c-bec8-d115-4bf7c97d7690@oracle.com> (raw)
In-Reply-To: <CAHk-=wjgnB11KzroXS+Gi1TQO19uf0FvkMBn=V7mcQ8q78ucnQ@mail.gmail.com>
On 6/30/23 2:14 PM, Linus Torvalds wrote:
> On Thu, 29 Jun 2023 at 05:48, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
>>
>> We have a couple of major core changes impacting other
>> systems: Command Duration Limits, which spills into block and ATA and
>> block level Persistent Reservation Operations, which touches block,
>> nvme, target and dm (both of which are added with merge commits
>> containing a cover letter explaining what's going on).
>
> Random side note - as an outsider that then sees a trivial conflict
> due to the split of the nmve side into a file called 'pr.c', I can
> only say that my reaction to that was "what a horrible filename".
>
> Maybe it makes sense to people that are very into nvme, but honestly,
> considering it's a new special thing, I kind of doubt it.
>
> We really don't lack the disk-space to use more descriptive names for
> files. "pr.c" really is pretty horrid.
cc'ing the nvme list because it's their file.
PR stands for persistent reservation. It's from the SCSI days so the
term and abbreviation is common to SCSI people and nvme developers that
used to work on that. I can see how a new storage person would not be
familiar with it.
Maybe name it persistent_reservation.c, or if people think that's too
long does persistent_resv.c make sense since we use the "resv"
abbreviation for reservation in nvme and the block layer.
next prev parent reply other threads:[~2023-07-03 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 12:48 James Bottomley
2023-06-30 19:14 ` Linus Torvalds
2023-07-03 17:09 ` Mike Christie [this message]
2023-07-03 17:25 ` Linus Torvalds
2023-06-30 19:28 ` pr-tracker-bot
2023-09-02 7:39 James Bottomley
2023-09-02 19:08 ` Linus Torvalds
2023-09-03 7:41 ` James Bottomley
2023-09-02 19:18 ` pr-tracker-bot
2023-11-02 12:28 James Bottomley
2023-11-03 1:26 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69eeacda-d59c-bec8-d115-4bf7c97d7690@oracle.com \
--to=michael.christie@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®