mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: aidenisik@member.fsf.org,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Aiden Isik <aidenisik+git@member.fsf.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 3/3] clk: samsung: Introduce Exynos5515 clock driver
Date: Mon, 7 Sep 2026 12:01:22 +0200	[thread overview]
Message-ID: <69f1c866-a4cb-4b9a-8958-f56391655bac@kernel.org> (raw)
In-Reply-To: <20260818-for-next-lucky7-clock-v2-3-cda0cc80f158@member.fsf.org>

On 18/08/2026 23:58, Aiden Isik via B4 Relay wrote:
> From: Aiden Isik <aidenisik@member.fsf.org>
> 
> CMU_TOP is the top level clock management unit which contains PLLs,
> muxes, dividers and gates that feed the other clock management units.
> 
> CMU_PERI provides clocks for USI blocks and their children, PWM, MCT,
> and watchdog timers.
> 
> CMU_FSYS provides clocks for MMC, USB, GPIO, etc.
> 

You have checkpatch warning.

CHECK: Blank lines aren't necessary after an open brace '{'
#494: FILE: drivers/clk/samsung/clk-exynos5515.c:457:
+static const struct samsung_div_clock top_div_clks[] __initconst = {

Be sure you address all of them before posting patches.

Fixed it up.


Best regards,
Krzysztof

  reply	other threads:[~2026-09-07 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 21:58 [PATCH v2 0/3] clk: samsung: Introduce Exynos5515 clock driver support Aiden Isik via B4 Relay
2026-08-18 21:58 ` [PATCH v2 1/3] dt-bindings: clock: Add Exynos5515 SoC Aiden Isik via B4 Relay
2026-08-21  7:55   ` Krzysztof Kozlowski
2026-08-18 21:58 ` [PATCH v2 2/3] clk: samsung: clk-pll: Add support for pll_309 Aiden Isik via B4 Relay
2026-08-18 21:58 ` [PATCH v2 3/3] clk: samsung: Introduce Exynos5515 clock driver Aiden Isik via B4 Relay
2026-09-07 10:01   ` Krzysztof Kozlowski [this message]
2026-09-07 11:29     ` Aiden Isik
2026-09-07 10:02 ` [PATCH v2 0/3] clk: samsung: Introduce Exynos5515 clock driver support Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69f1c866-a4cb-4b9a-8958-f56391655bac@kernel.org \
    --to=krzk@kernel.org \
    --cc=aidenisik+git@member.fsf.org \
    --cc=aidenisik@member.fsf.org \
    --cc=alim.akhtar@samsung.com \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®