From: "David B. Robins" <linux@davidrobins.net>
To: David Miller <davem@davemloft.net>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure
Date: Mon, 05 Oct 2015 09:40:04 -0400 [thread overview]
Message-ID: <69f8994562da8cb064f138b162a99c4d@i4031.net> (raw)
In-Reply-To: <20151005.033155.2121849340240343993.davem@davemloft.net>
On 2015-10-05 06:31, David Miller wrote:
> From: "David B. Robins" <linux@davidrobins.net>
> Date: Wed, 30 Sep 2015 16:20:04 -0400
>
>> If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will
>> return
>> but not clear rx->size. rx points to driver private data. A later call
>> assumes that nonzero size means ax_skb was allocated and passes a null
>> ax_skb to skb_put. Changed allocation failure return to clear size
>> first.
>>
>> Found testing board with AX88772B devices.
>>
>> Signed-off-by: David B. Robins <linux@davidrobins.net>
>
> Applied, thanks.
While I am happy for the patch I submitted to be applied, and it is
consistent with existing error handling and does fix the specific issue,
I believe a later series of 5 patches by Dean Jenkins that more
comprehensively address the issue (grouped under subject "Improve ASIX
RX memory allocation error handling") should be preferred.
prev parent reply other threads:[~2015-10-05 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 20:20 David B. Robins
2015-10-05 10:31 ` David Miller
2015-10-05 13:40 ` David B. Robins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69f8994562da8cb064f138b162a99c4d@i4031.net \
--to=linux@davidrobins.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®