From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DD1346AD7 for ; Fri, 10 Apr 2026 10:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775816147; cv=none; b=IzYxq7sWeQOyS74+4tBzui7S4mGFB/580ZpxD2P8op3wm1RNR1VuuZrJW8rZgmVFquPniDCk7AYX8XVhXq8sp+I1Eckc7J9NC8dcAaDz8TSycDYvtERvVmSoG5iSk+3mhv5WPUDvXtAiY8xISMXMcQ99zLmSXtpfCbGzyZmwe4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775816147; c=relaxed/simple; bh=acKCtBBY5beJJNJxkoJd+8Z4H/GcU/gRY0KIHaFXnmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UmicUrKyg6qqlMZ1i5J4VtbOeRj23y2h9txidFFNrBSkvI7KuZKihbJIzCU4NywnamqBl4zvy/0xAxHyJUZ0O9e8R3CC09JL/dSPHAFJqGZXYPuJbef/MPXop4b74jTyW2m9p7V1mOYC0MfnzEJAeciqByzBp/KtrYSHXa8d+lQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M7Y330Oh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XSUab+LQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M7Y330Oh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XSUab+LQ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A7LpP73934926 for ; Fri, 10 Apr 2026 10:15:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xnUoPeyCpQ8Rchdbsf90x2AVJoXX8svgOzQ8+c1SLPk=; b=M7Y330OhOedqkhkf VeFi11Ur0gycO8qw/fbCJ41a1u/eULKUBLQ+NOeyG+350lApkNfXxqTecd1ndsJe OuVdFlAA+tEdfsPohYTxLtC29QBhHCuCCorLJWce2lXGxHtqru7ULFPDl3PhHCPa KnSxEzV+3Bt0W+1cx6a175NHg9B6nTtjdGV84sCcI1Nfr58qn+pFRaX39HU+To5u vjbFCo9l5/N8C/nJMtCsNs8kYKwjUmpZZ5KYBda7UdI1pye8KIsEvkWk2TdPjINi MCmCot49Gy+hVP6rDIPRrXwVwVaod8ilBrqYHsLU5B/mvAJ8r3C32IiDlZawh4Db +q+zAA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ded5sbmqd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 10:15:45 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89cd541c0edso8454516d6.1 for ; Fri, 10 Apr 2026 03:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775816145; x=1776420945; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xnUoPeyCpQ8Rchdbsf90x2AVJoXX8svgOzQ8+c1SLPk=; b=XSUab+LQvNjixZcUvnHwykHjqQuASHx6bDSY4B5KfPW9m1fflZC3ZofBsYwhv58Chh fv6Zg5+NPYBlfWGMk9Q48QDiI+pvQmUhtet5nPjpVwwC1+Z6sMcv1npVElxSFhN6aMXe 8Oo+eTyirimlTm/fApz76Fag/Y9iqP5seQTTjVAWZdAMeCEgOrlMQskwuR8MSX5SkNfD zl/yL2pL/GZC1wmA1dNqXF+1zFv4mwC82E4bQVFeEyhMa5Qunwj84aua1b/x/JVjmfY3 PxA7H547xwYCTgPJtMNA9eCLsAK1TRS84P4evilrSdqiRXw8qsoUK+syTewRE5B2E3Il mcxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775816145; x=1776420945; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xnUoPeyCpQ8Rchdbsf90x2AVJoXX8svgOzQ8+c1SLPk=; b=jHqtC1y/TymIBhajGs00++whhgbtAgkyZoLhqXokY1+GW8TDAeMgchRIXUR7gjGIKy iw9cjIFgx6XCrQ1TJblXndIfJYB3ZkHJJV7ZYCKdKNC7RwlcnLsrxnta1f1/mS48aHQH MkhpXo//8nhdgJyV3m2nmhDsdJqmatfrjqXLbDo1C5zIftyiBUigOTQzYAnWcOszqYAE GyqmtNpeYFdI7pCe84Jw7QBT4GNaz5pXJuuWu8DYt/qMC9L9KJslP2kurvfCk+opSWxV TfzTTTvHARzYdet+r1rquIrgMJNeTZRY6b2mKBj+swdRP1pzl8CkkrUw4hmoaYxRr7Wa /2UQ== X-Forwarded-Encrypted: i=1; AJvYcCWn2qovHrm74bX7dwbsyNY9gNz4C67Nrk5PZCQR24p2Qq4JMycRTPRZWEi6RDBeCF5EqhxamrMISBuJ4ys=@vger.kernel.org X-Gm-Message-State: AOJu0YzOdJgBL32P4NxusU3hB+7nuwDYdK4PYM3c9ul4MJqSqKGWs2bF N/v9Utr87T+pBw77dDpWZ8dETElG6WQUm4mJMWhSPsXgU4ozktaDfJbc3L2Um5NlQwBIrW0km4z uidgA3Tt3lG1w7hODSURymo7H7wraTthryt7xWq6euFmtwRMeZhIHLcv+olaqC9rm3R4= X-Gm-Gg: AeBDieuRCH3Irx/AII8y5IdvaynYgIdPEmQNWpcI3qVKrG95UPj1F/n/IZWwLjSnjKD cEyoqpzkOFzupuRdnKOi724x9GoHGL6lNWiO6Ak7/1Hlq21OCCPX5wfpvum7fA51+9yGzrcAREC clZlMWhw/stOS7jXfAIdW4PT35PrUr2QilTpx9TKUDlXQkOJK3mwWTr3BzeHfdT3ArqnAqbJFPn aTuOiuHggrmCKTwnoxMJIumT1tCufKYnnkc88HvwRFb62Pm5U3KiefGJe6j9Cd/uelEXT/K5PA6 c3QVx5IOWssKxUKz9hLmjaNPXmhqJrWXt+pozBotDSminMIxEGn7QSfWR/DZAwYnNFw2eH1C9qt eDODOB2PplcIYSk0VIBvj21QO8/tAZ7L364GLRM6esa+wHFJ0kGMVBrPLN+Fa1S4lY2kJfYR77P s9/gs= X-Received: by 2002:ad4:5d64:0:b0:89a:564f:bbab with SMTP id 6a1803df08f44-8ac8746608amr21609546d6.3.1775816145151; Fri, 10 Apr 2026 03:15:45 -0700 (PDT) X-Received: by 2002:ad4:5d64:0:b0:89a:564f:bbab with SMTP id 6a1803df08f44-8ac8746608amr21609116d6.3.1775816144641; Fri, 10 Apr 2026 03:15:44 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7f188fsm66430466b.59.2026.04.10.03.15.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 03:15:43 -0700 (PDT) Message-ID: <69fbeffe-1a8a-441e-a4c2-a1fcd3d41421@oss.qualcomm.com> Date: Fri, 10 Apr 2026 12:15:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] iio: adc: qcom-spmi-adc5-gen3: Fix off by one in adc5_gen3_get_fw_channel_data() To: Dan Carpenter , Jishnu Prakash Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: h-P2Wf5eobs2P_0Im9Ut8rwQwHBMWjUE X-Proofpoint-GUID: h-P2Wf5eobs2P_0Im9Ut8rwQwHBMWjUE X-Authority-Analysis: v=2.4 cv=Ko59H2WN c=1 sm=1 tr=0 ts=69d8cdd1 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=0Kc_pid0jmsIozq9se4A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA5NSBTYWx0ZWRfX81/CqGpJmvFe W1eP/EK9dV9mWYMzRSogXO58HZkkaiy/5yFzO9fqmgGYYc17lW9e9y9VwfkXisOlB+vlSqrrl09 2xbphm+NUvKr+yv3caY88uy0GGtjeSQvfusIwplI6sf4AouA0l+TX7/L4HgZ1OsDZ0dDNA/sILs uZTgy7AIY17/AeS6opw5JGggWppF9swHVO6Wb/gmFR66hD5y5wNoupHlcOm+tk7FPc71oHnSng9 D4HdxUyQWp4OoIR+BVNAKr3eRiSwT9omMNW+X4SyojlKfy9Xn2MPCh9OH1LOyjFzAKWNeYbCqhu wjH+tzO6dhrifjDuh/6xt2RLrPZYacOMqbHvhs3m0b78YHLOXUrbFyt0oPo3kCm7D56r0wEUgLq hJdTMPlVFFZCO0B5rvHulA6mFtVM9D7SnAN6lOos7xQT0RZb4iQzhGYZBDzvCNYWhfk75Y+ymmd pVGbZ6himXCMgD/vWoA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100095 On 4/10/26 12:12 PM, Dan Carpenter wrote: > The > in "if (chan > ADC5_MAX_CHANNEL)" should be >= to prevent an out > of bound read of the adc->data->adc_chans[] array. > > Fixes: baff45179e90 ("iio: adc: Add support for QCOM PMIC5 Gen3 ADC") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Konrad Dybcio Konrad