From: Andrew Lunn <andrew@lunn.ch>
To: Janis Edvarts Lacis <janislacis06@gmail.com>
Cc: netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, wellslutw@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: sunplus: check budget before calling napi_complete_done()
Date: Tue, 17 Nov 2026 02:37:54 +0100 [thread overview]
Message-ID: <69fdc047-6cf4-4811-9161-8edfc5bcf355@lunn.ch> (raw)
In-Reply-To: <vj5f2zj4fpqp7qaztfp3e5elec44pih3pjqsnkmyhv4js3vxid@naaggpvburqc>
> > This note is in the commit body rather than below the --- line, so it
> > would end up in git history.
>
> Shouldn't it? Documentation/process/maintainer-netdev.rst, under “Bug
> fixes”, requires describing how the fix was tested. I included the lack of
> hardware
> testing in the commit message to make it explicit that it has not been
> tested on hardware.
It is unclear if this is a bug fix.
It is unlikely to reach the criteria for stable:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
So i don't think it is a bug fix as such.
Since these emails are kept forever, anybody who wants to know will be
able to find these emails and know it is untested. So i don't think it
needs to be in the actual commit message.
Andrew
prev parent reply other threads:[~2026-11-17 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 22:27 Janis Edvarts Lacis
2026-11-15 15:50 ` Andrew Lunn
2026-11-16 21:53 ` Janis Edvarts Lacis
2026-11-16 22:19 ` Andrew Lunn
2026-11-15 20:06 ` netdev-bot+sinfo
2026-11-16 2:22 ` netdev-bot+sashiko
2026-11-16 21:43 ` Janis Edvarts Lacis
2026-11-17 1:37 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69fdc047-6cf4-4811-9161-8edfc5bcf355@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=janislacis06@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®