From: Marcel Holtmann <marcel@holtmann.org>
To: Juerg Haefliger <juergh@protonmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
BlueZ <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
Date: Wed, 4 May 2022 14:35:07 +0200 [thread overview]
Message-ID: <6A323366-2AB3-443E-A605-C18EA7A2E161@holtmann.org> (raw)
In-Reply-To: <20220504074606.15505-1-juergh@protonmail.com>
Hi Juerg,
> The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE
> macros to povide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> ---
> RESEND:
> Resend from protonmail email account to please the test bot.
> ---
> drivers/bluetooth/ath3k.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index 88262d3a9392..56e9a64177ae 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver");
> MODULE_VERSION(VERSION);
> MODULE_LICENSE("GPL");
> MODULE_FIRMWARE(ATH3K_FIRMWARE);
> +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
I am still not convinced by the glob file matching. How would that actually work?
Regards
Marcel
next prev parent reply other threads:[~2022-05-04 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 7:46 Juerg Haefliger
2022-05-04 12:35 ` Marcel Holtmann [this message]
2022-05-05 6:07 ` Juerg Haefliger
2022-06-09 8:56 ` Juerg Haefliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A323366-2AB3-443E-A605-C18EA7A2E161@holtmann.org \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=juergh@protonmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®