From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752826AbcBPClr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 21:41:47 -0500
Received: from mga09.intel.com ([134.134.136.24]:10313 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752503AbcBPClq convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 21:41:46 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,453,1449561600"; 
   d="scan'208";a="913055294"
From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: Shalin Mehta <shalinmehta85@gmail.com>,
        "Dilger, Andreas" <andreas.dilger@intel.com>,
        "<kernel-janitors@lists.osdl.org>" <kernel-janitors@lists.osdl.org>,
        "<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
        "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
        "<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: Fixed the parenthesis
Thread-Topic: [PATCH] staging: lustre: Fixed the parenthesis
Thread-Index: AQHRaGGxXJFg/KDi4kirRf4sC9JQTp8ufHyA
Date: Tue, 16 Feb 2016 02:41:43 +0000
Message-ID: <6A47AD82-6A8F-44E1-9CB4-C10CF9F9D72E@intel.com>
References: <1455507422-13568-1-git-send-email-shalinmehta85@gmail.com>
 <20160216022812.GA25122@kroah.com>
In-Reply-To: <20160216022812.GA25122@kroah.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.252.131.50]
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <34C40721512DB84AAB892842AFFA1FE7@intel.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).