From: Chaosheng Qu <quchaosheng000406@163.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Eduard Bostina <egbostina@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: ti,tpd12s015: Convert to DT schema
Date: Wed, 30 Sep 2026 10:24:20 +0800 (CST) [thread overview]
Message-ID: <6ABC72D3.0795AD.00008@m16.mail.163.com> (raw)
In-Reply-To: <20260929121235.GF171869@killaraus.ideasonboard.com>
Hi Laurent,
Thank you for taking the time. Two of the three points came from the v1
posting, one of them is a real miss on my side, and there is a fourth
thing I should have found before posting at all -- I get to that below.
The message you replied to is the 09-15 posting. v3 went out on 09-16:
<20260916123210.107841-1-quchaosheng000406@163.com>
and it rewrote the commit message to give the rationale you are missing:
why "ti,tpd12s016" can only be a fallback of "ti,tpd12s015" (the driver
matches on "ti,tpd12s015" alone, so a board using the 016 has to list
both), and why gpios has to take three to five entries. The v2 version
of that description had capped gpios at three, which broke dtbs_check for
omap5-igep0050.dts -- that board passes the three control/HPD lines plus
the DDC SCL and SDA lines. Rob Herring gave v3 his Reviewed-by on 09-24.
The Assisted-by tag is a fair hit, and it applies to v3 as well: v3 does
not carry one either. That is my oversight and I will add it.
Your third point also stands for v3. The conversion and the gpios
semantics change are still one patch. Splitting them is right.
Now the part I should have caught myself. This conversion is not new
work. Eduard Bostina posted the same conversion on 2026-07-30:
<20260730092245.52034-1-egbostina@gmail.com>
That series makes the same two binding changes -- the "ti,tpd12s016"
fallback compatible and gpios up to five entries -- and its 2/2 renames
the same tpd12s015 endpoint nodes that mine does. Rob reviewed it on
08-03. It did not land: there is no ti,tpd12s015.yaml in mainline, v6.18,
v6.17 or linux-next, and the .txt is still in all of them. I did not find
it before posting mine, and I have cc'd Eduard here.
I would rather ask than add a fourth revision to the pile. Which would
you prefer:
- a v4 of mine, split into a pure conversion plus a separate semantics
patch, or
- for me to drop mine and leave this to Eduard's series?
Either way I will not repost the current form. If there is a reason the
Bostina series stalled that I should not repeat, I would be glad to hear
it.
Thanks,
Chaosheng Qu
prev parent reply other threads:[~2026-09-30 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 12:03 Quchaosheng
2026-09-29 12:12 ` Laurent Pinchart
2026-09-30 2:24 ` Chaosheng Qu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ABC72D3.0795AD.00008@m16.mail.163.com \
--to=quchaosheng000406@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=egbostina@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®