From: Segher Boessenkool <segher@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Please pull from 'for_paulus' branch of powerpc
Date: Fri, 5 May 2006 00:09:59 +0200 [thread overview]
Message-ID: <6B4D81B3-ECB5-4492-B3EE-16EAAEBF1405@kernel.crashing.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0605041622180.3700-100000@gate.crashing.org>
Hi Kumar,
> +static int ppc_panic_event(struct notifier_block *this,
> + unsigned long event, void *ptr)
> +{
> + ppc_md.panic((char *)ptr); /* May not return */
> + return NOTIFY_DONE;
> +}
Lose the redundant pointer cast while you're there please?
> void __init setup_arch(char **cmdline_p)
> {
> extern void do_init_bootmem(void);
> + extern void setup_panic(void);
Can those two go into a header file please?
Segher
next prev parent reply other threads:[~2006-05-04 22:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 21:28 Kumar Gala
2006-05-04 22:09 ` Segher Boessenkool [this message]
2006-05-04 22:10 ` Kumar Gala
2006-05-04 22:36 ` Segher Boessenkool
2006-05-04 22:49 ` Paul Mackerras
2006-05-05 4:59 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2006-06-29 6:13 Zhang Wei-r63237
2006-06-29 3:33 Zhang Wei-r63237
2006-06-29 5:08 ` Kumar Gala
2006-06-29 9:10 ` Benjamin Herrenschmidt
2006-06-28 6:26 Zhang Wei-r63237
2006-06-28 13:19 ` Kumar Gala
2006-06-28 6:01 Kumar Gala
2006-06-28 22:44 ` Jon Loeliger
2006-04-04 21:14 Kumar Gala
2006-04-05 0:28 ` Stephen Rothwell
2006-04-05 1:23 ` Kumar Gala
2006-04-05 3:05 ` Stephen Rothwell
2006-04-05 4:33 ` Kumar Gala
2006-03-31 5:43 Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6B4D81B3-ECB5-4492-B3EE-16EAAEBF1405@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®