From: Thorsten Blum <thorsten.blum@linux.dev>
To: Justin Stitt <justinstitt@google.com>
Cc: Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-hardening@vger.kernel.org, kasan-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kcsan: test: Replace deprecated strcpy() with strscpy()
Date: Mon, 18 Aug 2025 21:32:01 +0200 [thread overview]
Message-ID: <6BC1BD59-839C-4A3B-AE91-8CE963C891AA@linux.dev> (raw)
In-Reply-To: <hqvjfoaw5ooucqp3mwswrjxletq6vdzztwvlaxvxf5a6bivdzf@7fcytrsqhz4y>
On 18. Aug 2025, at 20:26, Justin Stitt wrote:
> Looks good.
>
> Here's my checklist:
> 1) strcpy() and strscpy() have differing return values, but we aren't using
> it.
> 2) strscpy() can fail with -E2BIG if source is too big, but it isn't in
> this case.
> 3) two-arg version of strscpy() is OK to use here as the source has a known
> size at compile time.
>
> Reviewed-by: Justin Stitt <justinstitt@google.com>
Thanks for your thorough review.
Thorsten
next prev parent reply other threads:[~2025-08-18 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 21:37 Thorsten Blum
2025-08-18 18:26 ` Justin Stitt
2025-08-18 19:32 ` Thorsten Blum [this message]
2025-08-19 19:00 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6BC1BD59-839C-4A3B-AE91-8CE963C891AA@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=justinstitt@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®