From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012061.outbound.protection.outlook.com [52.101.48.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD9F342B328 for ; Tue, 7 Jul 2026 16:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.61 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440161; cv=fail; b=YlEQufLjtDLHOEr2YaQVGlSXS07lldaEik9VMER26JwFoTNiYf0riYKfk8eqnVEhzHB+hW06MzukxdGlUFxzkYfSw7InBDOVU/fbIZTbYiAzlggHW98Dit+kH2DEFxOIIO7Km3MoiOwD6klXKNnnOtMbatNzfTPHkqiraQ3Wl84= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440161; c=relaxed/simple; bh=/4sImC/ytVTWzR0PD/BjC8mcr4VOD/pxLBNKTa+H4Y8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=RLGXG7XTRkWjkXpQtNyMCsbuUey6On1Oa2hKZe4giviqsGrQJ/rR38NiJ7qmPdnuXHdbzTrwWec4Rwjn1yLkR6gYegy7DHoVWF2/uggdEe8Hm31CmtZmvXq2GN9Yd2bJTnidPy+HVF0z76dzWrnES5ho5SfZ+eJgBc1kThO5i6w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=J0xq6xmB; arc=fail smtp.client-ip=52.101.48.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="J0xq6xmB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JxqthDI+yLQYgZFKldZyxGgjTPydQTNamWLokVxnsgA28gC2PivMZZsQfdFTOxk0ggClD5vt6wwmiGYP2vQ2glYplxZSdcf2BmdPHrcS82rQQ4eImGXV735Xug9bdkZQB7bRh3DeBrgWNfi+R8gEPUHlIKiCfAMLqxYr6CMqzrWkCBeOTVzYG7XWMAg/X+lP8A9NgLNd6BVQBvqpN+u2uystVbkesSVxx3Ggc5wJcHFscgiTqB4s1DeyWhSwR0oL6r6FKnTylzcL8cVEi8oqocIbKJ7B8ZlyzZLeM/Hv52m2pfsUsr+NfQyFpzNFX5jvESwXpz05XarfYpXb6utHSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H7SvUOWE0X1q3Nn2NaZQzXLwCZQsOZL7XiTak9KyNpg=; b=Ynh3LQ8/MeycEn4tAPpI+qCSMAVQQiED15HauEGxcxsWP2gHi7G3RCQFLkggS2QUnR/Wfn/lUKe+Zz0ecCSvp67j9GzJz3UJKgr5yF+44Mv94mi7RQzZyfopVb4FwAanMHBAPHBCVzpbnb20aIlU93YJFQHAcjYEAlQnGY46rHWyrRU5yRzGHpwccVIHJxz9kFx5GLwkjq1rI7oUaGKDGpneNxRUZzMFOiuoU0tW5V4iLFRVju/7YRJKAT6b2IcYYyU8usgHjVHCskmT6ytIdo7OkiWtuT2cxok5oRFe5mwMvF4t0Gwp/ICk04ZtlJEZbry5X98RVVpFzAzq6R8PYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7SvUOWE0X1q3Nn2NaZQzXLwCZQsOZL7XiTak9KyNpg=; b=J0xq6xmBhp2V/E7YW1B8dkwAxdjlNh/2/fguYDbrrMgWJcBn9N/AYyOjkBNTWhewBsRUob/8XDAOQRgvnPQJRoKuTEaVbs3+LQUTkfSrndBa9ZUxejHoikcIb248yqSjPJiR6lTDFgNp4V3l+uOcL/CUJnPN4mk3CcsxdS9gYXbsZbEbVUowyyOY7Clsi2OM5QUxuNVQMf03h7NsSc8iQDRgYXuGgFhmLB62QPVwF73F205hBGty6co5DaesdlVY1JS7dp+z1tozpcrhE8C8M7whJHEe6qsojYC9JRS04lvRrZDnpeU0TnsbpcQ4BaoILSRNMO44Ku8H9znP5mWVZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH8PR12MB7278.namprd12.prod.outlook.com (2603:10b6:510:222::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Tue, 7 Jul 2026 16:02:33 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0181.009; Tue, 7 Jul 2026 16:02:33 +0000 From: Zi Yan To: "Vlastimil Babka (SUSE)" Cc: Zhen Ni , , , , , , , Subject: Re: [PATCH v12 1/4] mm/page_owner: add print_mode filter Date: Tue, 07 Jul 2026 12:02:32 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <6C99BC03-CF3F-4629-BA70-E5FCFF359B8E@nvidia.com> In-Reply-To: <117481D7-EF95-4123-BAD9-F9D24D1C94F2@nvidia.com> References: <20260707115411.1714314-1-zhen.ni@easystack.cn> <20260707115411.1714314-2-zhen.ni@easystack.cn> <670931b2-7d9d-4e37-a410-a2e7d85cfdd4@kernel.org> <117481D7-EF95-4123-BAD9-F9D24D1C94F2@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: MN2PR11CA0011.namprd11.prod.outlook.com (2603:10b6:208:23b::16) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH8PR12MB7278:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c28e5bf-43eb-4750-5e38-08dedc4127ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|3023799007|6133799003|11063799006|4143699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: C0mrAV9vDKdsFm0LP1Y5mxcg2fewUkjbdULsiDo0EUg7C0W945SMN5I+TqEw0lr2ulJlBnxoJRQXyGcNfdITF3xd71i4x8Ua5NM/g5qV9cpmpFShEuHKKhv/bTtBRA1ZScAXmEuHhat6L96zg6V6PR4WVktN4ADVAYlgsTvrxfBCrDxhZPk4mzFy3Nt/d4rrxcXdUnDguadVY3pfGqo9DRdkZ7lITQQC6UwTr0CoIVedDNU/2kmG2vLlgapAC5dXeLS9KTxZ6Dos8roovJqrd3/9ztgaWk76FAwWZfd4fYdA/w3UwDlVJKmBsAGPk1l3SSz/n8dKjU1YBZYfDzOpJOFCtgOdyPCSnEy29zML3tH+WcoM7YrfqWd5bMhLyy+tRlDDjqHLQGRs423o5TlfcD4YX3g5hOHQmXPTrx00WOauuYZBXUpIjVvNMizbXibxHG1rSa7NubI/8aXUHzrKyEReT6WpSNpE+R03UZgKxXcwEkp1Ma+NQb8HDhWUlDMErQqw30gsbtMHjh1VUmj0g6sL5YDfWSZ3BfL2f0SdpL+n0oNkg09P2Q9N5S3a+kIuftBhnEWxhVofQQRuAcoIKXTTSrBM0Dw3+6WEuq0rf04hAb96VLsinzOIKCA4CM/1F3vw6lh1CStvglHRzfRAXh3lcHtL8sVfmuFS2Znczfo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(3023799007)(6133799003)(11063799006)(4143699003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S5Aan12jSlCuJM8SftbDNV9DxKcn/VUAjWQrdtfnpHH1KqWQ7VMjClD/W5U3?= =?us-ascii?Q?ITNSPLxaXUnU+GktLe/SUTjCSclWtRwSyHG0gGao2D/e45GN+h5JnS5lBvfT?= =?us-ascii?Q?PgunmJ6EI3QO8SYpt0RCVeVH9Wd73Kk9AvndxRJ+pKT5OoTKk1jeCrAgftDl?= =?us-ascii?Q?/kAa3H5At55D9ij7TlzMt3J6zrCVsq7Z/d+kHyT9Q4J4sf6zs/dUaY8yEICw?= =?us-ascii?Q?q78/9JW9L775sZLs5IO6SVRals9yF7PfDeY38JQqW6vkV+TRyfwTtniTCPyV?= =?us-ascii?Q?A6ljXdHKkUfjBqvGVt0LQcaN2wl7QIKr9RPrdr//DLPqAM7+A4l0eSLFVyyQ?= =?us-ascii?Q?Vu+wuH1FsfS6uUQdeH162OxPYdoCebyijMPhHBuGomPE6MNxJNC5Pz6c+L4B?= =?us-ascii?Q?gWT1Tv+SJ4BSsebvasG/iYtaXcpHwa23VamOfX5gkj2Dkefn3g9o+f+zCErk?= =?us-ascii?Q?8mj15LKH4ToogdomVmVS125iwuQVh+xjKFMYC/cOZvPCp6mL+S2WbITz3lO4?= =?us-ascii?Q?rfrEr3YM47kqNVaRlwLM8NMKo8S8oO5E/OeCsKT5E5uQTWM/PVWZzqXDGUbm?= =?us-ascii?Q?DrtxNkkZmr4wdKm40lm25wFSPvAJ6RP0ISYVZIjfu220WsbsOEbP3SnH1JSc?= =?us-ascii?Q?8yXpvz5EeN9AKA1zANVQxY9hMf5Ae2xiBlmtg8GFRMRgo/XqD4Qg+W8mbXhl?= =?us-ascii?Q?WGDJh8xAmw9HhifZ69bVKsdsKpUP1a5xdFUiDPEcmUeSE3X2Lb6SKcDK3+dG?= =?us-ascii?Q?qXj43AZtDmGWvTcT2cSOfi89xcEzKPiPoZwduS0ViZgTlwJWlB9+h/Gk83E2?= =?us-ascii?Q?Tpm1/p3IIPfiqAjHNhw5fjskPNh14XZuDkYgmQoxLUWjv62HHDW1zn6aR/MO?= =?us-ascii?Q?815zVxSgFtC/Uyu5UhxI/qLcV8aIqTIMrxWwytPoYLrzt3hGPao7C9A6IMWQ?= =?us-ascii?Q?EKp0VSumwefjD/owpgOZdifhAdjBkCLPasOQ8YMmEDGgFbeXNGelfXSTo3pT?= =?us-ascii?Q?gydlXseRyHcP+A5qWWbkhXrt88cLQaxqjuRKtAWy/F5D9FpewXXWNQMbfFv+?= =?us-ascii?Q?+iVcHvcpauiaRVDRfls04BVVQKVIlJi+Ov7qpHE2FyEHcQKwIne2nvwUnIXy?= =?us-ascii?Q?dqDK1UvbjH14FTBQWF/jMS2nSVp1q8bEYRuvWuOLVVcQFU31KdhESHX+KRoG?= =?us-ascii?Q?vAeASv261znvXhusR//RbBOg1kHPSV+ik1fysIQd+bzBsXR7Ob4+bMHlXyst?= =?us-ascii?Q?RBKmjbmJJyH/nRAyICCDcDLTOIy1++ieHyR4F/7uvdQ0QH7XU87tDcq8qLh4?= =?us-ascii?Q?UaMpLuy0C0xNfb1WELG7UuZnXLP4b/lO3qHJwoITwIy3M17/PBnnftzYN0Zc?= =?us-ascii?Q?ADv3r9vG4dZzcViJEVv1fcnQYAvz2Q+iOQXyAck4LdBEVEvj2QbbFO7v215D?= =?us-ascii?Q?uz+66PTgK9GA1RfoCd6paG7LuF+YPonKtfbIZ0gGX1wLZBQX6EocflWsr3Ki?= =?us-ascii?Q?TZaN9sPpEMLdqJVcKaDeeFZVTmwVjK0w8YLoLd1h7if5Odiz7X/8bPKQamcj?= =?us-ascii?Q?QQYK4mZDaOl9ePEdlxzRxheUtLmYiEGp+eWXKdc6JF6WvR6+i7IUbfEqnR9i?= =?us-ascii?Q?n/Xv4FBHLlR15VEAw74nn0aLaW5Q3NmHAsQDhjWSl1SCXQYqkQ988UJ+I2P5?= =?us-ascii?Q?5sXJEhvUghcQ0ssqoMonTPC6WPRfBQDvtGQlgnk0b6rn+u2Z?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c28e5bf-43eb-4750-5e38-08dedc4127ae X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 16:02:33.1628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fB7xTnuv0pTN/vqjKSHrmiLzjHh5ebuO6zbMMwS2h7L+yz7FJCs5RBLr5jRdhlM0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7278 On 7 Jul 2026, at 11:31, Zi Yan wrote: > On 7 Jul 2026, at 11:27, Vlastimil Babka (SUSE) wrote: > >> On 7/7/26 13:54, Zhen Ni wrote: >>> Add a print_mode filter to page_owner that allows users to choose between >>> printing stack traces, stack handles, or both, providing flexibility for >>> different debugging and analysis scenarios. >>> >>> The filter provides three modes via page_owner: >>> - Writing "mode=stack" prints stack traces for each page (default) >>> - Writing "mode=handle" prints only the handle number >>> - Writing "mode=stack_handle" prints both stack traces and handles >>> >>> The default stack mode maintains backward compatibility with existing >>> usage, displaying complete stack traces for each page allocation. >>> >>> The handle mode dramatically reduces log size and improves performance by >>> showing only the handle number instead of the full stack trace. Testing >>> shows handle mode reduces output size by ~66% (84MB vs 244MB) and >>> improves read performance by ~4.4x compared to full stack output. The >>> mapping from handles to actual stack traces can be obtained via the >>> show_stacks_handles interface. >>> >>> The stack_handle mode prints both stack traces and handles, making it >>> easier to identify pages with the same allocation pattern by comparing >>> handle numbers instead of comparing large stack traces. >>> >>> Example usage: >>> # Using the page_owner_filter tool (recommended) >>> ./page_owner_filter -m stack # Print only stack traces (default) >>> ./page_owner_filter -m handle # Print only handles >>> ./page_owner_filter -m stack_handle # Print both stack and handles >>> >>> Sample output (handle mode): >>> Page allocated via order 0, migratetype Unmovable, gfp_mask 0x1100ca, >>> pid 1, tgid 1 (systemd), ts 123456789 ns >>> PFN 0x1000 type Unmovable Block 1 type Unmovable >>> Flags 0x3fffe800000084(referenced|lru|active|private|node=0|zone=1) >>> handle: 17432583 >>> ... >>> >>> This implementation uses per-file-descriptor filter state stored in >>> file->private_data, allowing each opener to have independent filter >>> configuration. >>> >>> Signed-off-by: Zhen Ni >>> Tested-by: Zi Yan >> >> I think in general Tested-by" can't carry from previous version due to >> (functional) changes. Andrew can remove it locally, or Zi can re-test :) > > Let me do a quick retest. :) > Everything works as expected as I just tested the code using the supplied userspace tool. I also discovered a small typo in Patch 2. ;) 1. I used the tool manual with NUMA filter + handle|stack|stack_handle. 2. I also used the script from the cover letter and checked the output. Tested-by: Zi Yan Best Regards, Yan, Zi