From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 316D918A922 for ; Wed, 18 Dec 2024 10:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734516515; cv=none; b=ROfBk86LpXdLups5wh9hNcRTykEIb4Dqh86FxmnApcJ5K7irVBAGnExn9xE9NN9yAJKieT3B/lCawFa8T15nWBMM0CMvqfkymIoTLt9YYou024mf8DUAlsnaOsaIQAs4b5won4ekxt43ivur6Wf1Pxd/MjqmGUjvXPu+vg34IX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734516515; c=relaxed/simple; bh=McJFBGRi73qOskvj2dJzcmMaMHZrowp+ckL4fxI8kEE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DIuANFeVFBQ9SgI/MRGj0l8OakTpCQg2eC0QRFfYv2alBwr2emIoqXmdoiViaUbdVHOqY07Flhb2lLsATjvGldv/JVYoEiYLZVlZv9Rvymo+8Pg5oWeAVUXYJt+RkGqGdooLfvzrgW7lHVMPljvi4zRxoaCLjSEN2jvSK7IcZo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b3gSTQZu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b3gSTQZu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734516513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=28LtfQqtpdHfDU07S6WF6bvRxmpMXf24CtX5DCj2iy0=; b=b3gSTQZux+RKapAjzcgO2LUmkrNoJHKTU6ckJJqY6gS4C0b6U6UoZ5DvGqFgZCGYv6gEmI Bp0o/Bv7sU+7mgUR8y3xbzeR5zrDMk1Zqv6t4aiGGP7UjHE/ECOFoPifw0VXXK71djkEfw vUv5GRA7wVNiCfl2Dwk2b2jectB4QWo= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-GC8_HXThMqSS_tk07EWJVw-1; Wed, 18 Dec 2024 05:08:31 -0500 X-MC-Unique: GC8_HXThMqSS_tk07EWJVw-1 X-Mimecast-MFC-AGG-ID: GC8_HXThMqSS_tk07EWJVw Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aa6732a1af5so568671266b.3 for ; Wed, 18 Dec 2024 02:08:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734516510; x=1735121310; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=28LtfQqtpdHfDU07S6WF6bvRxmpMXf24CtX5DCj2iy0=; b=k1ioizFpj6kQWbhxMbTcXhhPxp4iuJQW7Y9WHy8zb9NBgmV+jmLw5N4m07R8bW3o15 aze4P1fvuybwvUz2mqEFG7Otq5MDtwLFPie6SLhP/ytpXIbX8ITGRjOADtq7y5SWK3Fl Uw9KLEEvzQ22gvFXLZ71ZnOcHN9FRVuvMRMUmpqz7oUkneMSL3GGulf7yVxyuc3Bct+T sxVLPXAzSWA9h39cqn7juE+Zal8QkfDwUEbrmFKGqsLGfrkc3Gqadomb8egDl3+ji7gG bc5C4fDbgJj1Sy0SQvPD55hmFvxDA6/1p5dcLC6Zn4+LrveF0xAa7jQ+8v9dUD3FU1JX G2qw== X-Forwarded-Encrypted: i=1; AJvYcCXB6M5SCmvUg4NvwaNlCaBJtrCaT8DyzFj9Pm7ule2r1NrYvSkApnE/Hr7T+8NG/0Zv3plwP3D+h+TmEYY=@vger.kernel.org X-Gm-Message-State: AOJu0YyGIk44ifaupT+wb2K3i8tQDKBnvmMg4jENvogReUcFoqC9kVkZ QS/fDcnvRyHoU/LLE1i7P9dXriUxtt5iGejPyv1dkMV4GrjpVT/LsfpRpHVOgfw6CkGhLT1BLQl sJD6YcZ7yEwup1mlhXs9QYLeIUTvYINUA/emPg16h3D3G+PCZoklrvnvPJ+J3bg== X-Gm-Gg: ASbGncsePRlZN2F1m+wlMZktjSdBmD/0OK9cMttfIEpLp3jztu4Ki0DGrJR1GFVDZzl jsgR3kBUcI+iHg5Xq0/10dX8RQV2JXbX1qFKFjeiYn7+ddnQKuUZ5C8/+lb2YKzSCP/0oO2LzCN a8708HyJEA4Lv4k9fW6StZ02SLKV9XukVOdQyv+Qy2JuwVawO+/neQn029Eu9Y4/FEUSNNYSnKA AanWJP13WITgB+JOy5Ji8tXamR+7okbZuAkpI23aYiWCs5iN86jzVxD3yNsJYIBU4TtNwD4qpD7 bQTZkR44qVwXb1GOQGlQiSKsqiQ= X-Received: by 2002:a17:906:ee88:b0:aa6:950c:ae0e with SMTP id a640c23a62f3a-aabf491e146mr184739766b.51.1734516510640; Wed, 18 Dec 2024 02:08:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IElz+KnDnIV4/z/HLgJGjKzAErVWdv9XAf6U6sQ+wwJVIlLKVdwuAxA2tbLvawq9el84pF0yg== X-Received: by 2002:a17:906:ee88:b0:aa6:950c:ae0e with SMTP id a640c23a62f3a-aabf491e146mr184736566b.51.1734516510242; Wed, 18 Dec 2024 02:08:30 -0800 (PST) Received: from [10.39.193.174] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab96067ef1sm534517866b.48.2024.12.18.02.08.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Dec 2024 02:08:29 -0800 (PST) From: Eelco Chaudron To: Adrian Moreno Cc: linux-kselftest@vger.kernel.org, dev@openvswitch.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Simon Horman , Jakub Kicinski , Paolo Abeni , Shuah Khan , "David S. Miller" Subject: Re: [ovs-dev] [PATCH net] selftests: openvswitch: fix tcpdump execution Date: Wed, 18 Dec 2024 11:08:29 +0100 X-Mailer: MailMate (1.14r6065) Message-ID: <6D309AF5-AC5A-4F68-9F86-84E66AC0FB4F@redhat.com> In-Reply-To: <20241217211652.483016-1-amorenoz@redhat.com> References: <20241217211652.483016-1-amorenoz@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 17 Dec 2024, at 22:16, Adrian Moreno wrote: > Fix the way tcpdump is executed by: > - Using the right variable for the namespace. Currently the use of the > empty "ns" makes the command fail. > - Waiting until it starts to capture to ensure the interesting traffic > is caught on slow systems. > - Using line-buffered output to ensure logs are available when the test > is paused with "-p". Otherwise the last chunk of data might only be > written when tcpdump is killed. > > Fixes: 74cc26f416b9 ("selftests: openvswitch: add interface support") > Signed-off-by: Adrian Moreno Thank for fixing this, the change looks good to me. Acked-by: Eelco Chaudron