From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B31EF26E711 for ; Mon, 26 Jan 2026 07:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414114; cv=none; b=UDeuwh4f7UWyCGKCPdiQ6dVk43yTs2g2sej/snZC7DQL2RfsVEnTdEJXSb851Qn1QBD59htrASfiAvM8Wt1vm8Q1I1GyTw1hu8HBwdEZNN3P6LNpRVAWBuHlpQMv8HB9X9J1D6jiWPnkoWQdJDjQ/tGj/Ig9VqTPA5330LlaRWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414114; c=relaxed/simple; bh=dphYUJlR30y2mDw/Tvau+TT2Il9sMUdEYR6xdMT/h9U=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=HMaIsas+938HnyhhJky98eoMfq/clGnAujusJoKH429dTNKyZd7xOe7myuF/CDn1HKcuVIr0OIgdK4ept0OYxB6Fhp/qQpkrYtZ1HVGKRVZTPDdOYyheo9UBxft51waP4TL0FoQH6E4RiTMoPdl9qi0YUUfbxJYI0jdr9k5Pnqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=v/LGZA61; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="v/LGZA61" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769414111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVvTUI8UupyRmOf5K6skusIpJ5Jjph0bv9+GfAz6OEo=; b=v/LGZA61bpBcvimui2KqicjS2uCApwE/YNjYWwXTi2HoYeybEuMufWwv3AUFBVfgTyp6KQ n//6V0OtWfqiBJNtLsn4sRtshNVr8WIg8uCX53UyTkW0sX7RZQkuAFt29fxSrqVjmKx4Sg u87IKESuZqSIIp6CFwAHmRjCIA8pa8Q= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: [PATCH RESEND] stm class: Remove unnecessary local variable in stm_write X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <83v7goano1.fsf@black.igk.intel.com> Date: Mon, 26 Jan 2026 08:55:02 +0100 Cc: Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <6D495929-0881-4B38-BFD1-4C55135C7A7D@linux.dev> References: <20260126004312.210402-2-thorsten.blum@linux.dev> <83v7goano1.fsf@black.igk.intel.com> To: Alexander Shishkin X-Migadu-Flow: FLOW_OUT On 26. Jan 2026, at 07:33, Alexander Shishkin wrote: > Thorsten Blum writes: > >> The local variable 'err' and the corresponding if check in stm_write() >> are unnecessary. Remove them. > > Nice catch! Is this a result of manual code inspection or were any tools > used, an AI agent or a coccinelle script or whatnot? Manual code inspection. I think I stumbled upon it when I was working on https://lore.kernel.org/lkml/20250909102512.694203-2-thorsten.blum@linux.dev/ https://lore.kernel.org/lkml/20250909102512.694203-4-thorsten.blum@linux.dev/ which are also still pending. Could you take a look at all three patches while you're at it? Thanks, Thorsten