From: Shreeya Patel <shreeya.patel23498@gmail.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH v4] Staging: iio: adis16209: Change some macro names
Date: Fri, 09 Mar 2018 00:57:31 +0530 [thread overview]
Message-ID: <6EF6C73A-ED18-4C5F-8368-929258026979@gmail.com> (raw)
In-Reply-To: <20180308191111.GA2041@himanshu-Vostro-3559>
On 9 March 2018 00:41:12 GMT+05:30, Himanshu Jha <himanshujha199640@gmail.com> wrote:
>On Thu, Mar 08, 2018 at 11:46:17PM +0530, Shreeya Patel wrote:
>> Make some of the macro names according to the names
>> given in the datasheet of the adis16209 driver and
>> have slight indentation in field definitions to make
>> them clearly different from the register addresses.
>>
>> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
>> ---
>>
>> Changes in v4
>> -Have slight indentation in field definitions.
>>
>> drivers/staging/iio/accel/adis16209.c | 48
>+++++++++++++++++------------------
>> 1 file changed, 24 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/staging/iio/accel/adis16209.c
>b/drivers/staging/iio/accel/adis16209.c
>> index eb5c878..19636e2 100644
>> --- a/drivers/staging/iio/accel/adis16209.c
>> +++ b/drivers/staging/iio/accel/adis16209.c
>> @@ -68,21 +68,21 @@
>> #define ADIS16209_MSC_CTRL_ACTIVE_HIGH BIT(1)
>> #define ADIS16209_MSC_CTRL_DATA_RDY_DIO2 BIT(0)
>>
>> -#define ADIS16209_STAT_REG 0x3C
>> -#define ADIS16209_STAT_ALARM2 BIT(9)
>> -#define ADIS16209_STAT_ALARM1 BIT(8)
>> -#define ADIS16209_STAT_SELFTEST_FAIL_BIT 5
>> -#define ADIS16209_STAT_SPI_FAIL_BIT 3
>> -#define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2
>> +#define ADIS16209_DIAG_STAT_REG 0x3C
>> +#define ADIS16209_DIAG_STAT_ALARM2 BIT(9)
>> +#define ADIS16209_DIAG_STAT_ALARM1 BIT(8)
>> +#define ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT 5
>> +#define ADIS16209_DIAG_STAT_SPI_FAIL_BIT 3
>> +#define ADIS16209_DIAG_STAT_FLASH_UPT_BIT 2
>
>#define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2
>?
>It represents flash update fail bit!
I think so that I have sent the wrong patch :(
This is totally the reverse of the change that I wanted to have.
Maybe I messed up with this patch.
Jonathan, please avoid this patch.
I'll send the corrected one soon.
Thanks
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-08 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 18:16 Shreeya Patel
2018-03-08 19:11 ` Himanshu Jha
2018-03-08 19:27 ` Shreeya Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6EF6C73A-ED18-4C5F-8368-929258026979@gmail.com \
--to=shreeya.patel23498@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®