From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317AbbIGOD1 (ORCPT ); Mon, 7 Sep 2015 10:03:27 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36478 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbbIGODZ convert rfc822-to-8bit (ORCPT ); Mon, 7 Sep 2015 10:03:25 -0400 Subject: Re: [PATCH V2] arm64: add kc_offset_to_vaddr and kc_vaddr_to_offset macro Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Jungseok Lee In-Reply-To: <1441512250-9667-1-git-send-email-yalin.wang2010@gmail.com> Date: Mon, 7 Sep 2015 23:03:35 +0900 Cc: catalin.marinas@arm.com, will.deacon@arm.com, treding@nvidia.com, zhangwm@marvell.com, mark.rutland@arm.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, ard.biesheuvel@linaro.org, fkan@apm.com, steve.capper@linaro.org, lauraa@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <6F07C7AF-779B-439D-B820-E11816664406@gmail.com> References: <1441512250-9667-1-git-send-email-yalin.wang2010@gmail.com> To: yalin wang X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 6, 2015, at 1:04 PM, yalin wang wrote: Hello Yalin, > This patch add kc_offset_to_vaddr() and kc_vaddr_to_offset(), > the default version doesn't work on arm64, because arm64 kernel address > is below the PAGE_OFFSET, like module address and vmemmap address are > all below PAGE_OFFSET address. > > Signed-off-by: yalin wang > --- > arch/arm64/include/asm/memory.h | 1 + > arch/arm64/include/asm/pgtable.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index f800d45..2d09fe8 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -55,6 +55,7 @@ > #define PCI_IO_START (PCI_IO_END - PCI_IO_SIZE) > #define FIXADDR_TOP (PCI_IO_START - SZ_2M) > #define TASK_SIZE_64 (UL(1) << VA_BITS) > +#define __VIRTUAL_MASK ((1UL << VA_BITS) - 1) According to Catalin's comment, [1], it might need to be rewritten using VA_START in the KASan patches, [2], after this merge window. [1] https://lkml.org/lkml/2015/9/4/529 [2] git://github.com/aryabinin/linux.git kasan/arm64v5 Best Regards Jungseok Lee