From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B6030DD07 for ; Fri, 7 Nov 2025 11:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762516663; cv=none; b=DQuliAIovh1IqH5/aEaqY+TxFDszq1URNzd8ZRFirhfZD01zrt8Jp7F3RO7Yc1F8zQSXXRVy52Z2MpbRFiD6XDnWRc82+aHZ3TJsQTWOYNHicTjwjEboBKoyRakJwU3wXZRnZwVGQbUKEVoy1aSgIvoXobWorRtQR1uqmW+jiQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762516663; c=relaxed/simple; bh=V6i41dL8eu8FQb/kAEXtgcYlRbNtBOZAKd/lJ0lMtnw=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=Pi2CRrBPqKWSeX7Uu0JoLEJsGzkp2yCCqG2gv4zLCBLF587LUA3b37jywjgGciJq4/0Z/AjEMuKsmd4eZGPE69MJxTmXyh8db83mJHYtmHYEOSuKM/QjukiC76Lo1a4ozMyjYyZfy3U6sCIVDdHdljD+npZMs+/6d9xH+94PLW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ee+M2woi; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ee+M2woi" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-ba507fe592dso408292a12.2 for ; Fri, 07 Nov 2025 03:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762516661; x=1763121461; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=monGLLl72k03rW+XBHxv2n4ze7FfAMEbwcdE5Jp88/k=; b=ee+M2woiouXgrySHJuE6/DQeBcQ4FGGGWqltl2spK44D5S7xUcyF642+G2UMP8Zip/ wiQBsSj3B1WinR2KLfl6aDrVNMMbMsBg25UCp7HCc1Sa1Yn4IuCj2ptJgtMAZJtuIXFj FAPSaGjQwnsl7u3KFQnayPfYcUs9xzwVepq0lLLqpOqlgTZN+Np2aopTrkiE4CCAXGNv 2E4IEywS1W4nQ34jGqZBarIe9DR1bMzU4SOnywIKuphaf2+b1puO5SFg8+VFyVy2FY19 GZqiwOhkG1Fp9jztch8ruIJE1brEbH6exnHg1myv52XiuUkmWdxRX6olY9OCa4cJ4LSh 4QrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762516661; x=1763121461; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=monGLLl72k03rW+XBHxv2n4ze7FfAMEbwcdE5Jp88/k=; b=Or1gF4m5XTCG0XmiarGFXEyq7fQYlxdTLkGFItbixwY4wsY3BlpgeHDkMf8e414NdG SMWU5Izb+7OT6M1kwezsFEcmQffimr7sD+K4LxKN1hUqWRxggemVVWG5YWZCo/QZkM58 d2vaGqFSAm3nD3Om348fRGeEKD1sWr8v/YxQkkammqB6TYw7Y6x9bOQBmw94iJoAK59h jjGaMXpyCBkXjcYpHxXYWM7pGKC983U4xzKjmy0QmZxv4BNeL6sS7zK8pGgn2NfUpgCM Xlyv7UZB5Ge29/+S4n6K5ElcaLCcJDisgMU9uCmB6bL74Zh0H3qPftGugzOXNCAFI3CO 7ftw== X-Forwarded-Encrypted: i=1; AJvYcCVB/TWZat0puIxE/MzPPpkQFjHi1fRoi60b8AUy6pu/QyMY+0H//gEDAT3vSxQKfUw9s6vIEofYNaNmkI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+HRLnkntFH3wv9HvFFwU2/VB3rR6h50M2jv9vKdiRyoQ3kzIY gZSRsmOFK0b7wY4UNFeYyi4dGZa/Fy6+yGrsmZhsYaAr5aoAhe1jELMG X-Gm-Gg: ASbGncuOYG24af5D3DXaogChQeuNmrGDsdXHGrhxPagg8S2mIg1D/U/a7zhwJAJjEoB fzw9AqryQ3HebOcvXBOV+4xSPa3F9RD43m/X8R2wEeD/1PiNct1ZeQBGhDiz7nbeiFqhN35hF9T 3qFgYQ9wC+F/QkiZ/xu7BAttUZINlQdadaEughdU5z36kGMEP5XO/cQtGW91S9esHihpmTdJady ZCqrakKerwzi446Ua/tjX6n2P/Fim4jmbifY0W2lf1WySeboMrR6teVpWdLZTgHNKoWP3m6HVXN 1eZVl++h1U2592mzcjf7tzMcEa//3RN0lFmsnMdGa25lKSGQjYbT0MvoKxf82lQzEEWh+wKTP1d HcSay1mFwvK+qsvWUqcLzRKNqg+fI3ZzecRF+iQkeOqlPwXAqbvHG+dpDQuSHjQ+YoPzZRy68MI e0/0WXVPatVQaVtcOK0tcOvzVbx0NEXNKY X-Google-Smtp-Source: AGHT+IG2JNYUVu7xIzD0M5+jz0kLb7Hm7r7y9xBYeK5/FwHh5dDyBrOGwBvYmi7VcMJsmKn3/mqWGw== X-Received: by 2002:a17:903:2284:b0:297:d6c2:d06 with SMTP id d9443c01a7336-297d6c20d85mr8354715ad.20.1762516660819; Fri, 07 Nov 2025 03:57:40 -0800 (PST) Received: from ehlo.thunderbird.net ([150.230.217.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29651c9c2a2sm58337585ad.93.2025.11.07.03.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 03:57:40 -0800 (PST) Date: Fri, 07 Nov 2025 19:36:58 +0800 From: Coia Prant To: Chukun Pan CC: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh@kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v5_3/3=5D_arm64=3A_dts=3A_rockchip=3A?= =?US-ASCII?Q?_Add_devicetree_for_the_9Tripod_X3568_v4?= User-Agent: K-9 Mail for Android In-Reply-To: <20251107110020.226562-1-amadeus@jmu.edu.cn> References: <20251103171702.1518730-4-coiaprant@gmail.com> <20251107110020.226562-1-amadeus@jmu.edu.cn> Message-ID: <6F2972A5-047F-48A5-B409-C3F3E71643AD@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On November 7, 2025 7:00:20 PM GMT+08:00, Chukun Pan wrote: >Hi, > >> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo= =2Edtso >> @@ -0,0 +1,84 @@ >> +// SPDX-License-Identifier: (GPL-2=2E0-or-later OR MIT) >> + >> +// This is a sample reference, due to lack of hardware can not be test= ed, at your own risk > >> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-video-demo= =2Edtso >> @@ -0,0 +1,154 @@ >> +// SPDX-License-Identifier: (GPL-2=2E0-or-later OR MIT) >> + >> +// This is a sample reference, due to lack of hardware can not be test= ed, at your own risk > >Why are these demo DT Overlays needed? Are these optional accessories? >These untested DT Overlays should be removed=2E > >> + vcc3v3_pcie: regulator-vcc3v3-pcie { >> + compatible =3D "regulator-gpio"; > >This should use regulator-fixed=2E > >> + regulator-name =3D "vcc3v3_pcie"; >> + regulator-min-microvolt =3D <100000>; >> + regulator-max-microvolt =3D <3300000>; >> + pinctrl-names =3D "default"; >> + pinctrl-0 =3D <&vcc3v3_pcie_en_pin>; > >Is this the name from the schematic? > >> + pinctrl-names =3D "default"; >> + pinctrl-0 =3D <&gmac0_miim >> + &gmac0_tx_bus2 >> + &gmac0_rx_bus2 >> + &gmac0_rgmii_clk >> + &gmac0_rgmii_bus >> + &gmac0_clkinout>; > >> + pinctrl-names =3D "default"; >> + pinctrl-0 =3D <&gmac1m1_miim >> + &gmac1m1_tx_bus2 >> + &gmac1m1_rx_bus2 >> + &gmac1m1_rgmii_clk >> + &gmac1m1_rgmii_bus >> + &gmac1m1_clkinout>; > >Align Indentation=2E > >> + codec { >> + rockchip,mic-in-differential; >> + }; > >Is it confirmed to be differential signaling? > >> + pmic { >> + pmic_int: pmic_int { >> + rockchip,pins =3D >> + <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>; > >No line break is needed here=2E > >> +/* Required remotectl for IR receiver */ >> +&pwm7 { >> + status =3D "disabled"; >> +}; > >This should be replaced with gpio-ir-receiver=2E > >> +&sdmmc2 { >> + bus-width =3D <4>; >> + disable-wp; > >The disable-wp property does not apply to SDIO cards=2E > >> + sd-uhs-sdr12; >> + sd-uhs-sdr25; >> + sd-uhs-sdr50; >> + sd-uhs-sdr104; > >Just declare the highest supported speed=2E PCIe and MIC picked from OEM source codes=2E PMIC picked from RK3568-EVB=2E Since parts of the OEM source code are not available in mainline, I refer = to other boards (e=2Eg=2E RK3568-EVB or RK3568-ROC-PC), but I don't have a = camera or screen to test, so I mark them as demo=2E Do I need to release a new set of patches? Thanks