From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF465C3A5A9 for ; Wed, 4 Sep 2019 14:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D39662339D for ; Wed, 4 Sep 2019 14:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730701AbfIDOG5 (ORCPT ); Wed, 4 Sep 2019 10:06:57 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:34727 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbfIDOG4 (ORCPT ); Wed, 4 Sep 2019 10:06:56 -0400 Received: from marcel-macbook.fritz.box (p4FEFC197.dip0.t-ipconnect.de [79.239.193.151]) by mail.holtmann.org (Postfix) with ESMTPSA id E3037CEC82; Wed, 4 Sep 2019 16:15:41 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH v1] bluetooth: hci_qca: disable irqs when spinlock is acquired From: Marcel Holtmann In-Reply-To: <1567571656-32403-1-git-send-email-c-hbandi@codeaurora.org> Date: Wed, 4 Sep 2019 16:06:53 +0200 Cc: Johan Hedberg , mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, anubhavg@codeaurora.org Content-Transfer-Encoding: 7bit Message-Id: <6F34A9CD-7C8F-4E5D-9A22-9F05CC2CF9BC@holtmann.org> References: <1567571656-32403-1-git-send-email-c-hbandi@codeaurora.org> To: Harish Bandi X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Harish, > Looks like Deadlock is observed in hci_qca while performing > stress and stability tests. Since same lock is getting > acquired from qca_wq_awake_rx and hci_ibs_tx_idle_timeout > seeing spinlock recursion, irqs should be disable while > acquiring the spinlock always. > > Signed-off-by: Harish Bandi > --- > drivers/bluetooth/hci_qca.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) patch has been applied to bluetooth-stable tree. Regards Marcel