mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Majewski <lukma@denx.de>
Cc: Woojung.Huh@microchip.com, dan.carpenter@linaro.org,
	olteanv@gmail.com, kuba@kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
	o.rempel@pengutronix.de, Tristram.Ha@microchip.com,
	bigeasy@linutronix.de, horms@kernel.org, ricardo@marliere.net,
	casper.casan@gmail.com, linux-kernel@vger.kernel.org,
	UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477
Date: Tue, 18 Jun 2024 16:58:43 +0200	[thread overview]
Message-ID: <6a011bd4-8494-4a6f-9ec4-723ab52c4fbf@lunn.ch> (raw)
In-Reply-To: <20240618164545.14817f7e@wsk>

> For me the:
> 
> NL_SET_ERR_MSG_MOD(extack, "Cannot offload more than two ports (in
> use=0x%x)", dev->hsr_ports);
> 
> is fine - as it informs that no more HSR offloading is possible (and
> allows to SW based RedBox/HSR-SAN operation).

Does user space actually get to see it? I would expect the HSR code
sees the EOPNOTSUPP, does not consider it an fatal error, and return 0
to user space.

If userspace does see it, maybe we should make it clearer it is not an
actually error. 

"Cannot offload more than two ports, using software bridging"

so something similar.

   Andrew

  parent reply	other threads:[~2024-06-18 14:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 13:04 Lukasz Majewski
2024-06-18 13:42 ` Dan Carpenter
2024-06-18 13:49   ` Lukasz Majewski
2024-06-18 13:52   ` Andrew Lunn
2024-06-18 14:06     ` Dan Carpenter
2024-06-18 14:31       ` Woojung.Huh
2024-06-18 14:45         ` Lukasz Majewski
2024-06-18 14:56           ` Woojung.Huh
2024-06-18 14:58           ` Andrew Lunn [this message]
2024-06-18 15:02             ` Lukasz Majewski
2024-06-18 14:31   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a011bd4-8494-4a6f-9ec4-723ab52c4fbf@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=bigeasy@linutronix.de \
    --cc=casper.casan@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukma@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=ricardo@marliere.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®