From: Tetsuhiro Kohada <kohada.t2@gmail.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: kohada.tetsuhiro@dc.mitsubishielectric.co.jp,
mori.takahiro@ab.mitsubishielectric.co.jp,
motai.hirotaka@aj.mitsubishielectric.co.jp,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
'Sungjong Seo' <sj1557.seo@samsung.com>
Subject: Re: [PATCH 2/3] exfat: remove useless check in exfat_move_file()
Date: Wed, 30 Sep 2020 19:41:58 +0900 [thread overview]
Message-ID: <6a0364e6-2192-439d-f874-11402dc8009c@gmail.com> (raw)
In-Reply-To: <000001d6956b$e7bab2e0$b73018a0$@samsung.com>
>>> BTW
>>> Are you busy now?
>> I'm sorry, I'm so busy for my full time work :( Anyway, I'm trying to review serious bug patches or
>> bug reports first.
>> Other patches, such as clean-up or code refactoring, may take some time to review.
>>
>>> I am waiting for your reply about "integrates dir-entry getting and
>>> validation" patch.
>> As I know, your patch is being under review by Namjae.
> I already gave comments and a patch, but you said you can't do it.
> I'm sorry, But I can't accept an incomplete patch. I will directly fix it later.
Of course, I understand that you can't accept a under-discussed patch.
I think you know what I'm trying to do, with previous patches.
Unfortunately, I couldn't implement it properly using the patch you provided.
But I don't think the checksum and name-lenth issues should be left unresolved.
(How do you think?)
So I want you to think with me.
I still feel we haven't discussed this enough.
I still don't understand what you think is the problem with the patch.
Where and what kind of problems do you think the patch has?
- performance?
- wrong behavior?
- readability?
- runtime cost?
- style?
- other?
I think I explained the reason for each implementation.
If it's not enough, I'd like to explain it in more detail.
BR
---
Tetsuhiro Kohada <kohada.t2@gmail.com>
next prev parent reply other threads:[~2020-09-30 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200911044511epcas1p4d62863352e65c534cd6080dd38d54b26@epcas1p4.samsung.com>
2020-09-11 4:45 ` Tetsuhiro Kohada
2020-09-16 2:32 ` Sungjong Seo
2020-09-16 9:30 ` Tetsuhiro Kohada
2020-09-28 7:36 ` Sungjong Seo
2020-09-28 7:49 ` Namjae Jeon
2020-09-30 10:41 ` Tetsuhiro Kohada [this message]
2020-09-30 4:01 ` Tetsuhiro Kohada
2020-09-30 9:08 ` Tetsuhiro Kohada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0364e6-2192-439d-f874-11402dc8009c@gmail.com \
--to=kohada.t2@gmail.com \
--cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mori.takahiro@ab.mitsubishielectric.co.jp \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®