From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E84C7EE2E for ; Tue, 13 Jun 2023 10:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241281AbjFMKG0 (ORCPT ); Tue, 13 Jun 2023 06:06:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239379AbjFMKGH (ORCPT ); Tue, 13 Jun 2023 06:06:07 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BBDBAC; Tue, 13 Jun 2023 03:06:05 -0700 (PDT) Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35D9ZI1N014655; Tue, 13 Jun 2023 12:05:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=pf5/hUeYgSZiBacOfGYZ8c0QDBazie2ZPPuq8uncPHA=; b=SwhEA+vDBiXnI+P932+wLPczEomiKBYTXuPE4RO7F2TN1tSMhCp0c8BGvPXgiTduEuqC pF0y4hXhf1/FHb8JIWlkYjdZ7zN5IfBQDAO7L7KlhOdPbDUKa3/dMRamAMF3jGyqunHc LQMGsCvYVA2lsboqmpbgAGEoqkYxON0DNMaAuLz5Pd5RkPo35d7W1nUMtGJ+DtWvKXM/ GZUHjjJNfH0nM5QNk55xYIy2gmr7tV6dosozWtjaDqLQvKiw4+oPf4w95S1UGJO6C441 XxjV08+158td96Ynpnovcd9/hEaTRFcUZzDaOPKwfumLWdDlz7RhPW3LjWsVBWVyyxKx bg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3r6k1shmpc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 12:05:36 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9C264100045; Tue, 13 Jun 2023 12:05:35 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9143921ADD9; Tue, 13 Jun 2023 12:05:35 +0200 (CEST) Received: from [10.201.21.93] (10.201.21.93) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 13 Jun 2023 12:05:34 +0200 Message-ID: <6a09a674-342e-b197-aee7-980de410e970@foss.st.com> Date: Tue, 13 Jun 2023 12:05:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit Content-Language: en-US To: Arnd Bergmann , Arnaud POULIQUEN , Arnd Bergmann , Bjorn Andersson , Mathieu Poirier , Maxime Coquelin CC: Ben Levinsky , Tanmay Shah , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Dan Carpenter , , , , References: <20230609120546.3937821-1-arnd@kernel.org> <7846c69b-5c2d-16d3-6079-d11a60171a69@foss.st.com> From: Alexandre TORGUE In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.93] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-13_04,2023-06-12_02,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd On 6/12/23 16:17, Arnd Bergmann wrote: > On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote: > >>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE); >>> if (IS_ERR_OR_NULL(ddata->rsc_va)) { >>> - dev_err(dev, "Unable to map memory region: %pa+%zx\n", >>> + dev_err(dev, "Unable to map memory region: %pa+%x\n", >>> &rsc_pa, RSC_TBL_SIZE); >> >> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from >> the arch and to match with the use of RSC_TBL_SIZE? >> >> #define RSC_TBL_SIZE ((size_t)1024) > > I have no objection to that, but I don't see it doing anything good either, > as this is a constant value that will always work. > > Arnd The kernel robot shot me for my STM32MP25 PR due to this issue. Do I have to resend something ? Thanks Alex