From: Sander Vanheule <sander@svanheule.net>
To: Rob Herring <robh@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Walle <mwalle@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v7 1/6] dt-bindings: leds: Binding for RTL8231 scan matrix
Date: Tue, 18 Nov 2025 21:37:21 +0100 [thread overview]
Message-ID: <6a0fafaa35d29ab5efb3871a61b68bed0272d1d6.camel@svanheule.net> (raw)
In-Reply-To: <20251118145805.GA3231100-robh@kernel.org>
Hi Rob,
On Tue, 2025-11-18 at 08:58 -0600, Rob Herring wrote:
> On Mon, Nov 17, 2025 at 10:51:31PM +0100, Sander Vanheule wrote:
> > + allOf:
> > + - $ref: /schemas/leds/common.yaml#
I've moved the $ref property as you mentioned in your first message and added the
unevaluatedProperties: false
> > +examples:
> > + - |
> > + #include <dt-bindings/leds/common.h>
> > + led-controller {
>
> Also, drop the example here. It just duplicates what is in the mfd
> schema and we want 1 complete example, not piecemeal examples.
Done!
Thanks,
Sander
next prev parent reply other threads:[~2025-11-18 20:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 21:51 [PATCH v7 0/6] RTL8231 GPIO expander support Sander Vanheule
2025-11-17 21:51 ` [PATCH v7 1/6] dt-bindings: leds: Binding for RTL8231 scan matrix Sander Vanheule
2025-11-18 14:56 ` Rob Herring
2025-11-18 14:58 ` Rob Herring
2025-11-18 20:37 ` Sander Vanheule [this message]
2025-11-17 21:51 ` [PATCH v7 2/6] dt-bindings: mfd: Binding for RTL8231 Sander Vanheule
2025-11-18 14:59 ` Rob Herring (Arm)
2025-11-18 21:28 ` Rob Herring
2025-11-18 21:57 ` Sander Vanheule
2025-11-19 1:37 ` Rob Herring
2025-11-17 21:51 ` [PATCH v7 3/6] mfd: Add RTL8231 core device Sander Vanheule
2025-11-17 21:51 ` [PATCH v7 4/6] pinctrl: Add RTL8231 pin control and GPIO support Sander Vanheule
2025-11-18 21:19 ` kernel test robot
2025-11-18 22:24 ` Sander Vanheule
2025-11-19 4:19 ` kernel test robot
2025-11-19 18:57 ` Sander Vanheule
2025-11-19 19:41 ` kernel test robot
2025-11-17 21:51 ` [PATCH v7 5/6] leds: Add support for RTL8231 LED scan matrix Sander Vanheule
2025-11-17 21:51 ` [PATCH v7 6/6] MAINTAINERS: Add RTL8231 MFD driver Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0fafaa35d29ab5efb3871a61b68bed0272d1d6.camel@svanheule.net \
--to=sander@svanheule.net \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®