From: David Hildenbrand <david@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtualization@lists.linux.dev
Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function
Date: Mon, 22 Apr 2024 09:47:00 +0200 [thread overview]
Message-ID: <6a182645-1f7f-4b7d-a16a-36e9b1684c58@redhat.com> (raw)
In-Reply-To: <20240422074254.1440457-2-pizhenwei@bytedance.com>
On 22.04.24 09:42, zhenwei pi wrote:
> All the VM events related statistics have dependence on
> 'CONFIG_VM_EVENT_COUNTERS', once any stack variable is required by any
> VM events in future, we would have codes like:
> #ifdef CONFIG_VM_EVENT_COUNTERS
> unsigned long foo;
> #endif
> ...
> #ifdef CONFIG_VM_EVENT_COUNTERS
> foo = events[XXX] + events[YYY];
> update_stat(vb, idx++, VIRTIO_BALLOON_S_XXX, foo);
> #endif
>
> Separate vm events into a single function, also remove
Why not simply use __maybe_unused for that variable?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-22 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 7:42 [PATCH v2 0/4] Improve memory statistics for virtio balloon zhenwei pi
2024-04-22 7:42 ` [PATCH v2 1/4] virtio_balloon: separate vm events into a function zhenwei pi
2024-04-22 7:47 ` David Hildenbrand [this message]
2024-04-22 8:04 ` zhenwei pi
2024-04-22 9:09 ` David Hildenbrand
2024-04-22 8:58 ` Michael S. Tsirkin
2024-04-22 9:11 ` David Hildenbrand
2024-04-22 7:42 ` [PATCH v2 2/4] virtio_balloon: introduce oom-kill invocations zhenwei pi
2024-04-22 7:42 ` [PATCH v2 3/4] virtio_balloon: introduce memory allocation stall counter zhenwei pi
2024-04-22 7:48 ` David Hildenbrand
2024-04-22 7:42 ` [PATCH v2 4/4] virtio_balloon: introduce memory scan/reclaim info zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a182645-1f7f-4b7d-a16a-36e9b1684c58@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®