From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Zheng Bin <zhengbin13@huawei.com>,
lgirdwood@gmail.com, ranjani.sridharan@linux.intel.com,
kai.vehmanen@linux.intel.com, daniel.baluta@nxp.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: gaochao49@huawei.com
Subject: Re: [PATCH -next] ASoC: SOF: amd: add missing platform_device_unregister in acp_pci_rn_probe
Date: Thu, 12 May 2022 08:13:59 -0500 [thread overview]
Message-ID: <6a18ce53-c5c8-5ba9-fe7c-199bd9b4bff6@linux.intel.com> (raw)
In-Reply-To: <20220512013728.4128903-1-zhengbin13@huawei.com>
On 5/11/22 20:37, Zheng Bin wrote:
> acp_pci_rn_probe misses a call platform_device_unregister in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Thanks for the patch, nice catch
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/sof/amd/pci-rn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sof/amd/pci-rn.c b/sound/soc/sof/amd/pci-rn.c
> index b8910bb7f27c..d5d9bcc2c997 100644
> --- a/sound/soc/sof/amd/pci-rn.c
> +++ b/sound/soc/sof/amd/pci-rn.c
> @@ -101,6 +101,7 @@ static int acp_pci_rn_probe(struct pci_dev *pci, const struct pci_device_id *pci
> res = devm_kzalloc(&pci->dev, sizeof(struct resource) * ARRAY_SIZE(renoir_res), GFP_KERNEL);
> if (!res) {
> sof_pci_remove(pci);
> + platform_device_unregister(dmic_dev);
> return -ENOMEM;
> }
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-05-12 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 1:37 Zheng Bin
2022-05-12 13:13 ` Pierre-Louis Bossart [this message]
2022-05-12 16:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a18ce53-c5c8-5ba9-fe7c-199bd9b4bff6@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=gaochao49@huawei.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome