Re: [PATCH net-next v3 05/13] ax88179_178a: Use phylink in get/set_link_ksettings

[Birger Koblitz <mail@birger-koblitz.de>]

On 7/24/26 17:35, Andrew Lunn wrote:
> On Fri, Jul 24, 2026 at 05:06:07PM +0200, Birger Koblitz wrote:
>>
>> Thanks for reviewing the patch-series, Andrew!
>> On 7/24/26 15:38, Andrew Lunn wrote:
>>>> +	if (data->phylink)
>>>
>>> When did this appear? Am i missing a patch somewhere?
>>>
>>
>> In [PATCH net-next v3 02/13] ax88179_178a: Add HW support for AX179A-based chips:+	struct mii_bus *mdio;
>> +	struct phy_device *phydev;
>> +	struct phylink *phylink;
>> +	struct phylink_config phylink_config;
>> But admittedly, this is a rather big patch, which I was unable to break apart
>> due to in particular int ax88179a_bind() referencing most of the rest.
> 
> Ah, sorry. I took a quick look and assumed it was just adding new
> devices.
> 
> Does it make sense to do the conversion without adding new devices?
> That might make the patch smaller.
Well, only the new devices use phylink, so it is not converting the existing
chips. That is why it likely needs to stay together. My handicap is really that I do not
have access to the older chips and from my experiences with writing the phy drivers,
it is absolutely necessary to have access to that for converting them since one
cannot make any assumptions about what is in the registers describing the PHY itself.
My hope is that the older devices can be also converted at a later point and then
remove all the MII stuff entirely.

Birger