From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195BF33C50F for ; Thu, 23 Oct 2025 15:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761233955; cv=none; b=FjaPuJwktYLXwsCUvNi1HWtJApjXCzKKaXZ/vqltvL0sC1pAOWWhTxvntFQTTPpZGVI52oKplyvCilSH000eSWD0siYLWnwFM3vl+/8iSiqwDWXxOD1iZEg+pwD5qyyHDHeRWbukdbUaVd7Bps3ImAh/oQlvpIvWBsJzh6J7eJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761233955; c=relaxed/simple; bh=m48FPyq3hS5hTCmbr8c8h/LHH2v+gSJH4SwXZ6Zsgeg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HbpPjke6AAx/pn8Lwk4NMld6JvUi5z6i6OVRAPj1zKyKHAOLG8ATOfe6JPsP+Fqd9lRIHsCcq5xGTaWdszBYe+6f+KFH+hQ1CmEF1GfECL2BYvSJMdB2D25mopsTcV0rXfVVwzDwTc5ShHoPsDn8NZFrzakKFo6aO74kkJgp+nM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com; spf=pass smtp.mailfrom=6wind.com; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b=Ly6rUpVw; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="Ly6rUpVw" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4271234b49cso137167f8f.3 for ; Thu, 23 Oct 2025 08:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1761233951; x=1761838751; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Pm3nq9zl8vSP9OQckXLMLZC8gBiYgr978W9DuCmvOUw=; b=Ly6rUpVwZqT9BiCA8oyv1CXYwaenFYkmLRQFuMS+pKs/O/AP7s6Ek5vJsiMWR97/kO qsNAxfVbUpd9ZmzrzO8RWoFxbDpxy8qCCtKAmrbjPk/XUlKW4EiOr+CwLr+qyQA+Rz76 32JeP3erTDEOvBVGMGgZFcAZ6RdFoIfoawsvBsfkq/0UqXcsml5vVSCnGKTyHrWVvjZZ qZ/DZoMhClMDvm9GTRptGX9wuIfQxe8fnXEl2gCIbW2hgOinfo09tpntonoEaz7n4zeF KtxW+drv6qGJrP50LpdKiishyGumgvgSFja+XuuABmRMLhvE+3DCH8CXPfFU3+uQvuoI CwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761233951; x=1761838751; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pm3nq9zl8vSP9OQckXLMLZC8gBiYgr978W9DuCmvOUw=; b=PfMPgxM+Dn1RUxFkrg53cWEWNtOY5iTbqI6ly9YbFPrY4mtwB4L3KMb4xxXIDQQMtI W8pIYmxVC/w5Gs866WfdF/hhRtgqUFLcQ3ux++vc3AKXxtntKpQ7wAFLyTUQQv988fvn eOfLpJpjwIe6H3hwCwD2RtuvXsYXZ5mE2n7yUVuQz2bGwAAZ1HhT5T2pY0hnR2E5P47J dziMOx9Ora02QJdjlkCKAk5YPCjlHPqH+E9m5tLsWINOd+MP+UqBVqEXr5PeRIbLZVsa 3k7rM1a/NdOpoXuui06akfJH9sJAS4Nc3oWYL+KMYNtlFMXxgaORgqSpWMUvfx7Ja3bi uIgw== X-Forwarded-Encrypted: i=1; AJvYcCXh9ySG7HhE5Sqsb7zltR7Zx4uUzDAphehsJo89PpmVHuWHEf8K/zkV8eoQStdZfxr4KtiVxQZG6AaHfm4=@vger.kernel.org X-Gm-Message-State: AOJu0YwpQjD5RlanUjYpnDTgVFr7RRpNGaGepoaz5lsrqpJJwc8K+Nir hZuvVhWZ40EgUtDVi2kg8KkRbMnGdy1o/Qq6GfbSIK29Xx9ZF7DIo+WBpscy0+u1j/GF2Q0RcRU 5kA/J/nM= X-Gm-Gg: ASbGnctiBtZ9eGXpwHpUkHO0I/qoXj408j6zQRlTBNzNHth5Hw50F5uxRXN1nI5Ublt hjcepoiVqGMe4wkHL1W0odtqOAOmHUda7eq9/MJT3MGL2UXttmhcp4w42ffaT2aG07brZFEgKGZ LJGQmKZ3+wrO4AzziyYNiK00dPUBMkd1voRNi98U+6vLPODlDVBARl3eWzn8S6KZi5n8IxT+btU poXMPRBrnxMmatdstVlXstFHJZKgESSneGkfWAmxat7F4Rt9+rvbKryJ49150PoFd7OVy29JmM0 Cwp/W5LIRwgeySPtn8XTMRZkmVxETmhsImQL3mZVlXyRrZ+KXgcZLQcg1M/M83+R9afJICRbTpp nce2cPK1zMdl8RhgP1Hxma5q3WgwWKb81s6g0LoOgJze8Gbi9a5jvWXtJfZGIpzoRLiz5mBOgwB dS53VZu61Tbm035TfyWicdsChDY1yBb5p3nQgZnCaQZNssifdR65vK X-Google-Smtp-Source: AGHT+IFW67sl60in/eMiQDWOwc8lfrPy3RIhmCwSEmLiHSpg5obyZG5HeVxylRoaEHdc7vld3nqL3A== X-Received: by 2002:a05:6000:220b:b0:429:8d46:fc5e with SMTP id ffacd0b85a97d-4298d46fdffmr263763f8f.4.1761233951243; Thu, 23 Oct 2025 08:39:11 -0700 (PDT) Received: from ?IPV6:2a01:e0a:b41:c160:6a1d:efff:fe52:1959? ([2a01:e0a:b41:c160:6a1d:efff:fe52:1959]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898add96sm4522926f8f.30.2025.10.23.08.39.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 08:39:10 -0700 (PDT) Message-ID: <6a2072e1-43be-49a3-b612-d6e2714ec63e@6wind.com> Date: Thu, 23 Oct 2025 17:39:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in IFLA_STATS To: Adrian Moreno , netdev@vger.kernel.org Cc: toke@redhat.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Stanislav Fomichev , Xiao Liang , Cong Wang , linux-kernel@vger.kernel.org References: <20251023083450.1215111-1-amorenoz@redhat.com> From: Nicolas Dichtel Content-Language: en-US Organization: 6WIND In-Reply-To: <20251023083450.1215111-1-amorenoz@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 23/10/2025 à 10:34, Adrian Moreno a écrit : > Gathering interface statistics can be a relatively expensive operation > on certain systems as it requires iterating over all the cpus. > > RTEXT_FILTER_SKIP_STATS was first introduced [1] to skip AF_INET6 > statistics from interface dumps and it was then extended [2] to > also exclude IFLA_VF_INFO. > > The semantics of the flag does not seem to be limited to AF_INET > or VF statistics and having a way to query the interface status > (e.g: carrier, address) without retrieving its statistics seems > reasonable. So this patch extends the use RTEXT_FILTER_SKIP_STATS > to also affect IFLA_STATS. > > [1] https://lore.kernel.org/all/20150911204848.GC9687@oracle.com/ > [2] https://lore.kernel.org/all/20230611105108.122586-1-gal@nvidia.com/ > > Signed-off-by: Adrian Moreno > --- > net/core/rtnetlink.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index 8040ff7c356e..88d52157ef1c 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -2123,7 +2123,8 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, > if (rtnl_phys_switch_id_fill(skb, dev)) > goto nla_put_failure; > > - if (rtnl_fill_stats(skb, dev)) > + if (~ext_filter_mask & RTEXT_FILTER_SKIP_STATS && Maybe parentheses around this first condition? The size could be adjusted accordingly in if_nlmsg_size(). > + rtnl_fill_stats(skb, dev)) > goto nla_put_failure; > > if (rtnl_fill_vf(skb, dev, ext_filter_mask))