From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860922DA757 for ; Mon, 16 Mar 2026 02:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773626868; cv=none; b=Ui5Zt2/8Lmcqa3ctI9DPjkX7fE1EtGrvOcstweH+B2BXBm2cL+2GkwaawKTCZHUM4YxCgCmVwn4mWEBaQlhJKsJsoxe5MmS2H2nSEOe+dFY5HH7FOaeUagsDxV7y7sk+odCj/0rD8J9VpvweZq8sVR7CbFseYL2GwXEc9fcR1PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773626868; c=relaxed/simple; bh=HPaBKR3U80fvQSWgEj+y8B7ck4aIug1oSsSLAqE/2d0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=If/ZR6y2NyDm3JqXkinmVMrO0C+v8qdhpekkImMk1u0hslAQbgDw0QO1LpAHLf4BRluB/RjA0ciUOwFAFVhUx2menC/kf4DqxJyS9QKax67Ggp3njtlsrztbJfhpoEVaSeGkcxnHdw8G59UkD7Ww0GdQoa8pJhQo+1G9kUdQnrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=swu4qAbw; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="swu4qAbw" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5a12c2c5b10so631970e87.2 for ; Sun, 15 Mar 2026 19:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773626866; x=1774231666; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dpc22jmT6VGQLTKw1GYmfyJRKbbmD8YhSAyUKYDuoLA=; b=swu4qAbwCyHfJnb0idTa86iBrORMw1XPGnKWKZelBm88cGruQtM/VRr+45wNGWsYDX GIeHZhDWop1hf/j+yRZ1F7SmBezs1URR/DjrMtXcyWOclIZBkpc1S5BdpymGJi0R/3Jg 6cP/ZQJOQvv73oOt1NCUX9YGpxFVNOgKhM3Gzxk1BQ7YMy/btKsSJAHcgU/6fJwig7NG TdSpknAIx28+3NXwba/8k/t0ZP4w0a0xxVJtrBx95dSw5maAzHJyITZ6aZHhcgeKjvJx /2YkvGo1YioHJWJPpDUkVb+8YaxiC+v+QzkxiC9o4VbZFM3tb7cvnYtCwpUwq3QsTX1k 9jTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773626866; x=1774231666; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dpc22jmT6VGQLTKw1GYmfyJRKbbmD8YhSAyUKYDuoLA=; b=bD87vDqLaOiyJGLc5pF6ghvyn7SOBTBb8UT8hB0pUu9jBu+RZE8H7Wo1JtJwjL3i2m tYhNN7JPcBhd78uc9/I2YJ187IXbQFDAMOK3+OkrsM7ScwYHA8MLoRjpKlbu/dV6thej /spJriClS8Caa5g9Ejpj0AQhFrUvfvnvcpfbpIpbIRP8qpaJlirQGHZ7YtjCuvB1h6UR WBKKaO3A2ma5VusPXpynWEmVMlB2IFNcRSaosg/mirl5UxfCw+82XKdBIG3/tfSCGZwy 7XxyNetWSQhTw8R5R3sg64ms6ypiqkyib9Xrp36zlBU0AH90G7al9pHEOeAqcmrXcxhQ aNmQ== X-Forwarded-Encrypted: i=1; AJvYcCUJUc5iZ0d+JzzGixEBg5dsGiGX0sAPk7o56jy/JKoTlBBxApd48aDP0lY7eKc8PPNn9xPwZbZ42zHkGvI=@vger.kernel.org X-Gm-Message-State: AOJu0YzQhDuMDlV/JjPEwvhfEJGcNy9Ep+YFAFtTilzlxv8CozGu6JSs 3ipNMROQVAcpNp8PdMU1tFxY2S5VBRS0eaqQ+Vk4KZ/pKH1wQi3PvQPKk3IS+E5B9Qw= X-Gm-Gg: ATEYQzylmpW+YzULPghIcuLmDtBQebK6N9h/XldKYAEGSX3Qi3kOPlqOpKTWUxYBg0k D/Rrg3iMud/pMAWAFa/YdaNVwhYwcayXZyFaCR9zFQDe4QOQ1C+2ssLCawtJHKWvEkz0WhJAz9X PBB08kkZgD2KIzzXSocoIboJ7IJgCmoY9KkPT5UqD9Wfg3ccx0n1YZzG18DRt9jzEc46IN1CbTI ZJDhJvYT6kK9caoDDiGAAlU5cOjiHg77uYvVgk7caxsryu7k50i8udZmx3kCL+Z7GWmj3i2kbz/ BRky1g6iaTH+Ijzyty1XKF6j9AFLiuOOgF+wStvImokKlKHTRm74Ds9gtjeHeGm2TcdLhzkBgtE qBuhrt2NpUqbRZGQx8MlkDD9xEjyTXC4FOo4YIAYDS0Y5uCuCwi1hyjF3LhTXDWaJhDVi10v/rR bHB/3euS2ItwrBameQL12gvViyLhjDRETc7QE8NCIrMaSCqsflUl1hwEfbF3mz1gQWxzaXpaAVt twbgA== X-Received: by 2002:a05:651c:546:b0:38a:8602:71df with SMTP id 38308e7fff4ca-38a89769958mr19446821fa.3.1773626865535; Sun, 15 Mar 2026 19:07:45 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a156366676sm3121084e87.71.2026.03.15.19.07.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 19:07:44 -0700 (PDT) Message-ID: <6a25af47-1593-4d2d-b72a-38a68f76ead6@linaro.org> Date: Mon, 16 Mar 2026 04:07:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 2/7] dt-bindings: media: qcom,x1e80100-camss: Add optional PHY handle definitions To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski References: <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-0-fdfe984fe941@linaro.org> <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-2-fdfe984fe941@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-2-fdfe984fe941@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/16/26 03:02, Bryan O'Donoghue wrote: > Add optional PHY handle definitions. This will allow for supporting both > legacy PHY definitions as well as supporting the optional new handle based > approach. > > Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has > its own individual rails. The old binding is still valid but with > individual nodes we define the rails in the CSIPHY sub-nodes. The new proposed CSIPHY device tree nodes should be outside of CAMSS device tree node. > > Signed-off-by: Bryan O'Donoghue > --- > .../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > index b5654ef71bd89..5442f981baebc 100644 > --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml > @@ -43,6 +43,14 @@ properties: > - const: vfe_lite0 > - const: vfe_lite1 > > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > + ranges: true > + > clocks: > maxItems: 29 > > @@ -130,6 +138,16 @@ properties: > description: > 1.2V supply to a PHY. > > + phys: > + maxItems: 4 > + > + phy-names: > + items: > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: csiphy4 > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -162,6 +180,14 @@ properties: > required: > - data-lanes > > +patternProperties: > + "^phy@[0-9a-f]+$": CSIPHY device tree nodes shall be put outside of CAMSS device tree node. > + $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml > + unevaluatedProperties: false > + > + "^opp-table(-.*)?$": > + type: object > + > required: > - compatible > - reg > @@ -175,8 +201,6 @@ required: > - iommus > - power-domains > - power-domain-names > - - vdd-csiphy-0p8-supply > - - vdd-csiphy-1p2-supply > - ports > > additionalProperties: false > @@ -188,6 +212,7 @@ examples: > #include > #include > #include > + #include > #include > > soc { > @@ -233,6 +258,10 @@ examples: > "vfe_lite0", > "vfe_lite1"; > > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; Here 'ranges' machnery is unexpected, the new proposed CSIPHY devices shall be described outside of CAMSS device tree node, as it's stated above. CAMSS is supposed to become a consumer of CSIPHYs, see phy-bindings.txt for 'phys' property. > + > clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>, > <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>, > <&camcc CAM_CC_CORE_AHB_CLK>, > -- Best wishes, Vladimir