From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50C9242D89 for ; Sun, 14 Jun 2026 00:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781396120; cv=none; b=LDqft5mBzLzdFhVLQHSso7YkF/SIieVPOlBFMpdeDdCA1Ancz9VHV24tBCzWBZTRuHzW0yzrxXJDGaRtbFNGeEzCgWY1fWDjMI0/cdmQEpWzVtpbrZp3rtTNX4Ye9xuaI6ZZbHppvMjwbIhqAVH0wmngQ983g83nBSVTBzRgnBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781396120; c=relaxed/simple; bh=Pj+C8pUwwWVRJegU5jsK8XKHgnSgNejqKj/GqWErzXA=; h=Message-ID:From:Date:Subject:To:Cc; b=Yi84j6Mr5xbq16+w2FATZ269LY7BGFT1eJSQKpaP5A842kxxH3rQvXpxsWkabgIMumsHmmRx+4ydneNo4SrSds96eEjt4cv4bsxklpBycJlPYVaqOg5qVqKGAnz3wfPTZi9PvN+ukcIIljPGFksFBbO5Ly1AuaTaNXbwFtkV92A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BS6H67dJ; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BS6H67dJ" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c0c3546924so13589595ad.3 for ; Sat, 13 Jun 2026 17:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781396119; x=1782000919; darn=vger.kernel.org; h=cc:to:subject:date:from:message-id:from:to:cc:subject:date :message-id:reply-to; bh=0HX3ZYLkpoP4OKdcJqiss02RhOC7aeNFTtkhTsIn3N8=; b=BS6H67dJSdUr3Q/83vOMAGDSjN4Y7qcSm4B86mb8wAbXbkhLeipWm9qrpDa2V3doB4 q/vdczjK/hkP6h++VeTrWPmJK+05+AsEQQymn/jvuZ3rbVwYI8Rf/9Fqx5GWaaCT17OU 80ZApjVNQ588oSOS1PSl9jo3CuZaFPaIyBX6H0vbsqNWeWLnkcVPYM8AaSlK8U1KsXZk 3V3LuO3AomDkwTfjfivGySz5akilRhPbU8+Cs8Nl4u6x0nJnIFk7lFRxUG4ItbhqQe0o hCAKneTPt1DETQVpvX50zvR40p9f4heWV3U4ywtIlb/2G3AI4bHIim/GMf6qr/cxQpHf PCmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781396119; x=1782000919; h=cc:to:subject:date:from:message-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0HX3ZYLkpoP4OKdcJqiss02RhOC7aeNFTtkhTsIn3N8=; b=IRd1ly1D/3JnxjPpIkavVsuITMWYfVWZHwEatsBUaLYwMD9TMwkNy0r70EsMRcKu7P 3rAzSNGHFC8+rruqRLcFwig0R5nMKx9VipCGT/94RG36SyVKreyJKIMRk5O9PNEGV4IC 2mFxpqWW8Tq/gyzhwdljPnAkGDyUzhdPjvedeWU2wPvEvco30g0zN2JguA/wMKNz38JA ot8HZHerK08IM211FRYe+sDnyTccv9Btn+W9jPeGkDYp3rRd+KpposqXsRiaBsUBQJal vO0U1jRU0ffSZSYFJO23gCObgvcISbdYyNdlvN7ieQSzG3DvbK6EMN/lbA1BrO5WYA8m j2nw== X-Forwarded-Encrypted: i=1; AFNElJ+oT6rGlazDM435neDfK0bhK52Kwlsg2N/QL/Xk07Z0j5zzV1rHbPKiuPIW0N5ieqXlyckJN581bVuohWg=@vger.kernel.org X-Gm-Message-State: AOJu0YxAKFggfdmYOG61Uow2LKeFeJWFpiK3Celk35I2MiCrj4KJUKl/ k0mKB47uPB1TGbJzGmHnO0KHqRMEWazJ4+GRIEhYiHNpAwcMOTZLVYGtSI5ODMOXCS0= X-Gm-Gg: Acq92OEOA9dbmwBMNxNzmWOWGQbhoFY848GmAAd/yoRqix5oeY5zEw+MOxr3rYNDKo2 GSYKtFw72EtSQmvkIUFT1uakcIKN9dX0Bbsz+aWafxmnfcitfUuCyqRg5i3DQvpCRfn9LtRQBYe A5ziIh1cKLuwTUAi6kvVisCtXwt5c2I34l1YAkwnkvQEKWUXIccIK5fVxdZ1fWkPGjMHq8aNa+J wCA7CA7dwczBLfZA/B+gAjs6UN8VbX8wQnluiyxbgPyBn+ahSqr9d9r++IwSH4zkpIQPq2PMbN8 aqf+LByKieokdGOi8b1YgILID47SKTeu2Ppd2DEC9OFFVCN1t67MjdWJ/Paccb5MdsT6rFAqkM6 cgVJKpUb6Uu5P8gF4QCuoIsnlAW9nl2DwEFeCkPXrGFK0KvFYt38KWwRjkZZ4tJk/AEEI2xdC+6 cSb4b9BXoIAT5A+vpu X-Received: by 2002:a17:902:f610:b0:2c1:88a1:983c with SMTP id d9443c01a7336-2c6642a7bafmr56205255ad.28.1781396119131; Sat, 13 Jun 2026 17:15:19 -0700 (PDT) Received: from [127.0.1.1] ([47.253.114.73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4330782b2sm63552385ad.67.2026.06.13.17.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 17:15:18 -0700 (PDT) Message-ID: <6a2df296.6b2684af.263065.8200@mx.google.com> From: "Wayen.Yan" Date: Sun, 14 Jun 2026 08:14:11 +0800 Subject: [PATCH] thermal/drivers/airoha: Fix low trip clamp using wrong variable To: linux-pm@vger.kernel.org Cc: Rafael J. Wysocki , Daniel Lezcano , Zhang Rui , Lukasz Luba , Christian Marangi , Lorenzo Bianconi , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: In airoha_thermal_set_trips(), the low trip validation incorrectly clamps 'high' instead of 'low': low = clamp_t(int, high, RAW_TO_TEMP(priv, 0), ...); This causes TEMPOFFSETL to receive the clamped high-temperature value instead of the requested low-temperature value, making the low-temperature alert threshold identical to the high-temperature threshold. As a result, low-temperature interrupts can never fire independently. Fix by replacing 'high' with 'low' in the clamp expression, matching the symmetric pattern used for the high trip on line 264. Fixes: 42de37f40e1b ("thermal/drivers: Add support for Airoha EN7581 thermal sensor") Signed-off-by: Wayen --- drivers/thermal/airoha_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c index b9fd6bfc88..439aa011b7 100644 --- a/drivers/thermal/airoha_thermal.c +++ b/drivers/thermal/airoha_thermal.c @@ -273,7 +273,7 @@ static int airoha_thermal_set_trips(struct thermal_zone_device *tz, int low, if (low != -INT_MAX) { /* Validate low and clamp it to a supported value */ - low = clamp_t(int, high, RAW_TO_TEMP(priv, 0), + low = clamp_t(int, low, RAW_TO_TEMP(priv, 0), RAW_TO_TEMP(priv, FIELD_MAX(EN7581_DOUT_TADC_MASK))); /* We offset the low temp of 1°C to trigger correct event */ -- 2.51.0