From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26D423F8EC2 for ; Mon, 15 Jun 2026 14:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533131; cv=none; b=m2ERqxNcVmKUFHWDptMPWRxjlHZZl8WsuzlvU6z5sIAiAJ691HXnWzrPBPbTwTstaRFZRXHOVUIWGq/qo/U7kMVs1Q6F4Q04miigHI5sR2+DwoZD/Ji38iFhV2AgQ++bqD63T0fqwweB5DvgcvDhKrOLsWfJGeplIpFQEG/r4JQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533131; c=relaxed/simple; bh=taTuI/uTOMXjIXPXu667WK4H5vUawgRfjbE0mglsoXM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F3etnONaGYwlYCT6N1TIxJPJMVfXM5Dk+cr+TLz1n/Uph0+N+RAW4g4Xetige0LrEXH/PWAK6yDCzx+hI1gQIs0R2Qb5ivZav58jV7jLzMELBiKxuxV3FEzdxK438XKmCHWD6ygvnwMwkDijxVFyamNoqppQrdNGTS3L3jyi1pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T4ffCKJX; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T4ffCKJX" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490b12270b3so21252405e9.1 for ; Mon, 15 Jun 2026 07:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781533123; x=1782137923; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=hkIb+b4xA4Dtv3ljZrlwMo9RpQWTNWYQCjFJM6rj18U=; b=T4ffCKJXecs/GEA3jL3SD9gnWfr2vZCj6s+uKJMMshsFFDI+ko8XEr6+TbrR8m3i5w YV/D8ZbqmYPpF8gP4XFZ50gbvntssElJc3kN83H/4Vs7DK0Srnk9CzW+6MVRfPz4Kbzq avGNXPh8FXrGXCoRwi/vCEP/+kSUUrwkwejWyKqyhvKfrVeLm4xGZL5jUwRvDBfbIZYk tL5CaCze5IdjLR9/VmmIpv1mzMGGg7wbZk7Vpam05Y5OlPp//KEFH+BsI7Af/xf+sxf0 2AhsWkNBEkbr17ObfDRHyZMX7Ynul1uB5Z6S5jQGFmPApFw+qbZYV1xjjLABhsHL53qp Ltpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533123; x=1782137923; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hkIb+b4xA4Dtv3ljZrlwMo9RpQWTNWYQCjFJM6rj18U=; b=rna+i/VMyDqJYF9RgdVYqiGymBIRshjcydy3A3CQ43T3vSsC+gMz6D2kL+JTk5DVcG Dd897ctmgwroPyBmuakgmdn+Ae2t0ZAFeh3pUtHsYlcZ+F7lo5C/y9nb/qYQ+KvrUsem +fZP1TrGpM2GhIHM6ME2VBYmoym6Gy3nVdLihq0dSjTrqjELYCFZk9klmI0qhT8xJ8dd P9CwHkK7sCMF7kskdrKP6l1rXSWhhUpxmkU5bCZJaa+5Fxu4Z26YP9/xQsi7TgcADaKA jREAEOcuv2U6yf2yxnCgdxa4AdbZgPrAUtYWZ3quyDmUqovCicjN+d1YwW9pWOZ1bR6X jrsw== X-Forwarded-Encrypted: i=1; AFNElJ8tm+76rBzQneQIPi058Qf6F1GK2O4QFC62E5PjN1JQfhIKF813qgleGU7N/kDIMmzMPdFbFzMH1AL3zo0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy51wUbcVc8pC93IGKb4GG2e1vf4k9hcpSUtOuGN2o0Uelek3RE GbMNlN71siCL74fBy2mLaOjJ/fWM1vYff2Yxe8DU0a7KZTHl3k4HIAp6 X-Gm-Gg: Acq92OHjNXqvWN4aVfAm2Nx83UWg0Q/YgTER6p+tiCrd+V5rKBvvc7Ik0zlheYcfKpu 2lUqvSjusubsNWXeJxz8NYY+blxIBHslkFbkK7SEZNgAHTOSZubX5zKhThMzvJGA1dKRgk4qAwM XmEKwh1nLJAytG8TmqkRHU4NjYKq84g5omxJkWG2NRZk4Uj6vuQAm5f50mhytv2NUY2nQIFWJWm BjZl06q53dHpvZk0+9a+txeIOCsmyyeO6j+Rmwrem5HfDLsFv07E/ynKvZLP0cJlHJ2MnWKY0dr I7lP9uLYMLSMQl+7QMHOK5ogow8Y2qScxZ4GB3Tj+jAXifQnVr+cveSZT0/xl6VelqyHcc7fVGH iL2JHNKiUjAZ/9s/EIP0tJ5l4r4tlbGolSm9CaQxm+hqmm7jNJY8r+DezOssG+Zfbng2oIk3mq1 wdQvr2ur2rFHf/tYuT8iaQAudeh+CMh6eI1u8J3TdXMs6rvm4le3os7A== X-Received: by 2002:a05:600c:3153:b0:490:e5c1:b897 with SMTP id 5b1f17b1804b1-490ec4fe7c2mr195111285e9.20.1781533122746; Mon, 15 Jun 2026 07:18:42 -0700 (PDT) Received: from Ansuel-XPS. (93-34-88-103.ip49.fastwebnet.it. [93.34.88.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492202edec6sm283566035e9.3.2026.06.15.07.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 07:18:42 -0700 (PDT) Message-ID: <6a3009c2.561280e1.2acd9f.2f06@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 15 Jun 2026 16:18:37 +0200 From: Christian Marangi To: Maxime Chevallier Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Lorenzo Bianconi , Heiner Kallweit , Russell King , Saravana Kannan , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH net-next v7 01/12] net: phylink: keep and use MAC supported_interfaces in phylink struct References: <20260615122950.22281-1-ansuelsmth@gmail.com> <20260615122950.22281-2-ansuelsmth@gmail.com> <371a1df7-084c-4431-bd00-0045298e3212@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <371a1df7-084c-4431-bd00-0045298e3212@bootlin.com> On Mon, Jun 15, 2026 at 03:33:34PM +0200, Maxime Chevallier wrote: > Hello Christian, > > On 6/15/26 14:29, Christian Marangi wrote: > > Add in phylink struct a copy of supported_interfaces from phylink_config > > and make use of that instead of relying on phylink_config value. > > > > This in preparation for support of PCS handling internally to phylink > > where a PCS can be removed or added after the phylink is created and we > > need both a reference of the supported_interfaces value from > > phylink_config and an internal value that can be updated with the new > > PCS info. > > > > Signed-off-by: Christian Marangi > > --- > > drivers/net/phy/phylink.c | 22 +++++++++++++++------- > > 1 file changed, 15 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > > index 087ac63f9193..4d59c0dd78db 100644 > > --- a/drivers/net/phy/phylink.c > > +++ b/drivers/net/phy/phylink.c > > @@ -60,6 +60,11 @@ struct phylink { > > /* The link configuration settings */ > > struct phylink_link_state link_config; > > > > + /* What interface are supported by the current link. > > + * Can change on removal or addition of new PCS. > > + */ > > + DECLARE_PHY_INTERFACE_MASK(supported_interfaces); > > Can you clarify a bit what you mean here ? Is that the combination of the > interfaces the MAC supports AND the currently in-use PCS ? > Combination of interface the MAC supports and the currently attached PCS (not the current one in use) The fact that it can change is due to the fact that PCS can be attached later and supported_interfaces can be updated accordingly. -- Ansuel