From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309F7325710 for ; Mon, 2 Mar 2026 10:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772446829; cv=none; b=YSxR2AfnMKwAFw97DimFyY8vUjkR7XY9bNQnsmI72S47tJMqdbIxupUuIqSH5nX/4McWVnfeVdZmgMzNvCUyBIJSxedwuJ+W+Kc6WHISRKyUcSK4D0KlmILKm95EVtKc1lwnz9sGRXRCztwLqj1n2FIblFqXgEi/F42YitfhZBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772446829; c=relaxed/simple; bh=CSwsYOD6drWBC+BpkO5jzAuz+Ok5L6cqTE/xt/LghKs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ffKCrtKd1ciYUFimMm78sO6hdlB8oN30fu7E/kP8ZCGaqDxPD6Z/znLJZ/5/TTzPBSPbD/+1enNuZbP6CVSsrIeq/KMxXxHpQGuC57zRNob7P/7S2w9iobFV/2KY+jgROY0HTGpgDCTzA2T4TUY3o4y4H372le8d7207sYY51kE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YKxgqBwL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EfI+dQCT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YKxgqBwL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EfI+dQCT" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6227ma6r055870 for ; Mon, 2 Mar 2026 10:20:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aDm37Yksdkf6+5HA//0dYI0M1pVt85JYFuBsUovDM5Q=; b=YKxgqBwLq2xVnD80 lFN1CVM0u+nyL27CQY4fVm8p/4W1dnw/SNo8KfgEhhgZA8UIhCNsm34iU6+TWaMc dDemMH3DbzpHa/1vkLtpOZkD2nlXEyy2HdAXZrlEpP3T0YxXpG7IObzwHeWWk/Ru BlQovogq8T8nqLdvHA4Kiz6eXlVfZNOyBcPKTILb6h1pvkA8Hw7J8Meg9mCjck3H mxv/qCaKlftje9sgWYet2P21l1RUPE5wo8ogpA83A9PtkAarwaVxOTKqyOXCdTJ2 E0Pu2NURCjUscpIDGWEJ7TnO8iov4d6I6RG17ZE7rOzHt/Aj2/thECsN/QI8Xtgq 4Qhs3A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cmw649x82-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 10:20:27 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb456d53a5so425925285a.2 for ; Mon, 02 Mar 2026 02:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772446826; x=1773051626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aDm37Yksdkf6+5HA//0dYI0M1pVt85JYFuBsUovDM5Q=; b=EfI+dQCTq48K0WyPV6u4Z9Jqt4ivJLk700KJ2qL76vDViu+325HWwKKEvICIfjT2xE sR7ffpiLObmdy5F0Fyh2njyA2NmRBoHUXaRZQTjI9D2bTfN2EnzHdF9v4GRgl0spzcov cXYk8pQatvupn0BKKxU+06iOI4vxuCyc2LNOOmCOS8hjUYueZVu9VaY8WCKg3IZ1kXfE FkmJzjBLNUL3jjLltEtxNID1kwU/DTaEIIf65WGTQJX0LttRq86uTe4tbUvhBa5sQXwN IZtH9a4fmvQbKf9H8Hy6YgrkNyaUjIT0NmlSAt/RSwwSAoDjwbFF2+2Qt4hgjvtojH1q 61Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772446826; x=1773051626; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aDm37Yksdkf6+5HA//0dYI0M1pVt85JYFuBsUovDM5Q=; b=XDFRtGsmRp6qZrgwGxe+1EY/AaoK65Z8cnDYIc0Tf9HUgK4JJKpNwCU0coLmo6UaIk 5mXZyHqBwcLirTPFNKTVYMJvfJZZwoFYCKzpoqROaN06Q02Ltb27b77RnVoOisjQsY4c QxLnsHUZ4BIiJoqpJhdEMJgHbNQ7mI+K7jx+bt2vEk55krzugeQZgUE+yrkX0TpmIzgM 95mQRHgqtBWJmmyLOfJF2Wl2SvQVuosHD2ypyWyjP1GfsciUAInp5Qs3arzTFeojqWLR H/qCtAUqh903Gjus3/ioNyu+x8IJxc5XMdmqubzpr2RvkP8GIRGceuUSkpu339VBOYDe AdFA== X-Forwarded-Encrypted: i=1; AJvYcCX65NFHWFqpL6Z6+w6g9peQXwCMDc69GkVVqbBZz6H/jP5Z249IBHZAv46rDLVas+2a28bnZfvGcX2gxe0=@vger.kernel.org X-Gm-Message-State: AOJu0YwlHn2gj9m3w95UgbEd5skQMtmSa1PPW13F2TapulULVa3gshDY TEsiyWrr29aOdw2J9qXFz5YVWK1l79YQ0cg7ewP2mB6PBGQifpj6WNBCYdvLll/YFKP8OPU8zYJ TNr5vx5v1YKdKdqNTPzVUeyceASksdrqfT/IZ+T2NbhkoKvAJoX/UMTGd0jM1B4MQv3c= X-Gm-Gg: ATEYQzxOGvUvCrnHJJ/zFVE/P1VRR7EGPLG/pYeuavP0jWycMLmmA0guC91hgVeTEqF YxRfF/gBz9qC9s5TlmvzO7msmDZFLCizrXQK+XD3dS+6gpbs1lSf5Ejfv2MOggOPcmahyyy3lOg E3Bd5my/CnA4YBW+yH5KuAmRR7zquwOZtI0gk1Iv9e4qbp6axo7lAldZD8a5cuU+UWC+DxGk7Fc HoR8JVT2MjhYkFCbtPpOLsE2XT+cRzD1e7IhcOEhygzeZsiNg+dCeBzDzgr+VBcyY5/YfZLfiQR kUnmDZfuiFu2AoPJt0uvNAGJVvIvtAa79+C/4MtTB9lQouxOMvFYwc7cTQQSH51T4Tc/TmKu26U S0mn3uPnYRqlg93McGOuVVTSeYF6GFKxeim5GV1xdXWWLeZ7MIV6KyeugmWqkSYS5KBynimh5q0 wIKt4= X-Received: by 2002:a05:620a:4628:b0:8c6:a719:d16f with SMTP id af79cd13be357-8cbc8e7c8e4mr1131129785a.4.1772446826534; Mon, 02 Mar 2026 02:20:26 -0800 (PST) X-Received: by 2002:a05:620a:4628:b0:8c6:a719:d16f with SMTP id af79cd13be357-8cbc8e7c8e4mr1131127385a.4.1772446826043; Mon, 02 Mar 2026 02:20:26 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ae613ddsm453210766b.33.2026.03.02.02.20.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 02:20:25 -0800 (PST) Message-ID: <6a304d0d-61b1-422f-bb65-8f8055095c39@oss.qualcomm.com> Date: Mon, 2 Mar 2026 11:20:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU To: Krzysztof Kozlowski , Rakesh Kota Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Bjorn Andersson , Konrad Dybcio , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov References: <20260227-b4-add_pwrkey_and_resin-v3-0-61c5bb2cdda9@oss.qualcomm.com> <20260227-b4-add_pwrkey_and_resin-v3-1-61c5bb2cdda9@oss.qualcomm.com> <20260228-polite-swine-of-potency-56e61a@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260228-polite-swine-of-potency-56e61a@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ctetm0fZPEU20t2preXDifZr2aWl4zHL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA4NSBTYWx0ZWRfX3tBJXVaQ5SmB ZEC/hmm4kkAEGK4gcAkTT9zadGYBT0yWod0zBqTRVKcDPLZQRNo1EW5kuJbS6R3dbTSPGXXc23U cXqhbC87MBo+Cex//l0ESUswhmwd0rlokZpOYxK1O4HyU8/DDITDyJdn8De8FiH5m+pk28WFccM HlQ3ueEunSICXQ6ZyVfL6ZMvPQ8pljLvvp8NTZKkIAjNnzeh9HjV4nuhyojQbJ+7RgfpwUuuDDx DyXQ0FiVrz7X3468LcEVws3e8ZgYEZnqfIql+Hz2hadjmx0HV8wpF2JwpA6CFCdAvxsgx8RefJ1 scnTM+1036/mcHPF3xNx5Mhz+F7kNCsM60+KSYc6WyCIk8K+KTfxAyvy+6BTdLckUAiX7ptk4ZZ IhuE8HbGmimUglPQMOhOE5sHhYGxVtRkb+ZRHXozxLuxROYXfYQkrdsVOURgkrDroV19c3mn5Ax a7ZYuy0GdmjDqVRuVzw== X-Proofpoint-ORIG-GUID: ctetm0fZPEU20t2preXDifZr2aWl4zHL X-Authority-Analysis: v=2.4 cv=I5Vohdgg c=1 sm=1 tr=0 ts=69a5646b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=3-tsFgwzAueeEB3SUXoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020085 On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote: > On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote: >> PMM8654AU is a different PMIC from PMM8650AU, even though both share >> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC >> variant. >> >> The PMM8654AU PON block is compatible with the PMK8350 PON >> implementation, but PMM8654AU also implements additional PON registers > > So does that mean that PMM8654AU has 2 address spaces and PMK8350 has > only one? At least it looks, so I expect fixing the last if:then: - you > need to drop contains from PMK8350 if clause and add new if:then: for > PMM8654AU. The delta between them is such that within the already-described reg ranges, there is some additional bits and/or registers (can't remember but it doesn't matter for this point) This doesn't impact the described size, as all QC PMIC peripherals are by design allocated 0x100-wide windows Konrad > > Although the binding says "pbs" and here you say "PON". > > >> beyond the baseline. Use the PMM8654AU naming to match the compatible >> string already present in the upstream pinctrl-spmi-gpio driver, keeping >> device tree and kernel driver naming consistent. > > And all this is partially confusing. This is reset/PON, not SPMI Pinctrl > GPIO binding. > > Best regards, > Krzysztof > >