From: Florian Fainelli <f.fainelli@gmail.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net,
kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] net: dsa: allow switch drivers to override default slave PHY addresses
Date: Mon, 30 Mar 2020 20:04:44 -0700 [thread overview]
Message-ID: <6a306ad4-c029-03a3-7a1c-0fdadc13d386@gmail.com> (raw)
In-Reply-To: <20200330135345.4361-1-matthias.schiffer@ew.tq-group.com>
On 3/30/2020 6:53 AM, Matthias Schiffer wrote:
> Avoid having to define a PHY for every physical port when PHY addresses
> are fixed, but port index != PHY address.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
You could do this much more elegantly by doing this with Device Tree and
specifying the built-in PHYs to be hanging off the switch's internal
MDIO bus and specifying the port to PHY address mapping, you would only
patch #4 then.
--
Florian
next prev parent reply other threads:[~2020-03-31 3:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 13:53 Matthias Schiffer
2020-03-30 13:53 ` [PATCH net-next 2/4] net: dsa: mv88e6xxx: account for PHY base address offset in dual chip mode Matthias Schiffer
2020-03-31 3:00 ` David Miller
2020-03-30 13:53 ` [PATCH net-next 3/4] net: dsa: mv88e6xxx: implement get_phy_address Matthias Schiffer
2020-03-30 13:53 ` [PATCH net-next 4/4] net: dsa: mv88e6xxx: add support for MV88E6020 switch Matthias Schiffer
2020-03-31 3:04 ` Florian Fainelli [this message]
2020-03-31 9:09 ` (EXT) Re: [PATCH net-next 1/4] net: dsa: allow switch drivers to override default slave PHY addresses Matthias Schiffer
2020-04-20 9:16 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a306ad4-c029-03a3-7a1c-0fdadc13d386@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®