From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00450C433E0 for ; Mon, 18 May 2020 00:51:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0A6F20758 for ; Mon, 18 May 2020 00:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgERAvF (ORCPT ); Sun, 17 May 2020 20:51:05 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2137 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726680AbgERAvE (ORCPT ); Sun, 17 May 2020 20:51:04 -0400 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id E8C08D36FE6B0E58D10F; Mon, 18 May 2020 08:51:01 +0800 (CST) Received: from dggeme758-chm.china.huawei.com (10.3.19.104) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 18 May 2020 08:51:01 +0800 Received: from [10.173.219.71] (10.173.219.71) by dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 18 May 2020 08:51:01 +0800 Subject: Re: [PATCH net-next] hinic: add support to set and get pause param To: David Miller CC: , , , , References: <20200516020030.23017-1-luobin9@huawei.com> <20200516.132504.766576117055386086.davem@davemloft.net> From: "luobin (L)" Message-ID: <6a340973-ad63-b3e4-a212-4eb9dbe2ee3f@huawei.com> Date: Mon, 18 May 2020 08:51:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200516.132504.766576117055386086.davem@davemloft.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.173.219.71] X-ClientProxiedBy: dggeme704-chm.china.huawei.com (10.1.199.100) To dggeme758-chm.china.huawei.com (10.3.19.104) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will fix. Thanks. On 2020/5/17 4:25, David Miller wrote: > From: Luo bin > Date: Sat, 16 May 2020 02:00:30 +0000 > >> add support to set pause param with ethtool -A and get pause >> param with ethtool -a. Also remove set_link_ksettings ops for VF. >> >> Signed-off-by: Luo bin > Why are you using a semaphore and not a plain mutex. > > Semaphores should be used as an absolute last resort, and only > after trying vigorously to use other locking primitives. > .