From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62FFA39855 for ; Tue, 6 Aug 2024 16:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722960039; cv=none; b=mGTEOpSilbIy6vDMhnOHWBXWATSt9R2q8kJ72nzBlvIUY+XA9vvU5AHU73XorDIfNWnhhiJAzaBkYmnz3fuJn13X0BH6p2EW0AHNuwpfs2mDcWG1yC66PcSQaYjTXllZkfGjuHo+5bUFkvIiPLdsN10ZRSgSHrJ7RhIPmcx50Ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722960039; c=relaxed/simple; bh=G2dFHbwQlABEbn7C/wHN9BFrhR5+2PlXMiREOnZ8MQA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sKI2IG76sDXoYsnPJrerEsn4PF/P5VTz+nKH0WvAoSTWaU1EHinaPQCZ1VYb1By6RpCmn/FtauLecA83AlL1qZrRvpH01DznWHE/b/GtJwNly5SGsqlpwO65VlcKbyV0NwP8I5m64r0Cow8gwekUzrWKm8koIoLhiD9/RIEW3c0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VFOJCTf+; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VFOJCTf+" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-2611dcc3941so178007fac.3 for ; Tue, 06 Aug 2024 09:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722960036; x=1723564836; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=utkiIdj88F+G+vP4WL7Umx3nVwa48ZRhAzXQxTEoHOE=; b=VFOJCTf+mMXWRUO8LnuRgJQsQucOlijtux8CmADQ/7FiSA1BCOhDgHszV1w4Cpp2wB cBOJQchPQWSj87YwfqsbAzURgmeNzS59l4UcD2T+nqS7fMBVVKoMVVzC1FRf1KI1zmvr 8maHH6OKgxm/5jAEbsjUxyHqEM7Vf3/DfI2YE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722960036; x=1723564836; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=utkiIdj88F+G+vP4WL7Umx3nVwa48ZRhAzXQxTEoHOE=; b=kg1BZ44PvZXUT9kQAsIpOUlVpFzOJ90/BnVRT4dHg4eadP3BFWH+RMOoSeccn0AovI OiSipfPTuJeFXzBZWZDVY5wjTJGMit0PVHmAFslXErtQdBsUYAtFH37jqJEUOM+OQ9V0 1wrFnjzyjIwAwx37J95fd6Dx68Cstlg2E49VifX3Hm0EX8C7e4FoPy58POi/ov+RJBSQ Pu15TW52iRFI63Zdu6TVX5a7eAl2exFTzdiLPV8CUZ56UCwph2584Z7na9mwKAupIjRi 79rT9LtC34cyyHzkjyqqFEh7SkvC6GZytD0C2diFNREhErhW3+UAhFteefQrgbyl3ZIh lKaQ== X-Forwarded-Encrypted: i=1; AJvYcCVqcxyf1Ka/Kyb3IwxdIkBhERaMzPGMVm88MUq8vCNadPOzhLeYR2jMjZrY0qEm7PxnR/T3cm38hT8LM05b6aKlwOGcOaRL+ovPpvAo X-Gm-Message-State: AOJu0Yy90f7WP8/nd5YjKa/aOuiNGhFEpQ0paHyqYgRalftawlD3qs1O 9l4TlamQEKZ++NjG9TtO6LTdDRwqQVbV2p+qKtCECQNwh82VjBEHB4FdVITg2FI= X-Google-Smtp-Source: AGHT+IGrBYXn93GiNjPAMz6Efo4Ui0+eYh9UkvImYpLmBkriv1OTC2hCb+Yboc/erVeCc1w6GJHdjw== X-Received: by 2002:a05:6871:4d17:b0:268:97cb:f367 with SMTP id 586e51a60fabf-26897cbfc9amr6125173fac.2.1722960036286; Tue, 06 Aug 2024 09:00:36 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2689a629a83sm3286314fac.45.2024.08.06.09.00.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 09:00:35 -0700 (PDT) Message-ID: <6a3b2f3c-b733-4f64-a550-2f7dcbaf7cb7@linuxfoundation.org> Date: Tue, 6 Aug 2024 10:00:33 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: kvm: fix mkdir error when building for non-supported arch To: Muhammad Usama Anjum , Paolo Bonzini , Shuah Khan Cc: kernel@collabora.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240806121029.1199794-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240806121029.1199794-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/6/24 06:10, Muhammad Usama Anjum wrote: > The mkdir generates an error when kvm suite is build for non-supported built unsupported > architecture such as arm. Fix it by ignoring the error from mkdir. > > mkdir: missing operand > Try 'mkdir --help' for more information. Simply suppressing the message isn't a good fix. Can you investigate a bit more on why mkdir is failing and the architectures it is failing on? This change simply suppresses the error message and continues - Should this error end the build process or not run mkdir to begin with by checking why $(sort $(dir $(TEST_GEN_PROGS)))) results in an empty string? > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/kvm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index 48d32c5aa3eb7..8ff46a0a8d1cd 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -317,7 +317,7 @@ $(LIBKVM_S_OBJ): $(OUTPUT)/%.o: %.S $(GEN_HDRS) > $(LIBKVM_STRING_OBJ): $(OUTPUT)/%.o: %.c > $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c -ffreestanding $< -o $@ > > -$(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS)))) > +$(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS))) > /dev/null 2>&1) > $(SPLIT_TEST_GEN_OBJ): $(GEN_HDRS) > $(TEST_GEN_PROGS): $(LIBKVM_OBJS) > $(TEST_GEN_PROGS_EXTENDED): $(LIBKVM_OBJS) thanks, -- Shuah