From: Shuah Khan <skhan@linuxfoundation.org>
To: Sayyad Abid <sayyad.abid16@gmail.com>, linux-m68k@lists.linux-m68k.org
Cc: fthain@linux-m68k.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 0/3] drivers: nubus: Fix coding style issues in nubus.c
Date: Wed, 2 Oct 2024 16:20:12 -0600 [thread overview]
Message-ID: <6a403ccb-1d77-4c90-8e7d-35cbafdf5633@linuxfoundation.org> (raw)
In-Reply-To: <20241002132820.402583-1-sayyad.abid16@gmail.com>
On 10/2/24 07:28, Sayyad Abid wrote:
> This patch series addresses coding style improvements in
> the Nubus subsystem, specifically in `nubus.c`. These changes
> aim to enhance readability and maintainability of the code.
>
> These coding style inconsistencies were found using checkpatch.pl
>
> Changes include:
> 1. Improved comment block formatting by aligning `*` in
> multi-line comments.
> 2. Fixing assignments inside conditional statements to improve clarity.
> 3. Correcting the use of tabs for indentation in specific functions.
>
> Each commit focuses on a specific aspect, as detailed below.
>
>
> Sayyad Abid (3):
> Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
> Fix use of assignment in if condition in nubus_add_board()
> Fix use of * in comment block in nubus.c
>
> drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
> 1 file changed, 53 insertions(+), 41 deletions(-)
>
> --
> 2.39.5
>
Why are you sending 3 patches for these changes in one single
file?
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-02 22:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 13:28 Sayyad Abid
2024-10-02 13:28 ` [PATCH 1/3] drivers: nubus: Fix use of tabs in nubus_get_vendorinfo and nubus_add_board " Sayyad Abid
2024-10-02 13:28 ` [PATCH 2/3] drivers: nubus: Fix use of assignment in if condition in nubus_add_board() " Sayyad Abid
2024-10-02 22:18 ` Shuah Khan
2024-10-03 10:53 ` kernel test robot
2024-10-02 13:28 ` [PATCH 3/3] drivers: nubus: Fix use of * in comment block " Sayyad Abid
2024-10-02 22:20 ` Shuah Khan [this message]
2024-10-02 22:55 ` [PATCH 0/3] drivers: nubus: Fix coding style issues " Finn Thain
2024-10-03 3:31 ` Sayyad Abid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a403ccb-1d77-4c90-8e7d-35cbafdf5633@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=fthain@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=sayyad.abid16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®