From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE6D61AA1DE; Wed, 8 Jan 2025 07:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736319884; cv=none; b=syG4q0XoBXJAOD3u/Zx4KHT0+TyRtjfmo8VPkfLirgDO0KAT8rTvkzW08pwIceYPbbVioEUkWjE/VUikAqUvykn0RfrOpq3coRDEbSz6LVbTjhv34fm6La4EWSxG09VSqNMMcXXKCBuo7KYKlhNJGl58g0r023/mJcdDcM6qQAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736319884; c=relaxed/simple; bh=97Z9jXEaLvqI/0AurCDd73gtcj00ygdYOHTFT0NTmkM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hMjFChu4jTgz/qCHQAUbYQKIlgR/Be8mERDPj2mcwSMOKqEKCOD+1S1Ka+uyEEcL4f+1/w+sGAVuWk1894pXYmRb5wl6K6VIci8dfLKAaNq0zi//29BH19j+o3Wn8J3A3BaLBqYN9N9iPLWLVS0daZ9BG1OVAc9m4+fwTQJteo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ViDd3Noq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=GHJ04it5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iUnAYZ1m; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=FTvolTlt; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ViDd3Noq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="GHJ04it5"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iUnAYZ1m"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FTvolTlt" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F133B21109; Wed, 8 Jan 2025 07:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736319879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUhd/vuJ7Qh4LISlnOJEeKSvhL5c1rYQUMWf6j8GZeg=; b=ViDd3NoqiqVOw2/F9yp9EvyDJfLISJyYQ4UotJYQpkkAqf9OHyT8WVYsHo+0a9pvEeUqjU l0u1iR+pJX36ctMq5TIKAxKeZa6J79zqHYF668UJFvw5D3XogKOlAWItZqMmVK9cZCKUMv PmrtvmUmRsA2U/pxIdV9LQEpCWP31j4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736319879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUhd/vuJ7Qh4LISlnOJEeKSvhL5c1rYQUMWf6j8GZeg=; b=GHJ04it55qgadeJB0HPBJ/S3wWihS/kC5KcVYb5uJl54RaanMTHlu2VKDEYKVokAtTfoiT z2AHYjki37ZKiqCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iUnAYZ1m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FTvolTlt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1736319878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUhd/vuJ7Qh4LISlnOJEeKSvhL5c1rYQUMWf6j8GZeg=; b=iUnAYZ1mlH5DLdSHz87oUNEUKYGUO+jnlha57dp2yLQ+NJuZ6BFXAhKJSgo2fPUDTogffB wX4OrtgOOdAnHQRLO6HnnwmOrIc0l1KaFT+4ajfc6aBBmPmLik4pzocJE9/y5ZWvrMpSNh g2PXFkwEyCC/BGEySUEA9xfz3QIvcVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1736319878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUhd/vuJ7Qh4LISlnOJEeKSvhL5c1rYQUMWf6j8GZeg=; b=FTvolTltjMasmbymK0ioBc2v1CZv4TyCuHXgHieN7ZMx6VJ+9jjx5+fy+pbM+y7vIFWfM+ zZK8M7sGER6i4cCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5E258137DA; Wed, 8 Jan 2025 07:04:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id u4KYE4Qjfme4PAAAD6G6ig (envelope-from ); Wed, 08 Jan 2025 07:04:36 +0000 Message-ID: <6a40ed2d-173f-4723-8570-f06b0c9c0ee2@suse.de> Date: Wed, 8 Jan 2025 08:04:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] blk-mq: add number of queue calc helper To: Daniel Wagner , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Don Brace , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , Andrew Morton , Thomas Gleixner Cc: Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Ming Lei , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Frederic Weisbecker , Mel Gorman , Sridhar Balaraman , "brookxu.cn" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev References: <20241217-isolcpus-io-queues-v4-0-5d355fbb1e14@kernel.org> <20241217-isolcpus-io-queues-v4-3-5d355fbb1e14@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241217-isolcpus-io-queues-v4-3-5d355fbb1e14@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F133B21109 X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,lst.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[38]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[redhat.com,suse.com,kernel.org,suse.de,parallelwireless.com,gmail.com,vger.kernel.org,lists.infradead.org,broadcom.com,microchip.com,lists.linux.dev]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; R_RATELIMIT(0.00)[to_ip_from(RLeuu8pmbomyos8bjut4e19yoq)]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 12/17/24 19:29, Daniel Wagner wrote: > Multiqueue devices should only allocate queues for the housekeeping CPUs > when isolcpus=managed_irq is set. This avoids that the isolated CPUs get > disturbed with OS workload. > > Add two variants of helpers which calculates the correct number of > queues which should be used. The need for two variants is necessary > because some drivers calculate their max number of queues based on the > possible CPU mask, others based on the online CPU mask. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Daniel Wagner > --- > block/blk-mq-cpumap.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > include/linux/blk-mq.h | 2 ++ > 2 files changed, 47 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich