mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Jann Horn <jannh@google.com>
Cc: "Mukesh Ojha" <mojha@codeaurora.org>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"Muli Ben-Yehuda" <mulix@mulix.org>,
	"Jon Mason" <jdmason@kudzu.us>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	iommu@lists.linux-foundation.org,
	"kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/calgary: fix bitcast type warnings
Date: Fri, 29 Mar 2019 15:43:23 -0600	[thread overview]
Message-ID: <6a41d1f8-4be6-40d6-e30d-71abf70f4468@deltatee.com> (raw)
In-Reply-To: <CAG48ez1e=vHZqRp7=rQCvOjJnHjQtR5wQKZ69jOAZChto7RDCA@mail.gmail.com>



On 2019-03-29 3:40 p.m., Jann Horn wrote:
> So what is the right thing to do in the context of
> arch/x86/kernel/pci-calgary_64.c? That code wants to perform MMIO with
> endianness conversion, and these accesses are always performed as
> MMIO. Using the non-atomic 64-bit I/O helpers for this would be kind
> of awkward, since the accesses would never actually be split...

Well, if you know you're only ever doing MMIO, you'd probably just want
to use readq() directly.

Logan


  reply	other threads:[~2019-03-29 21:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 22:59 Jann Horn
2019-03-29  8:18 ` Mukesh Ojha
2019-03-29 16:48   ` Jann Horn
2019-03-29 21:19     ` Jann Horn
2019-03-29 21:25       ` Jann Horn
2019-03-29 21:32       ` Logan Gunthorpe
2019-03-29 21:40         ` Jann Horn
2019-03-29 21:43           ` Logan Gunthorpe [this message]
2019-03-29 21:45   ` Jann Horn
2019-03-30 10:24     ` Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a41d1f8-4be6-40d6-e30d-71abf70f4468@deltatee.com \
    --to=logang@deltatee.com \
    --cc=bp@alien8.de \
    --cc=horia.geanta@nxp.com \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jannh@google.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mojha@codeaurora.org \
    --cc=mulix@mulix.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®