From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567861E51EA for ; Wed, 2 Jul 2025 16:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751473070; cv=none; b=u747ZbHGl9EXZTbPkFug6puKSsOGtrRweonW6v3dbsMeffAgBJ5/aJWsYNM2mCxmEIKjdYlvVASrDljUOTCLW7szFQr6j1PX9d1vOvPcTlasXi82REfYVKTO+JD18aBSSWxsPrrX31I2WaN//no592xZF4Z66gB3kh5QaoPnvT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751473070; c=relaxed/simple; bh=65WluV3BvvXKhljAjH+/Or49/aYcpF02/db+XF1Iy/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E0vzRiqitMdChx6S5HKyF6b6KDJTx6wTopdSr0GdyRZfK2MMdkoq+lRqDi95DeMWXxBd6AhkgGWDydy8LqAdXPoJvJwzjjZ+SIS66NXSnZ3kxjif5r/38DQXfpDLCNUmOPQBPlAny9cqCvfdeqSu6VyN94c65argyFjDUSMuuVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com; spf=pass smtp.mailfrom=6wind.com; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b=YfxY0NsL; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="YfxY0NsL" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a524caf77eso1047473f8f.3 for ; Wed, 02 Jul 2025 09:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1751473067; x=1752077867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+DRtnG3/5fhrw2/e04xUvMWhA80ygiUHCaMrGaRsIHA=; b=YfxY0NsLV1mAMRBl/86xKM2VPXaewCQG/0XeJd8Q6XoSxm3wEvSBMcIowynsmPLJur pp7gCyASoI8ZpkY01JRdTtBL3QYBYZqgEqMyJ854lpkDeR46kS4skemu2a1/I5l7Vjq3 65psKvUq0U11YambA0Wk0toSVlaV6xkMC+veYCqlw5X8DDGZa2HQl9Ula8oc9eKfqMHu qGL+ogzL7mGTTeTQqJ8AL/Ln5qc2TlfR0YJC/zcQVhiGSe+fwPGQcMi7B1Hk54uKgHqo a3A1MDd67X9vY0ALqKLsd63tKPU0CG+a7IqWyNXUGT1wYDYKf+4bFA6y0bPAXHhGZbZh dynQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751473067; x=1752077867; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+DRtnG3/5fhrw2/e04xUvMWhA80ygiUHCaMrGaRsIHA=; b=XOq9TADPPWxaqlVxa6cDAYAcuNpCCyOZoYdeboJvLhLiH4M/dQmZTKYRytzBoir92b PjFj/SIO+yKmwlJzdkqFmCnNuSCYNtENLCnUW76Fg6eacJx1dh+LDnevTevee2NkYjQ6 pVQGHVRybNV/UQMeCL8TMkFyVgVLLUjeL8Y6fJdQ6t8P1hSZcVGCK6FjJZI7b1hOCNE7 yXiATT86WJc1mOCz/pd1g+VWWDg7V1eJmzrXOlA56UVx+cVxAUa5OsSHVTlIhs4+Wy33 G/zP2raDDhD3c6KxD6p5fF6XO4JeT8mj0XWhHxk0Utq3FNP5QDTmAFqPiQqhYh3gfPYE FFKQ== X-Forwarded-Encrypted: i=1; AJvYcCWWNZMcv2z3tcSHn8WGSCZM3EX6SpP5bUgYfej7dEvp1LI0Gu1xfvOwFiK/vwUHW/zuosDJozRAXD6Np0c=@vger.kernel.org X-Gm-Message-State: AOJu0YztnzC3UTXy2NngtINZtqreiRln4rtieIZtprxOVljvL1XtNdW9 n2wfm0Qtixezvlzbjy/3mcicayux/l+FGLxeV+UT0l2mx6LOAzrrWglD+qxXDjqSs1M= X-Gm-Gg: ASbGnctSjSnh0CqTF6M/lC0MF4hMT3r+0dElPHrviPBFZqhF4RNuJPU+8Z/F7mcjRu5 KuiwKM/9UYdeoqnfUP91WSTzdmz/oAC1NNhIB4TXl6fQBNxZQUSIst9KZTwgWqQFmCeg7PKA88n auRMjLSLYOukNZgGYDlYXj7RVnUdGkno2wH2xhgU+bnZVuCx05C/373V8pOEGYa/8RbuHcSwvlk zO5gjJnTwhk97vjDMvZlz1ksz1BC3i8jMkImMHYZWRCkd2q1BxR/Utf+8NgV28DGAVBOM1B26vb yqGMr8sSY7wj9ARE5ftA719cGUIwBX5pssBeGPk6d8Bg7u3sSxA12HzOjPXIn/N/RV45m2qwUwz PaXzky0PWl06GIOnxZJvuJvaDHsfOE18fJcRMgLs= X-Google-Smtp-Source: AGHT+IGmgT1DZZNaOfq26TUVuwOD6QhF7YzlfyrujVZ7SN1RUi3cre88qvNTmXSTqyDFUkfv1BFcUg== X-Received: by 2002:a05:600c:4751:b0:453:c08:a1fa with SMTP id 5b1f17b1804b1-454a3674ea1mr14677105e9.0.1751473066499; Wed, 02 Jul 2025 09:17:46 -0700 (PDT) Received: from ?IPV6:2a01:e0a:b41:c160:5568:c43d:79bc:c2ec? ([2a01:e0a:b41:c160:5568:c43d:79bc:c2ec]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a997e24bsm2310945e9.16.2025.07.02.09.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 09:17:45 -0700 (PDT) Message-ID: <6a42127f-77bd-4a25-af61-8bb8adb666c1@6wind.com> Date: Wed, 2 Jul 2025 18:17:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH v3] ipv6: add `force_forwarding` sysctl to enable per-interface forwarding To: Jakub Kicinski Cc: Gabriel Goller , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , David Ahern , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250702074619.139031-1-g.goller@proxmox.com> <20250702073458.3294b431@kernel.org> <7c47cfb6-c1f1-42a1-8137-37f8f03fa970@6wind.com> <20250702091055.3d70a5ee@kernel.org> From: Nicolas Dichtel Content-Language: en-US Organization: 6WIND In-Reply-To: <20250702091055.3d70a5ee@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 02/07/2025 à 18:10, Jakub Kicinski a écrit : > On Wed, 2 Jul 2025 17:14:42 +0200 Nicolas Dichtel wrote: >>> Should we invert the polarity? It appears that the condition below only >>> let's this setting _disable_ forwarding. IMO calling it "force" suggests >>> to the user that it will force it to be enabled. >> Not sure to follow you. When force_forwarding is set to 1 the forwarding is >> always enabled. >> >> sysctl | all.forwarding | iface.force_forwarding | packet processing from iface >> | 0 | 0 | no forward >> | 0 | 1 | forward >> | 1 | 0 | forward >> | 1 | 1 | forward > > Ugh, I can't read comparisons to zero. > Let's switch to more sane logic: > > if (idev && !READ_ONCE(idev->cnf.force_forwarding) && > !READ_ONCE(net->ipv6.devconf_all->forwarding)) +1