mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel@collabora.com, "Chang S . Bae" <chang.seok.bae@intel.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability
Date: Thu, 18 Jul 2024 09:48:35 -0600	[thread overview]
Message-ID: <6a477f29-3425-434d-88a7-b3d619fef2b8@linuxfoundation.org> (raw)
In-Reply-To: <20240718113222.867116-2-usama.anjum@collabora.com>

On 7/18/24 05:32, Muhammad Usama Anjum wrote:
> Removes manual counting of pass and fail tests. This increases readability
> of tests, but also improves maintainability of the tests. Print logs in
> standard format (without [RUN], [OK] tags)
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes since v1:
> - correct description of the patch
> 
> Changes since v2:
> - Update description of the patch and add before/after output
> 
> Before:
>    # selftests: x86: check_initial_reg_state_32
>    # [OK]	All GPRs except SP are 0
>    # [OK]	FLAGS is 0x202
>    ok 5 selftests: x86: check_initial_reg_state_32
> 
> After:
>    # selftests: x86: check_initial_reg_state_32
>    # TAP version 13
>    # 1..2
>    # ok 1 All GPRs except SP are 0
>    # ok 2 FLAGS is 0x202
>    # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
>    ok 5 selftests: x86: check_initial_reg_state_32

What's the output you see if you were run this as:

make ksefltest TARGETS=x86

How is this different from the output from the above command?

Please provide the same information for your other patches in this
series

thanks,
-- Shuah

  reply	other threads:[~2024-07-18 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 11:32 [PATCH v3 0/4] selftest: x86: improve tests Muhammad Usama Anjum
2024-07-18 11:32 ` [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability Muhammad Usama Anjum
2024-07-18 15:48   ` Shuah Khan [this message]
2024-07-19  7:28     ` Muhammad Usama Anjum
2024-07-19 16:52       ` Shuah Khan
2024-07-18 11:32 ` [PATCH v3 2/4] selftests: x86: corrupt_xstate_header: " Muhammad Usama Anjum
2024-07-18 11:32 ` [PATCH v3 3/4] selftests: x86: fsgsbase_restore: " Muhammad Usama Anjum
2024-07-18 11:32 ` [PATCH v3 4/4] selftests: x86: entry_from_vm86: " Muhammad Usama Anjum
2024-07-18 15:49 ` [PATCH v3 0/4] selftest: x86: improve tests Shuah Khan
  -- strict thread matches above, loose matches on Subject: below --
2024-07-12  8:53 [PATCH v3 0/4] selftest: x86: remove manual counting and increase maintainability Muhammad Usama Anjum
2024-07-12  8:53 ` [PATCH v3 1/4] selftests: x86: check_initial_reg_state: " Muhammad Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a477f29-3425-434d-88a7-b3d619fef2b8@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=binbin.wu@linux.intel.com \
    --cc=chang.seok.bae@intel.com \
    --cc=kernel@collabora.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®