From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdF0E4x (ORCPT ); Tue, 27 Jun 2017 00:56:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59854 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751048AbdF0E4r (ORCPT ); Tue, 27 Jun 2017 00:56:47 -0400 Subject: Re: [PATCH] mm/memory_hotplug: remove an unused variable in move_pfn_range_to_zone() To: Wei Yang , mhocko@kernel.org, akpm@linux-foundation.org References: <20170626231928.54565-1-richard.weiyang@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Anshuman Khandual Date: Tue, 27 Jun 2017 10:26:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170626231928.54565-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17062704-0012-0000-0000-0000024D6CC0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062704-0013-0000-0000-000007662706 Message-Id: <6a58b706-f409-b81f-4859-a6323bce1758@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-27_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706270080 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2017 04:49 AM, Wei Yang wrote: > There is an unused variable in move_pfn_range_to_zone(). > > This patch just removes it. > > Signed-off-by: Wei Yang > --- > mm/memory_hotplug.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 514014dde16b..16167c92bbf1 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -899,7 +899,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone, > struct pglist_data *pgdat = zone->zone_pgdat; > int nid = pgdat->node_id; > unsigned long flags; > - unsigned long i; > > if (zone_is_empty(zone)) > init_currently_empty_zone(zone, start_pfn, nr_pages); We have this down in the function. IIRC I had checked out tag mmotm-2017-06-16-13-59 where I am looking out for this function. for (i = 0; i < nr_pages; i++) { unsigned long pfn = start_pfn + i; set_page_links(pfn_to_page(pfn), zone_idx(zone), nid, pfn); }