From: Harry Wentland <harry.wentland@amd.com>
To: "Colin Ian King" <colin.i.king@gmail.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
Xinhui.Pan@amd.com, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: fix spelling mistake: synatpics -> synaptics
Date: Fri, 28 Jan 2022 12:59:31 -0500 [thread overview]
Message-ID: <6a5b1f8e-22a1-9c26-aea4-6bb38c4aa084@amd.com> (raw)
In-Reply-To: <20220128173502.594099-1-colin.i.king@gmail.com>
On 2022-01-28 12:35, Colin Ian King wrote:
> There are quite a few spelling mistakes in various function names
> and error messages. Fix these.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 75b5299b3576..db4ab01267e4 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -539,7 +539,7 @@ bool dm_helpers_submit_i2c(
> }
>
> #if defined(CONFIG_DRM_AMD_DC_DCN)
> -static bool execute_synatpics_rc_command(struct drm_dp_aux *aux,
> +static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,
> bool is_write_cmd,
> unsigned char cmd,
> unsigned int length,
> @@ -578,7 +578,7 @@ static bool execute_synatpics_rc_command(struct drm_dp_aux *aux,
> ret = drm_dp_dpcd_write(aux, SYNAPTICS_RC_COMMAND, &rc_cmd, sizeof(rc_cmd));
>
> if (ret < 0) {
> - DRM_ERROR(" execute_synatpics_rc_command - write cmd ..., err = %d\n", ret);
> + DRM_ERROR(" execute_synaptics_rc_command - write cmd ..., err = %d\n", ret);
> return false;
> }
>
> @@ -600,7 +600,7 @@ static bool execute_synatpics_rc_command(struct drm_dp_aux *aux,
> drm_dp_dpcd_read(aux, SYNAPTICS_RC_DATA, data, length);
> }
>
> - DC_LOG_DC(" execute_synatpics_rc_command - success = %d\n", success);
> + DC_LOG_DC(" execute_synaptics_rc_command - success = %d\n", success);
>
> return success;
> }
> @@ -618,54 +618,54 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
> data[3] = 'U';
> data[4] = 'S';
>
> - if (!execute_synatpics_rc_command(aux, true, 0x01, 5, 0, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x01, 5, 0, data))
> return;
>
> // Step 3 and 4
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x220998, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x220998, data))
> return;
>
> data[0] &= (~(1 << 1)); // set bit 1 to 0
> - if (!execute_synatpics_rc_command(aux, true, 0x21, 4, 0x220998, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x21, 4, 0x220998, data))
> return;
>
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x220D98, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x220D98, data))
> return;
>
> data[0] &= (~(1 << 1)); // set bit 1 to 0
> - if (!execute_synatpics_rc_command(aux, true, 0x21, 4, 0x220D98, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x21, 4, 0x220D98, data))
> return;
>
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x221198, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x221198, data))
> return;
>
> data[0] &= (~(1 << 1)); // set bit 1 to 0
> - if (!execute_synatpics_rc_command(aux, true, 0x21, 4, 0x221198, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x21, 4, 0x221198, data))
> return;
>
> // Step 3 and 5
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x220998, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x220998, data))
> return;
>
> data[0] |= (1 << 1); // set bit 1 to 1
> - if (!execute_synatpics_rc_command(aux, true, 0x21, 4, 0x220998, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x21, 4, 0x220998, data))
> return;
>
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x220D98, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x220D98, data))
> return;
>
> data[0] |= (1 << 1); // set bit 1 to 1
> return;
>
> - if (!execute_synatpics_rc_command(aux, false, 0x31, 4, 0x221198, data))
> + if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x221198, data))
> return;
>
> data[0] |= (1 << 1); // set bit 1 to 1
> - if (!execute_synatpics_rc_command(aux, true, 0x21, 4, 0x221198, data))
> + if (!execute_synaptics_rc_command(aux, true, 0x21, 4, 0x221198, data))
> return;
>
> // Step 6
> - if (!execute_synatpics_rc_command(aux, true, 0x02, 0, 0, NULL))
> + if (!execute_synaptics_rc_command(aux, true, 0x02, 0, 0, NULL))
> return;
>
> DC_LOG_DC("Done apply_synaptics_fifo_reset_wa\n");
next prev parent reply other threads:[~2022-01-28 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 17:35 Colin Ian King
2022-01-28 17:59 ` Harry Wentland [this message]
2022-01-28 18:53 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5b1f8e-22a1-9c26-aea4-6bb38c4aa084@amd.com \
--to=harry.wentland@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=colin.i.king@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®