From: Bart Van Assche <bvanassche@acm.org>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
mani@kernel.org, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, avri.altman@wdc.com,
ebiggers@google.com, neil.armstrong@linaro.org,
konrad.dybcio@oss.qualcomm.com
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH V5 2/3] scsi: ufs: core: Add ufshcd_dme_rmw to modify DME attributes
Date: Mon, 14 Jul 2025 09:03:37 -0700 [thread overview]
Message-ID: <6a5cc425-2b54-4b0c-8475-196bef2dcab5@acm.org> (raw)
In-Reply-To: <20250714075336.2133-3-quic_nitirawa@quicinc.com>
On 7/14/25 12:53 AM, Nitin Rawat wrote:
> + * @mask: mask to apply on read value
The description of 'mask' could have been more clear, e.g. "indicates
which bits to clear from the value that has been read". Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2025-07-14 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 7:53 [PATCH V5 0/3] ufs: ufs-qcom: Align programming sequence as per HW spec Nitin Rawat
2025-07-14 7:53 ` [PATCH V5 1/3] ufs: ufs-qcom: Update esi_vec_mask for HW major version >= 6 Nitin Rawat
2025-07-14 7:53 ` [PATCH V5 2/3] scsi: ufs: core: Add ufshcd_dme_rmw to modify DME attributes Nitin Rawat
2025-07-14 16:03 ` Bart Van Assche [this message]
2025-07-14 7:53 ` [PATCH V5 3/3] ufs: ufs-qcom: Enable QUnipro Internal Clock Gating Nitin Rawat
2025-07-15 1:05 ` [PATCH V5 0/3] ufs: ufs-qcom: Align programming sequence as per HW spec Martin K. Petersen
2025-07-22 3:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5cc425-2b54-4b0c-8475-196bef2dcab5@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=ebiggers@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_nitirawa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®