From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187E4C25B6B for ; Thu, 26 Oct 2023 09:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjJZJac (ORCPT ); Thu, 26 Oct 2023 05:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjJZJaa (ORCPT ); Thu, 26 Oct 2023 05:30:30 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2384E186 for ; Thu, 26 Oct 2023 02:30:28 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso5353925e9.3 for ; Thu, 26 Oct 2023 02:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698312626; x=1698917426; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JzN3kghX0r8zpxRcc0ENszPUJaJiNNkjOsgmWnftG5k=; b=uUIIzoj6LhQ3YkhL2X6FbtyyDNz/xxhHdXFh3ZNTbxiDVxO74olbEZX9mPoSGafYoT bm3Qvsoo4UwMeTEMINeb1aucCRt8H+tOL07nnlPzyAUr9JPxsnHhUAmIddTN/W16Tdgo FJu5EEDISp6iV4vSgicXnLoP63yPvy4+E64mfvgtub4tFC8L2JKoKkqx7pxbsqqVzXh0 prf9xjb6Qoxrm74ho3EP+2rsiNw1wDGbWy4gXLoMJcBXt89MFxhtoi2oY5b5uAJFP1c7 vPEyR4RAf1CG/txpb/j6WmQ03+LxiEPN3o0bMtnKtmbiwdvkEZazaru9djKFU5NFTujw oa6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698312626; x=1698917426; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JzN3kghX0r8zpxRcc0ENszPUJaJiNNkjOsgmWnftG5k=; b=Jeee6ov9MsscOz/Zes69Gp/gQSoDPrvehnzaYi4aM0x5XewArz+vXOf9hgpP+8u94g NmN+NW8ot72aoK4Jn9ZAuB172xi8VWdn2PhxXu+6bKSERCLlah8WZ6jHEoifr6EVhLH+ 9mWThUnZv68Xn1moZ1Kx5mfF22HZdkatWD5MgXknwNw9w67OEVfCBKXqB9BSLS1+2U3w nxS40uot3st/xzml0+IGPEMwYyhtLyXuBzDRem5c/LUnYIGY+aECEn9logg5OXg7JwYD b2rKeywVDlOT+trgezdHslKgha7rEba+Hqxf0IxMToWLjoDOrfFPaJzLxQJYTKDIsxBZ q78A== X-Gm-Message-State: AOJu0YwxIck3Vse4y0HkO+1InOGymraeWq+QK1GdMoe8xSS8WFBoWloh r3ijwFgE3nBpV/c3D757rwo0yg== X-Google-Smtp-Source: AGHT+IFbCJ2aNN5hfs6KLklgeQ8R+R7dBY0KqY6VDKCiFgk6oQIaJA1xQzDXWqNVc6p9WIW1ERMmVw== X-Received: by 2002:a5d:4b4b:0:b0:32d:8401:4057 with SMTP id w11-20020a5d4b4b000000b0032d84014057mr11785427wrs.15.1698312626501; Thu, 26 Oct 2023 02:30:26 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p17-20020a5d68d1000000b0032d687fd9d0sm13842098wrw.19.2023.10.26.02.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 02:30:26 -0700 (PDT) Date: Thu, 26 Oct 2023 12:30:22 +0300 From: Dan Carpenter To: Su Hui Cc: lukas@wunner.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, tiwai@suse.de, Jim.Qu@amd.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] vga_switcheroo: Fix impossible judgment condition Message-ID: <6a5f2bff-cef4-4287-b72d-0db91c850de4@kadam.mountain> References: <20231026091804.967960-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231026091804.967960-1-suhui@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 26, 2023 at 05:18:04PM +0800, Su Hui wrote: > 'id' is enum type like unsigned int, so it will never be less than zero. > It's better to check VGA_SWITCHEROO_UNKNOWN_ID too. > > Fixes: 4aaf448fa975 ("vga_switcheroo: set audio client id according to bound GPU id") > Signed-off-by: Su Hui > --- > v2: > - add check of VGA_SWITCHEROO_UNKNOWN_ID(Dan's suggestion). > > By the way, all functions of 'get_client_id' will never return error code > or VGA_SWITCHEROO_UNKNOWN_ID，should we remove this check or keep it for > future. > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter