From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4812F28FF for ; Sat, 25 Jul 2026 01:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784944423; cv=none; b=RdoU5lCY1/GHdpsXk0bPd+ZMLANd/ZuuUz1z4xyG8iAxG5oDC0SiyS21SjWA9PY+MB1hImVp/gJu1dr83weJHVFQn3rYxCl0ZhZT9gOOYor5XghzSwJdZffbazVIDUCoLANuSPSpd0gt71mwJH2H5HTz8Ktg4ZhLbIPIvTPAktk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784944423; c=relaxed/simple; bh=LSDAIEij27ZuAtttsFdMEgaavYzlU8NSdvdDyIALZn4=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=CimDDCZfTI22u92BGi2AsWRTDrfzeaAMoU5U1ZJHl0qxX1exbWRnFLe6ot/ENUv7P0CH7X1ZMKfDFmibY3HDVGm9O/QlBVAS2t0otQA9131+vJsvtR8PbHCIu24u+yNV2bY6BAF1EmeAIZBXtMs5E3C16t8amAIkZpitM6icZlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.160.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-457b65b5edfso724011fac.1 for ; Fri, 24 Jul 2026 18:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784944421; x=1785549221; h=content-type:to:from:subject:message-id:in-reply-to:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VAYQyCQEBUTMJj3WdFxqMdp8WSIYdCi1dvq+zZU8cG0=; b=a/m5eWxGzJLnKAYAyXjtQJv/7LDKjt0GhGgI4WKFj5f5QE+K+yTQP8tVkjCYzU3Lbj I37/UTSewO8UcODqFXumRgQuxVhZUnd/apOkXo6GlUD7Ys9F/nvJJsp7yPPpm1FBnJV7 fowcQIHqkyIv8BDoTv+QFfjRXFxeq+EMHtG4IEKXWxgEHz8/akbaDAq6pq6nqg8kphr9 s1+3ZznR2ZNroaDYGc2UZDD67FRfA+8yb3DAjmS08bPmP1ciWUz8658yKmN/5ingh0FN 88Y9FiwbWZDRz2HX8hLSdvnhMRCb8juAWqR6ZcGeXGxLtWOz6uE1z+uTCXqeDkNtn4tV fPdw== X-Gm-Message-State: AOJu0YwwhSR86opLXCWpw+rXuArjg+ueGmK4EIwQxBcSjubD5yRKtUnd LXpLluplK0XjmJCX5Ky1gszfQQlh0sYBSY7KlKKw6gQ7MjQPg2XGJ1ckxPR1h4MF2QdNSBpnPL4 UsJnojCZfWedUJQ5HP+fuRPGHS9dYf1u8YDFOccuAQ+U8Ahbqi/UQ2HC5pEE= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6808:10c7:b0:495:f79d:8bd4 with SMTP id 5614622812f47-4ab6a15c6fdmr822919b6e.25.1784944421104; Fri, 24 Jul 2026 18:53:41 -0700 (PDT) Date: Fri, 24 Jul 2026 18:53:41 -0700 In-Reply-To: <6a4fcd58.a1ad617e.25832.000e.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a641725.70955b6c.323240.000f.GAE@google.com> Subject: Forwarded: [PATCH v2] wifi: cfg80211: validate IEs in cfg80211_wext_siwgenie() From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: [PATCH v2] wifi: cfg80211: validate IEs in cfg80211_wext_siwgenie() Author: kartikey406@gmail.com #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci The KASAN allocation trace shows that a malformed IE buffer is stored via SIOCSIWGENIE (cfg80211_wext_siwgenie()) without any validation. The crash trace shows that a subsequent SIOCSIWESSID triggers a connection attempt which calls cfg80211_sme_get_conn_ies() to process the stored IE buffer, causing: - An out-of-bounds read in skip_ie() which reads ies[pos+1] (the length byte) past the end of the 1-byte buffer. - An integer underflow in the memcpy size argument when offs returned by ieee80211_ie_split() exceeds ies_len, causing unsigned subtraction to wrap to SIZE_MAX and triggering a fortify panic. Fix this by validating the IE buffer in cfg80211_wext_siwgenie() before storing it, using for_each_element() and for_each_element_completed() to verify all elements are well-formed. Return -EINVAL if validation fails. Reported-by: syzbot+cc867e537e4bd36f69bb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=cc867e537e4bd36f69bb Signed-off-by: Deepanshu Kartikey --- net/wireless/wext-sme.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c index 573b6b15a446..d3dd5448d723 100644 --- a/net/wireless/wext-sme.c +++ b/net/wireless/wext-sme.c @@ -319,6 +319,14 @@ int cfg80211_wext_siwgenie(struct net_device *dev, return 0; if (ie_len) { + const struct element *elem; + + for_each_element(elem, extra, ie_len) + /* nothing */ + + if (!for_each_element_completed(elem, extra, ie_len)) + return -EINVAL; + ie = kmemdup(extra, ie_len, GFP_KERNEL); if (!ie) return -ENOMEM; -- 2.43.0