From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A46147FAEB for ; Thu, 6 Aug 2026 15:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031891; cv=none; b=MLYvM9IU9ljnJA8VeoXKWcoiIEATw6qqF1X115qkgRgFtRww9kXN8zxWkdouQDn3prKKISHNZkR0wAB+crvl33xIcInyi+9FiTFwmE4ZcZTAbEtKM45pv9Bx4zTqdYN86ptqqq2+WxGcVMUXldZfQxC0N6xSBYN4Hu8w6LNdiVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031891; c=relaxed/simple; bh=YjAJYGsMEG8J0bvWFQuJc8/rvIWCLn/bHxRIHUpvxdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YzhjrdeQm93smKScdq0iraJ2q8EHcJeR7tH5QLXZSSVV8XL0pX/i/Or3XLVb5vL75e1ikADEY4vEC9+MlbxS6wx1Zqn3rQb8qs0KHwCmkkUirlT8nBGPn9B+fqeG9xQO0Od+LMnNgT3MH1Iob9G644UOA0DrMIFPW22ha2jhaUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SWGq3c5F; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WjjsFlAn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SWGq3c5F"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WjjsFlAn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786031885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TpgrFCVNVdoS5oc3yO5w/szZoVoVW3+bvH29IbpSiQ4=; b=SWGq3c5Fvotat8uj4dypU6m47if4Ql68NS6CRjvhgxi/YCbMARG3P2RoScqj2i4eg/bCGv Nw6VKatdBAnEQgXvsiP8+2kC8bJvprBYMOKFKuhRQGjPp+CTbEQrLE8UC25+52crVDFNuO jdhQnikRl2Hqqb1L1m9SlJpqhVQ89O8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-2jPEi8CRNl6oFoz5y0CETg-1; Thu, 06 Aug 2026 11:58:01 -0400 X-MC-Unique: 2jPEi8CRNl6oFoz5y0CETg-1 X-Mimecast-MFC-AGG-ID: 2jPEi8CRNl6oFoz5y0CETg_1786031880 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5b01dc8a5bbso602280e87.1 for ; Thu, 06 Aug 2026 08:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786031880; x=1786636680; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TpgrFCVNVdoS5oc3yO5w/szZoVoVW3+bvH29IbpSiQ4=; b=WjjsFlAnJ6dJ44fj41SuLSUtH9ilJZrbx2zSEcJHfMKXxuOXUHMjJVlRSObb/iGWeH M8qsOzCgGaVLoGg5Q4YaOTcKspgv952rwEy2ohFPhPeMlRcSm8x6VIIG7bPfOavXprXM k1/TCMQHwH74MH0RHXAPkNfKbWYqnXVg8QKxlpfWY5yxU+7ePs6kHESqR/ub4OY9I7yy VNio+gnCIRPxSc9q4kH7yv1TPKMNUkvr6IFvlRw7StK1MjrIeNxuS5iCbRa4VmDH1gZx LAqB2eZojlFLXYuUWigN0cmso8G3qJYHr4r0+H7nOwSm2wrvozSPDcuLiDDnlFQLTozd NeMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786031880; x=1786636680; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TpgrFCVNVdoS5oc3yO5w/szZoVoVW3+bvH29IbpSiQ4=; b=Ine6ol/edOJBTgaFWadCxO6D8MFQmGzMxVsb6M2n9hIcSF/sT5RKldRY71/9xp09L1 BxWfD8r1wWLZuegbjZMOm2KqnCX2Ea5K+6W9QwSe4MU2APnBikYEoW/0SwjlAXjqcbtr Ij/MhsyXx61Kho920jnmuiY2tCyMu7AKM+WT/P++OZgDiqn0kgae4U99DOsf2Jyj6114 4dvKhK3CJ6Yy74RZQONKdi5sQDWZX9lQQL7dsiuI+X70XfZdyMq5RddsH63H6Z7sPgZV s02MwPgnckYbwEbq+ZAma2cIlvo4uzHifeNir8/JJRPW5JVbJx+dmuiyj3jKpANhnSLg Lfyg== X-Gm-Message-State: AOJu0Yy772VcjNmEus5DmouzqHvFVchauuGkhI9vM+hJ4hMB6WipfT2j yvXfbs4LA8trKEuY7lJ2AtpgYYJ9TcA83o124DMRAE6kACW2dKGHm1zfD8F9Dzfd4feTz3hrFDU aofDrG8Iw2ZyOOWyiwHiMaN4pu1RpXP+8pqKOPzYbYW5IIfJnE59MEl3WJGHBOXDGFUQVl9jlpA == X-Gm-Gg: AR+sD13ZxpitDCRgc0HJYD83Tf2FTMRWvhrytwLW5I/2PfH3WEO1fsZdYVUrLZhjxYA P6K9W6UM8S+HlvLYwzT+FIOsK2YC5IuJ9W/7dSUG25m7OX3KSuVJEsLJ0yOogAZRdorFzTzKOkr koEzJEduK49T8ELEhw03wJr2ymRMPm5k/ZFc9+2yUbPrtKmzh4SXNduQv2F4WMsI5b8sNZArx3z xIgGjrW8WmGAKHenq2LXV3lpQH6Qqdb0qoCDOtgmL600N1dnBVSSvyxpnvid2Wv5cptmQFX36H+ zTj69gLrgYb5QyQvSlwN7EAXvcrN79PsXvXHDQktklP4ob7H5UIvyvrYNV3vKadjqnTfFwXORvA 9XEuE6p64kvN5cICFDANv20/JceDkKOQMeUP6swg6cqyA9oeEHKK3koH7 X-Received: by 2002:a05:6512:1083:b0:5b2:a3a2:1395 with SMTP id 2adb3069b0e04-5b2fe39ca69mr1532519e87.3.1786031880371; Thu, 06 Aug 2026 08:58:00 -0700 (PDT) X-Received: by 2002:a05:6512:1083:b0:5b2:a3a2:1395 with SMTP id 2adb3069b0e04-5b2fe39ca69mr1532500e87.3.1786031879886; Thu, 06 Aug 2026 08:57:59 -0700 (PDT) Received: from [192.168.1.26] (pool-68-160-160-85.bstnma.fios.verizon.net. [68.160.160.85]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2f62363fasm830971e87.10.2026.08.06.08.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 08:57:59 -0700 (PDT) Message-ID: <6a6608f4-0a05-4d75-8b7f-edddfac9c5d4@redhat.com> Date: Thu, 6 Aug 2026 11:57:55 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] objtool/klp: sympos/module/alternative/etc fixes To: Josh Poimboeuf , x86@kernel.org Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Peter Zijlstra , Miroslav Benes , Petr Mladek , Song Liu References: Content-Language: en-US From: Joe Lawrence Autocrypt: addr=joe.lawrence@redhat.com; keydata= xsFNBFgTlmsBEADfrZirrMsj9Z9umoJ5p1rgOitLBABITvPO2x5eGBRfXbT306zr226bhfPj +SDlaeIRwKoQvY9ydB3Exq8bKObYZ+6/OAVIDPHBVlnZbysutSHsgdaGqTH9fgYhoJlUIApz suQL0MIRkPi0y+gABbH472f2dUceGpEuudIcGvpnNVTYxqwbWqsSsfT1DaAz9iBCeN+T/f/J 5qOXyZT7lC6vLy07eGg0uBh9jQznhbfXPIev0losNe7HxvgaPaVQ+BS9Q8NF8qpvbgpO+vWQ ZD5+tRJ5t85InNiWR3bv01GcGXEjEVTnExYypajVuHxumqJeqGNeWvx26cfNRQJQxVQNV7Gz iyAmJO7UulyWQiJqHZPcXAfoWyeKKAJ37YIYfE3k+rm6ekIwSgc9Lacf+KBfESNooU1LnwoQ ok9Q6R5r7wqnhCziqXHfyN2YGhm0Wx4s7s6xIVrx3C5K0LjXBisjAthG/hbPhJvsCz5rTOmP jkr+GSwBy2XUdOmtgq1IheBFwvWf08vrzNRCqz3iI1CvRpz0ZYBazmkz924u4ul6W7JuCdgy qW3UDLA77XlzFrA7nJ6rb77aZF7LJlkahX7lMaKZUzH+K4aVKTdvZ3szm9K+v0iixsM0TEnz oWsZgrkAA0OX2lpLfXvskoujQ84lY989IF+nUwy0wRMJPeqNxwARAQABzSZKb2UgTGF3cmVu Y2UgPGpvZS5sYXdyZW5jZUByZWRoYXQuY29tPsLBlgQTAQgAQAIbAwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAFiEEXzkJ3py1AClxRoHJx96nQticmuUFAmF2uf8FCRLJJRQACgkQx96n QticmuU69A/9FB5eF5kc392ifa/G6/m8q5BKVUXBMWy/RcRaEVUwl9lulJd99tkZT5KwwdIU eYSpmT4SXrMzHj3mWe8RcFT9S39RvmZA6UKQkt9mJ+dvUVyDW1pqAB+S6+AEJyzw9AoVPSIG WcHTCHdJZfZOMmFjDyduww7n94qXLO0oRMhjvR9vUqfBgEBSLzRSK96HI38brAcj33Q3lCkf 8uNLEAHVxN57bsNXxMYKo/i7ojFNCOyFEdPCWUMSF+M0D9ScXZRZCwbx0369yPSoNDgSIS8k iC/hbP2YMqaqYjxuoBzTTFuIS60glJu61RNealNjzvdlVz3RnNvD4yKz2JUsEsNGEGi4dRy7 tvULj0njbwdvxV/gRnKboWhXVmlvB1qSfimSNkkoCJHXCApOdW0Og5Wyi+Ia6Qym3h0hwG0r r+w8USCn4Mj5tBcRqJKITm92IbJ73RiJ76TVJksC0yEfbLd6x1u6ifNQh5Q7xMYk0t4VF6bR 56GG+3v1ci1bwwY5g1qfr7COU7in2ZOxhEpHtdt08MDSDFB3But4ko8zYqywP4sxxrJFzIdq 7Kv8a2FsLElJ3xG7jM260sWJfgZNI5fD0anbrzn9Pe1hShZY+4LXVJR/k3H01FkU9jWan0G/ 8vF04bVKng8ZUBBT/6OYoNQHzQ9z++h5ywgMTITy5EK+HhnOwU0EWBOWawEQALxzFFomZI1s 4i0a6ZUn4eQ6Eh2vBTZnMR2vmgGGPZNZdd1Ww62VnpZamDKFddMAQySNuBG1ApgjlFcpX0kV zm8PCi8XvUo0O7LHPKUkOpPM1NJKE1E3n5KqVbcTIftdTu3E/87lwBfEWBHIC+2K6K4GwSLX AMZvFnwqkdyxm9v0UiMSg87Xtf2kXYnqkR5duFudMrY1Wb56UU22mpZmPZ3IUzjV7YTC9Oul DYjkWI+2IN+NS8DXvLW8Dv4ursCiP7TywkxaslVT8z1kqtTUFPjH10aThjsXB5y/uISlj7av EJEmj2Cbt14ps6YOdCT8QOzXcrrBbH2YtKp2PwA3G3hyEsCFdyal8/9h0IBgvRFNilcCxxzq 3gVtrYljN1IcXmx87fbkV8uqNuk+FxR/dK1zgjsGPtuWg1Dj/TrcLst7S+5VdEq87MXahQAE O5qqPjsh3oqW2LtqfXGSQwp7+HRQxRyNdZBTOvhG0sys4GLlyKkqAR+5c6K3Qxh3YGuA77Qb 1vGLwQPfGaUo3soUWVWRfBw8Ugn1ffFbZQnhAs2jwQy3CILhSkBgLSWtNEn80BL/PMAzsh27 msvNMMwVj/M1R9qdk+PcuEJXvjqQA4x/F9ly/eLeiIvspILXQ5LodsITI1lBN2hQSbFFYECy a4KuPkYHPZ3uhcfB0+KroLRxABEBAAHCwXwEGAEIACYCGwwWIQRfOQnenLUAKXFGgcnH3qdC 2Jya5QUCYXa52AUJEskk7QAKCRDH3qdC2Jya5awND/9d9YntR015FVdn910u++9v64fchT+m LqD+WL24hTUMOKUzAVxq+3MLN4XRIcig4vnLmZ2sZ7VXstsukBCNGdm8y7Y8V1tXqeor82IY aPzfFhcTtMWOvrb3/CbwxHWM0VRHWEjR7UXG0tKt2Sen0e9CviScU/mbPHAYsQDkkbkNFmaV KJjtiVlTaIwq/agLZUOTzvcdTYD5QujvfnrcqSaBdSn1+LH3af5T7lANU6L6kYMBKO+40vvk r5w5pyr1AmFU0LCckT2sNeXQwZ7jR8k/7n0OkK3/bNQMlLx3lukVZ1fjKrB79b6CJUpvTUfg 9uxxRFUmO+cWAjd9vOHT1Y9pgTIAELucjmlmoiMSGpbhdE8HNesdtuTEgZotpT1Q2qY7KV5y 46tK1tjphUw8Ln5dEJpNv6wFYFKpnKsiiHgWAaOuWkpHWScKfNHwdbXOw7kvIOrHV0euKhFa 0j0S2Arb+WjjMSJQ7WpC9rzkq1kcpUtdWnKUC24WyZdZ1ZUX2dW2AAmTI1hFtHw42skGRCXO zOpdA5nOdOrGzIu0D9IQD4+npnpSIL5IW9pwZMkkgoD47pdeekzG/xmnvU7CF6iDBzwuG3CC FPtyZxmwRVoS/YeBgzoyEDTwUJDzNGrkkNKnaUbDpg4TLRSCUUhmDUguj0QCa4n8kYoaAw9S pNzsRQ== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/5/26 10:29 AM, Josh Poimboeuf wrote: > v2: > - rebased on tip/master (first 6 patches were merged) > - dropped original patches 7-8 (will post followup) > - added .klp.symid fix > > v1: https://lore.kernel.org/cover.1785727106.git.jpoimboe@kernel.org > > This consolidates fixes for the klp-build issues reported by Joe over > the last several weeks, plus some more things I found while > testing/reviewing. > > Fun stuff like symbol resolution, module dependencies, alternatives. > > Joe Lawrence (1): > objtool/klp: Allow new references to module exports > > Josh Poimboeuf (6): > objtool/klp: Fix vmlinux .klp.symid link error for .no_trim_symbol > symbols > objtool/klp: Fix size of empty special section entries > objtool/klp: Ignore replacement offset of empty x86 alternatives > objtool/klp: Explicitly disallow patching or referencing init > code/data > objtool/klp: Fix cross-module klp relocation section naming > objtool/klp: Don't match local symbols against exports > > tools/objtool/arch/x86/special.c | 27 ++++++++++ > tools/objtool/include/objtool/klp.h | 10 ++-- > tools/objtool/include/objtool/special.h | 7 +++ > tools/objtool/klp-diff.c | 65 ++++++++++++++++++++++--- > tools/objtool/klp-post-link.c | 53 +++++++++++--------- > tools/objtool/klp-symid.c | 1 + > tools/objtool/klp-sympos.c | 10 ++++ > 7 files changed, 141 insertions(+), 32 deletions(-) > These changes (and follow-up comments) look pretty good (lightly tested). Could "objtool/klp: Fix vmlinux .klp.symid link error for .no_trim_symbol symbols" peel off and merge sooner since it fixes a commit just recently merged? Though I think there is a still gap for EXPORT_SYMBOL_FOR_MODULES symbols: those exported that way from vmlinux would presumably need a klp-relocation, but klp_reloc_needed() always returns false for all vmlinux exports. Maybe we need to parse the namespace column from Module.symvers to special case those? (At least, that is how I read the code, I don't have full repro test cases handy.) This wouldn't block any of these patches, but if you are spinning a v3, we could consider tacking that on while we're here. -- Joe