From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbdEFG5M (ORCPT ); Sat, 6 May 2017 02:57:12 -0400 Received: from edison.jonmasters.org ([173.255.233.168]:43956 "EHLO edison.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdEFG5J (ORCPT ); Sat, 6 May 2017 02:57:09 -0400 To: Catalin Marinas , Heinrich Schuchardt References: <20170501223913.6894-1-xypron.glpk@gmx.de> <20170502110827.GA29224@e104818-lin.cambridge.arm.com> Cc: Will Deacon , Steve Capper , Suzuki K Poulose , Andre Przywara , linux-kernel@vger.kernel.org, Julien Grall , linux-arm-kernel@lists.infradead.org From: Jon Masters Organization: World Organi{s,z}ation Of Broken Dreams Message-ID: <6a6c78f4-38b9-5da5-2277-9d9212f803bf@jonmasters.org> Date: Sat, 6 May 2017 02:57:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170502110827.GA29224@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 74.92.29.237 X-SA-Exim-Mail-From: jcm@jonmasters.org Subject: Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo X-SA-Exim-Version: 4.2.1 (built Sun, 08 Nov 2009 07:31:22 +0000) X-SA-Exim-Scanned: Yes (on edison.jonmasters.org) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/2017 07:08 AM, Catalin Marinas wrote: > On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote: >> There is no need to hide the model name in processes >> that are not PER_LINUX32. >> >> So let us always provide a model name that is easily readable. >> >> Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for PER_LINUX32 tasks") >> Signed-off-by: Heinrich Schuchardt >> --- >> arch/arm64/kernel/cpuinfo.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c >> index b3d5b3e8fbcb..9ad9ddcd2f19 100644 >> --- a/arch/arm64/kernel/cpuinfo.c >> +++ b/arch/arm64/kernel/cpuinfo.c >> @@ -118,9 +118,8 @@ static int c_show(struct seq_file *m, void *v) >> * "processor". Give glibc what it expects. >> */ >> seq_printf(m, "processor\t: %d\n", i); >> - if (compat) >> - seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", >> - MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); >> + seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", >> + MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); >> >> seq_printf(m, "BogoMIPS\t: %lu.%02lu\n", >> loops_per_jiffy / (500000UL/HZ), > > Such patch seems to come up regularly: > > https://patchwork.kernel.org/patch/9303311/ > > (and it usually gets rejected) Side note: I'm in the process of reviving a standardization discussion around server and model information, and we'll be coming back with an agenda to get this information in /proc/cpuinfo in coming months. Jon.