From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758136AbcH3KgR convert rfc822-to-8bit (ORCPT ); Tue, 30 Aug 2016 06:36:17 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:6039 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756607AbcH3KgP (ORCPT ); Tue, 30 Aug 2016 06:36:15 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 30 Aug 2016 03:31:43 -0700 From: Sumit Gupta To: Catalin Marinas CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , "yang.shi@linaro.org" , "steve.capper@linaro.org" , "suzuki.poulose@arm.com" , "will.deacon@arm.com" , "julien.grall@arm.com" , Bibek Basu , "james.morse@arm.com" , "linux-tegra@vger.kernel.org" Subject: RE: [PATCH ] arm64: cpuinfo: Add "model name" in /proc/cpuinfo for 64bit tasks also Thread-Topic: [PATCH ] arm64: cpuinfo: Add "model name" in /proc/cpuinfo for 64bit tasks also Thread-Index: AQHSAdQHinea9tjmz0++CzA+Y2pCuaBhO5eAgAAUcGA= Date: Tue, 30 Aug 2016 10:35:56 +0000 Message-ID: <6a6e87361e7c4a1fab9639cb83276765@BGMAIL104.nvidia.com> References: <1472461345-28219-1-git-send-email-sumitg@nvidia.com> <20160830091935.GD5163@e104818-lin.cambridge.arm.com> In-Reply-To: <20160830091935.GD5163@e104818-lin.cambridge.arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.193.30] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Aug 29, 2016 at 02:32:25PM +0530, Sumit Gupta wrote: > > Removed restriction of displaying model name for 32 bit tasks only. > > Because of this Processor details were not displayed in "System > > setting -> Details" in Ubuntu model name display is generic and can be > > printed for 64 bit also. > > > > model name : ARMv8 Processor rev X (v8l) > > > > Signed-off-by: Sumit Gupta > > You didn't give a reason why this is needed. For 32-bit tasks, we did it for > backwards compatibility with code checking for it. > Within Ubuntu Home Screen "System setting -> details", processor details were coming as null. It seems those details are retrieved from "model name" in /proc/cpuinfo and because of check for 32 bit tasks only, "model name" was not getting displayed. On removing this check for model name, processor details are getting displayed in Ubuntu Home Screen. I think model name field is general and can be displayed irrespective of compatibility. Please suggest if I am missing anything. > -- > Catalin