From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62BF3E3DB5 for ; Thu, 23 Apr 2026 09:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936740; cv=none; b=VbFO777/t+6/MF2FuwtoyI9RYyT8DqFtchyxUuFKVf+PKG498pG2Wemo2IoTOw69pJFq1Y++KSXsnxgAKWf/3dMprgnwkj8wiTXgST1MNb8TeiXW25qOKPNF/BXpTyFbHZQZFwy9dw1/5SZfCjcrdRCBq+yExFoMEH02suwix7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936740; c=relaxed/simple; bh=Krl0RYxK8i+6LppjhYOLg6KRF2G2sUhiGaAzc13ALEw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l+fpK6DVcvgcL0XXGzI45ddLoJ6MEyseIlAArZSfqoCglwsq70rox5qbTga/qspGE0iDiMGRVylqPcU4dzdtMhyowX5IAysrGfBkQOLEEG8IV/e1vTg3zP/zowRy2EC30oMQe0/pw+DSY36BYrQuvClq5ADJ7uyybMOMuXehU94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ewGjCZaY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K23NdgNf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ewGjCZaY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K23NdgNf" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEnm4177860 for ; Thu, 23 Apr 2026 09:32:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zp9onLJtY/hsYEkNo1u0iGD47qM37NcirSxgBjEKwME=; b=ewGjCZaYx95sXa/T DbwtvjRuHcsPwPIe7ZQvgBku2QR/upIT5kMXr4quMVQxioq10fBIyhvLyQ71BRsB mFoBItVbcfxhRpN7MudgFBgfCp4E0lD5pl34tlj1b9EmRE/XpO5vhyGf4nFUmKBK ydbSbWkfEN9LSCmaE+zDbBl/OlhsXS+cLGMvPZDIpX+rMg7e0zx81wkto/yPgaCw qGTXYqLdv8E32OJ/Z2e7Wk5u3l4txc28dervxjOo7HlmUdG+EN5+mOOx5i4u17yh od/KW4PuCladRkjXpeuabVYv8nlcgjtDQRjEc5J3iCYNt36KNxWih2pakbTPPLB+ 8sZNBA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1h7b74p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 09:32:18 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d9f1bccd7so12375451cf.1 for ; Thu, 23 Apr 2026 02:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776936738; x=1777541538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zp9onLJtY/hsYEkNo1u0iGD47qM37NcirSxgBjEKwME=; b=K23NdgNfcfa/ThN8pHIw274BPeYH2eXDecfh3gQ4mtqa07c65oVWz6w9r7AYQVhN8v Geg6ovBUf+xYmgn2h3lZlV65fy0xhIIKdHaBlFvBAV4E3NNdLy+1Uy6hzG6xVUqVwylx S+jLp0yfPBZSnu/XPMciRy1lQwYq0sdbsGEXWarjGS5DjqpkxTo1NlA0RSJ+cSvreRai 4lo2J4xku/TezdFCB2JkyU4VpIYbHtYKWrFlOflglKjOkH5tQOHJNTP1i8DNgjNrPZF4 x6+6mpBjwMulUeR+eeENH2LfWwNRtXDZ7xnT7WnEY7e7YXTrcak/koFqae+RaT2M6zPf Kc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776936738; x=1777541538; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zp9onLJtY/hsYEkNo1u0iGD47qM37NcirSxgBjEKwME=; b=WLMiLKDL9dcAXQlg2Ij3oZLYhFqekV3o7RT2OFvhRwDtqJhnxWdDv5lBBfnN79Nurs 79svOJ1XnPqTMBEJZptTsrIHPurVRvPjllkTroWgrwUnCLenKaxd77Cv8EICGt/5Znco UdRiDeYO3hp6OrgdEtKMLemmyjTuaMXVz87BdDpt/zux09A6v7SR7bxwNuilnOGXFe30 Id0qdLivB3oAnqxEIDNZhOCErLrpEUdC6l2ne+pBfJOjNqSC89W1INZv84w1P2cXcNy8 WKL1oCb7VB6ApPxLkopaUuVzKUr1iGypt+cU0w2+VcK5KBoiTkIfvHFrCxezUJ0xjBk4 a3Aw== X-Forwarded-Encrypted: i=1; AFNElJ90aIaDtBKd+YQ3PZJTmv1UoWe6gs0biY2ObPR6bScPyThC4pjPHBWZy4r9RFjezimRLUnoL7VAIkx6ZBI=@vger.kernel.org X-Gm-Message-State: AOJu0YwdfmOJDopQZZjH96cXaMRxrkSUqJIBy0rYhakk05rengN7FF7P ywJmuQsoh3DYCQz9hJjauo0wY0IBgWCGg0XDl68Z8tQzrn4Ei1Bsf6NbpoZe60AaB2Kqbxcw7AO a3aF5Rliu3uZfrCj1C/JKAekc7vSHq2ZY05FATkoxTLJ5ogHua4W1AByOSFfXrGob2YE= X-Gm-Gg: AeBDietiskL45brzKpOPEQ+hKrkZGUrFeCHqP82YY2flwcKVXoakQzuoW3z4PuErGkQ rTZZgz8JH8FLCj0HXNvb89DR1TM10HT/XMgID6n3SCYNAr3es1yKjRvXDAMsuXpvOagMqQVYifo EX+6cAh/TIUr8qmvZbHFR2N0jUPBk1c/51YvNG5+I7sFXHGmo0PXsRjwUQTeXZn97FcktCJwrUZ 5k7Eb4PVZWecrFBbiyvB5vjR13JSNJLu7If7CwyaZzIw7nRjhhmlnqP4VMRPr2746bNAvkk+Crb Mfw/I5hqxu8ohPYX2eDJfdF0JE1bd+9L7ml0e3nEK+Dkawpsp6ypa0zbKpjqeSgF8AvthrJPUSB 8xb9x3lujo4ab1sD7C8XUyu+8aavskXEsw43IaP8+KlvyiYN4s9JI4gFntv3wjQeLqdnIG8yhaE oLG5Ne+LlTbMRkgQ== X-Received: by 2002:ac8:5f0c:0:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-50e5e6ace9dmr161096401cf.1.1776936737957; Thu, 23 Apr 2026 02:32:17 -0700 (PDT) X-Received: by 2002:ac8:5f0c:0:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-50e5e6ace9dmr161096101cf.1.1776936737526; Thu, 23 Apr 2026 02:32:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba451210e3dsm641956566b.2.2026.04.23.02.32.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 02:32:16 -0700 (PDT) Message-ID: <6a83b074-8a19-4148-a4df-bd11e27e7dce@oss.qualcomm.com> Date: Thu, 23 Apr 2026 11:32:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables To: Yongxing Mou , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260422-edp_phy-v4-0-c38bef2d027b@oss.qualcomm.com> <20260422-edp_phy-v4-3-c38bef2d027b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Lba4z2dtt_lrGTPv3PhYKz04eA1p0qgV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDA5MiBTYWx0ZWRfXxwn2d9N23+qX oNCQXOtpvZmql9+4iQtJymhpWAEVj56i9tLy7oz8701aKLu8Cf127qiO0koV2xegnH4hA5+BUIW iXq/Ypvvf63mG67zW17JThAc+drV845d33Bge7aepopxlmcFmi2sGLnqcsD4xlcv6V2Yf5ZsrSN ezNVNgn97POyyGmLMmH7cRZ5r5VbzugLjq2kYhx7XIVjcd5EH/5QpGcxWT7RuKkmya35EpPYmOy plmKOyNmQxBgwpUJqFTZWuravm5Zej0iMjLRlhkwDP8hEzKpeQMWrEBVrZLMqQwvDsSndq5tpJ2 3ZDBx2lZkDUAmkS4XJ3Yll1D1TUo8YlHiBCCM3VWuaE3c2sy1dWOHTN1M+9Z9zCsKb8zxMnI3ZG O6qPBK96/nQjwMvtFITF/jCWtyg5+oDvTeomRQ7MvDf9DyShpUNsif3s1KybgJytqym1+3okz7K WkhqJmez1gVuyd/Hk9Q== X-Authority-Analysis: v=2.4 cv=UqNT8ewB c=1 sm=1 tr=0 ts=69e9e722 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=UMJivPYMbgTVa61FHsgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: Lba4z2dtt_lrGTPv3PhYKz04eA1p0qgV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230092 On 4/23/26 5:28 AM, Yongxing Mou wrote: > > > On 4/22/2026 6:42 PM, Konrad Dybcio wrote: >> On 4/22/26 8:01 AM, Yongxing Mou wrote: >>> SC7280 and SC8180X previously shared the same cfg because they did not use >>> swing/pre-emphasis tables. Add the corresponding tables for these >>> platforms. Since they have different PHY sub-versions, their eDP/DP mode >>> tables also differ, so move SC8180X to its own cfg instead of reusing the >>> SC7280 one. >>> >>> Signed-off-by: Yongxing Mou >>> --- >> >> >> >>> +static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg_v2 = { >>> +    .swing_hbr_rbr = &edp_swing_hbr_rbr, >> >> For eDP / low-Vdiff: >> >> I believe the RBR swing settings for 8180 should >> instead be: >> >> 0x07 0x0f 0x17 0x1f (matches) > Emm i see from ipcat eDP Low vdiff(Lower HBR)  swing settings is > 0x07 0x0f 0x16 0x1f Yes, you're right, I made a typo [...] >> .pre_emphasis_hbr3_hbr2 OK >> .pre_emphasis_hbr_rbr same as above >> > Thanks for point this, so pre_emphasis_hbr_rbr same with pre_emphasis_hbr3_hbr2?  I also don't get it's RBR or HBR3 from phy HPG. But now i think only eDP will be used in upstreamed poipu boards. i check the dts and not find any poipu boards will use DP mode(or mini DP).. Yeah let's not worry about it today.. Konrad