From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A6C2E8B67 for ; Thu, 20 Aug 2026 06:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787207585; cv=none; b=h1ZQhg2D1l5hFLWHT5x4aNbUPRWeYfNZeMgvLM1WxJmac7SRoKXeCM3brQcRsBS06OVLPBSFqfFqYXI7GmPEI/M+P0TJlfHTBEBfy9/KnRggJZBDh2Kql8cHamE6vkYdWdDH3AWoPFhr/XIMiWXdTA6lHjznjiWM/vfcbLJRLs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787207585; c=relaxed/simple; bh=USlhX9g8ltOaIgUeRBTzFSUq/mAvwDRXc+gGEGn611k=; h=Message-ID:Date:From:To:Cc:Subject:MIME-Version:Content-Type: Content-Disposition; b=K5nIOPmV2blH2gaR4yqTt2kr7EJVQ4DgMqCrtS8Ty/yAhmAXqX5IrA7Y4ZLYNI2f/DZUWlLCXRrUvDssjeIJzzSMbJDfKLEePPCzH/MhlQfUPXi5rlQgALBNz+IvbxF02SpxtP3M16Ji+Pzdm30YHnZQmWf1dgNBvXIrLU8ucz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZmYJLDhX; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZmYJLDhX" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2caed617615so19749995ad.3 for ; Wed, 19 Aug 2026 23:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787207583; x=1787812383; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:subject:cc:to:from :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lFqWzKAPw9BnDuKrcJ2deig/zofyqA4nB0pnofhUsgs=; b=ZmYJLDhXmaE2fwo/xEB+bonrj4mLqNx0XUPi5BOB2Q0yldlAJuqdegIYq00o08YgKl auK5nLQVFmqbcjTR61e7ODkPjiHRogTbu7xE8nP2vGhcYsE4PIg9fQVdjUNYsJ51ST3Q KDHCf9skNyUoJvAFIjjpmYLEmV167w3bf/E9RotEn0g6oURqyalFMAs/spKSAJdQMyxM Ip1EV9rxwSUpUgCwlZUHXNvFznX5c12LCXe7mcWz5BQZ5HY73jKxA2eNZMSUwqsBJSYI OcU1l9WkQRBUIW4rhYZcBqQrwW8LTLQJsz0nJsWO4b5fDXgfFxWU4lzSGyUXpTEz2Qv0 +lyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787207583; x=1787812383; h=content-disposition:content-type:mime-version:subject:cc:to:from :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lFqWzKAPw9BnDuKrcJ2deig/zofyqA4nB0pnofhUsgs=; b=WE8fnXeMZ+xrEhWxlag82HacUzylTSzZoXFblXN2rmCe3oDv2NKtg01Op15PXKNr9f 1iV0u3Pw7+QMPl4QLCfjWZ1Io2sS7GOWSCvJZnoSWSI6TxSV00HZXQKvndA70EXvbWDF Gw1NhX1kjnRxBJcqi0zz4rHJ4uX1kBY5w80dkdcAtmsmXccPzcULQjG1p6ZxfcU1KELv 2sKH3t2d89LCHmklX+4BOtXFk/a4JG82BOfLmkOPzGwxXHWhZqSEi/C06V8eeb/5kUOH cviWN+lQfIbTb5X+rVRkQ0aShPbqNa7q2CQv6kLIrhTo6Qr/aehZy+BzkUHAd6qCrvaW Lw1w== X-Forwarded-Encrypted: i=1; AHgh+RoX+ykjt6KSpkyko7EmomLm0gZCxgJNEpnkrk3uQ0OZ+++kib7k5oAmxLRjIbOCWfIAHrN/N9Em86mcOJ8=@vger.kernel.org X-Gm-Message-State: AFuF++lgTlv8XV1TigzQGb1s26/BNl2oRT+73q2lf1Ql7hUeCtyLJhF1 tyYyA72RJeMFkILmKsRTKE5zhmOMZcpaUCYG5yz5yCmoKtj3hu03KgIe X-Gm-Gg: AR+sD12oVm6QPGKFZjCpnZQDTS5I6Q2kLqidCN6k38KTnczSC+pCwLzcKGYSRx53gUm 0IiM8qA9LXovUl2mj3D/wHyNA/n6Um9cK/8mj033YqSfnm1H5cXHm/uRi1dVPX7NV7p5H4UdAoR 7nbzta1lP6BXuKchfAupxjIjkuRzJ/szezoz6TUwykQPvjLrJXLXLDqg5mvSw9Vl9UezkMNMaxa KiXsrD7O3TWDdXfKrk64xVzqgxVPZZqCHld8l176huwubW92qSs69jznkQx8O7NAW7LN8Rmzckg wjGDqWRw8OQwvn4fZsGET713PyMZIaG11MsNv5SY0/JI6wZEfEEVOuRI8FeraUadgLqH7CCGypt ImCKGst3Y2OmOyy80BughflhUYoV+OEOSvTfZREHXnisJYUmffKMek6NC+IoBCMk2TzmMXdoLA/ NcbkUrXrbl/0nGIf56u2UqSvA6DwLqLGYUmpRkV9J3R2OKobO7rERCl1dYCnf+zp/5o/7bPUGef MPVekBvhByJ+aItz3OmjwQmfmGWHwMI3wHlk8bQgWvPZg== X-Received: by 2002:a17:903:3b84:b0:2d5:2f49:b3de with SMTP id d9443c01a7336-2d5fd3e78f6mr207097945ad.0.1787207583176; Wed, 19 Aug 2026 23:33:03 -0700 (PDT) Received: from localhost (75-172-9-230.tukw.qwest.net. [75.172.9.230]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327cbb46ff8sm7081965eec.23.2026.08.19.23.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 23:33:02 -0700 (PDT) Message-ID: <6a869f9e.c86fb4cb.55bb8.d1d7@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 19 Aug 2026 23:32:58 -0700 From: Dennis Tighe To: Namjae Jeon , Hyunchul Lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ntfs: fix off-by-one page overflow in ntfs_decompress() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The per-token range check in ntfs_decompress() uses if (cb >= cb_sb_end || dp_addr > dp_sb_end) break; so dp_addr == dp_sb_end falls through to the symbol copy `*dp_addr++ = *cb++`, writing one byte past the destination page. Since NTFS_SB_SIZE == PAGE_SIZE the destination is a single page, so the byte lands in the adjacent page, and *dest_ofs is left one past the sub-block end (the later `*dest_ofs &= ~PAGE_MASK` then yields 1, not 0, so the page is never finalized and later sub-blocks keep writing further past it). A corrupted compressed $DATA attribute thus produces a bounded run of out-of-bounds writes when the file is read. Break as soon as dp_addr reaches dp_sb_end; a full sub-block still completes, as its final copy advances dp_addr to exactly dp_sb_end. Fixes: 1e9ea7e04472 ("Revert "fs: Remove NTFS classic"") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Dennis Tighe Reviewed-by: Hyunchul Lee --- fixing blankspace, no functional change fs/ntfs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs/compress.c b/fs/ntfs/compress.c index 76bd806..dc5ad95 100644 --- a/fs/ntfs/compress.c +++ b/fs/ntfs/compress.c @@ -352,7 +352,7 @@ static int ntfs_decompress(struct page *dest_pages[], int completed_pages[], u8 *dp_back_addr; /* Check if we are done / still in range. */ - if (cb >= cb_sb_end || dp_addr > dp_sb_end) + if (cb >= cb_sb_end || dp_addr >= dp_sb_end) break; /* Determine token type and parse appropriately.*/ -- 2.47.3